From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 0AD0FE07 for ; Mon, 30 Apr 2018 15:46:22 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 784BF8DC3F; Mon, 30 Apr 2018 13:46:22 +0000 (UTC) Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DD642166BAD; Mon, 30 Apr 2018 13:46:19 +0000 (UTC) To: Luca Boccassi , xiangxia.m.yue@gmail.com, jianfeng.tan@intel.com, yliu@fridaylinux.org Cc: stable@dpdk.org References: <1524840538-3941-1-git-send-email-xiangxia.m.yue@gmail.com> <1525095883.23337.21.camel@debian.org> From: Maxime Coquelin Message-ID: Date: Mon, 30 Apr 2018 15:46:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525095883.23337.21.camel@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 30 Apr 2018 13:46:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 30 Apr 2018 13:46:22 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 13:46:23 -0000 On 04/30/2018 03:44 PM, Luca Boccassi wrote: > On Fri, 2018-04-27 at 07:48 -0700, xiangxia.m.yue@gmail.com wrote: >> From: Tonghao Zhang >> >> When qemu close the unix socket fd of the vhostuser as a >> server, and then immediately delete the vhostuser port on >> openvswitch. There will be a deadlock. >> >> A thread (fdset event thread):       B thread: >> 1. fdset_event_dispatch              rte_vhost_driver_unregister >> 2. set the fd busy to 1.             lock vsocket->conn_mutex >> 3. vhost_user_read_cb                fdset_del waits busy changed to >> 0. >> 4. vhost peer closed, remove the >>    conn from vsocket->conn_list: >>    lock vsocket->conn_mutex >> >> 5. set the fd busy to 0 >> >> Fixes: 65388b43 ("vhost: fix fd leaks for vhost-user server mode") >> Cc: stable@dpdk.org >> Cc: Yuanhan Liu >> Signed-off-by: Tonghao Zhang > > Hi, has a version of this series been merged into mainline? > No, not yet. In my plans for -rc2. Cheers, Maxime