From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78]) by dpdk.org (Postfix) with ESMTP id 03F135F2C for ; Fri, 5 Oct 2018 01:45:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4676; q=dns/txt; s=iport; t=1538696724; x=1539906324; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wB6Jo4LthOBOZQuF73bRYvrExSAGZOAfEzLTwrucWvA=; b=OipttY0u2yJDzNgFxFWMw6x+Gv8dcPCqvo+yRklUKpdoMx4XHyQ1Y+7Z HhbUMH6tfwxMFf+pc76y4aOncP5vhKXLA8/uxIUIRChpwUWq0g7hZw3fX 0N03XdI3kY/UpfuhYqZngnZZVB6+CPqxAhd4B3yWVpr2L4odUDjkhrXSg Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AEAAC4pLZb/4oNJK1bGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggVmfygKi3+MIoINiGONehSBZgsBASO?= =?us-ascii?q?BDl2CXgKEJSE0DQ0BAwEBAgEBAm0cDIU5AQEBAQMnEz8MBAIBCA4DBAEBAR4?= =?us-ascii?q?QIREUCQgCBA4FCIMUBAKBaQMVD6VjM4c2AwqCTAWLLBeBQT+DbzWCVkUEGIE?= =?us-ascii?q?UARIBhXcCiGGUSiwJAoZIhlmDFR+BTIRiiT2JBIQKiCoCERSBJR04DVdxcBW?= =?us-ascii?q?DJ4IlF4NGilJvAQGLC4EfMm0BAQ?= X-IronPort-AV: E=Sophos;i="5.54,342,1534809600"; d="scan'208";a="458563166" Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 23:45:23 +0000 Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id w94NjNei020457 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 4 Oct 2018 23:45:23 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Oct 2018 18:45:23 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1395.000; Thu, 4 Oct 2018 18:45:23 -0500 From: "John Daley (johndale)" To: Yongseok Koh CC: dpdk stable , "Hyong Youb Kim (hyonkim)" Thread-Topic: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak Thread-Index: AQHUVs27i5nXOnbGjUGGYTTuFTl6mKUP+poA//+w+ZCAAHHFgP//rN8w Date: Thu, 4 Oct 2018 23:45:22 +0000 Message-ID: References: <20180928015105.14831-1-johndale@cisco.com> <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> <52280fb7c947471da4432fd7d08fb0a9@XCH-RCD-007.cisco.com> <507263C0-7F4C-45A7-95B5-2A17C4D4D0A1@mellanox.com> In-Reply-To: <507263C0-7F4C-45A7-95B5-2A17C4D4D0A1@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.41.125] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Outbound-SMTP-Client: 173.37.102.13, xch-rcd-003.cisco.com X-Outbound-Node: alln-core-5.cisco.com Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 23:45:25 -0000 Got it, thanks Yongseok for the clarification. I may have sent it twice by = accident.=20 -john > -----Original Message----- > From: Yongseok Koh > Sent: Thursday, October 04, 2018 4:40 PM > To: John Daley (johndale) > Cc: johnda888@gmail.com; dpdk stable ; Hyong Youb Kim > (hyonkim) > Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak >=20 >=20 > > On Oct 4, 2018, at 3:03 PM, John Daley (johndale) > wrote: > > > > Hi Yongseok, > > > > It should go into 17.11 and hopefully 18.02, 18.05, 18.08 eventually. > > > > Not sure what you mean when you say it was only for stable releases. > > It was submitted to dev@ with the Cc: stable@ in the commit. The patch > > is here: > > > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat > > > ches.dpdk.org%2Fpatch%2F45545%2F&data=3D02%7C01%7Cyskoh%40me > llanox.c > > > om%7Cb5541c8c6a2f4da3a1b908d62a454896%7Ca652971c7d2e4d9ba6a4d1 > 49256f46 > > > 1b%7C0%7C0%7C636742874397325810&sdata=3DwBWZ13CGeDZB3dnm% > 2Bv4fXivc%2 > > BRQGRCpotawCQ3oE6PU%3D&reserved=3D0 > > > > When cc'ing stable in dev@ submissions, should we generally follow up > with an email to stable@ to indicate which stable branches to target? If = so, > should we update the instructions in the contributors guide (section 6.4)= , or > did I miss where that process is documented? >=20 > If you send out a patch to dev@dpdk.org with the tag (Cc: stable@dpdk.org= ), > the patch will automatically be queued for stable branches. But the reaso= n > why I asked the question was this specific one has been sent to > stable@dpdk.org without dev@dpdk.org. It looks you've sent the same patch > twice? >=20 > Summary. >=20 > 1) If you want to fix a bug in the current upstream (dpdk/master), send t= he > fix to dev@dpdk.org with the stable cc tag, then it will be automatically > queued to be backported to a stable branch if the bug is in the stable br= anch. > If you don't think backporting is necessary, you don't need to add the st= able > cc tag. > Then, nothing will happen. >=20 > 2) If you want to fix a bug and the bug exists only in a stable branch, n= ot in > the master branch, then you should send it only to stable@dpdk.org with a > prefix. Please refer to "5.11.1. Backporting patches for Stable Releases"= in the > guide. E.g., > git send-email --subject-prefix=3D'PATCH 16.11' ... > If the bug exists in multiple stable branches, you should send it multipl= e > times. >=20 >=20 > Thanks, > Yongseok >=20 > > Thanks, > > John > > > >> -----Original Message----- > >> From: Yongseok Koh > >> Sent: Thursday, October 04, 2018 2:36 PM > >> To: John Daley (johndale) > >> Cc: johnda888@gmail.com; dpdk stable ; Hyong Youb > >> Kim > >> (hyonkim) > >> Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory > >> leak > >> > >> > >>> On Sep 27, 2018, at 6:51 PM, John Daley wrote: > >>> > >>> rte_flow structures were not being freed when destroyed or flushed. > >>> > >>> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced > >>> filters enabled") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Hyong Youb Kim > >>> Reviewed-by: John Daley > >>> --- > >> > >> Hi, > >> > >> Is this patch only for stable releases? If so, which one? Or was dev@ > >> absent by mistake? > >> > >> > >> Thanks, > >> Yongseok > >> > >>> drivers/net/enic/enic_flow.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/drivers/net/enic/enic_flow.c > >>> b/drivers/net/enic/enic_flow.c index 0cf04aefd..9b612f1d5 100644 > >>> --- a/drivers/net/enic/enic_flow.c > >>> +++ b/drivers/net/enic/enic_flow.c > >>> @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, > >> struct rte_flow *flow, > >>> enic_flow_del_filter(enic, flow->enic_filter_id, error); > >>> LIST_REMOVE(flow, next); > >>> rte_spinlock_unlock(&enic->flows_lock); > >>> + rte_free(flow); > >>> return 0; > >>> } > >>> > >>> @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, > >>> struct > >> rte_flow_error *error) > >>> flow =3D LIST_FIRST(&enic->flows); > >>> enic_flow_del_filter(enic, flow->enic_filter_id, error); > >>> LIST_REMOVE(flow, next); > >>> + rte_free(flow); > >>> } > >>> rte_spinlock_unlock(&enic->flows_lock); > >>> return 0; > >>> -- > >>> 2.16.2 > >>> > >