From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Zhang, Fan" <fanzhang.oss@gmail.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Cc: stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Shai Brandes <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
Stanislaw Kardach <kda@semihalf.com>,
Dawid Gorecki <dgr@semihalf.com>
Subject: Re: [PATCH] net/ena: fix deadlock in RSS reta update
Date: Fri, 6 Jan 2023 20:58:26 +0000 [thread overview]
Message-ID: <b8e83566-b20d-b56d-3f88-ab7a0f92ba0c@amd.com> (raw)
In-Reply-To: <4d77aa17-5ea7-cdd7-fc5b-308348b2f3c2@gmail.com>
On 1/5/2023 2:05 PM, Zhang, Fan wrote:
>
> On 1/5/2023 1:57 PM, David Marchand wrote:
>> Add missing lock release in case of internal failure.
>>
>> Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>> drivers/net/ena/ena_rss.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c
>> index b682d01c20..d0ba9d5c0a 100644
>> --- a/drivers/net/ena/ena_rss.c
>> +++ b/drivers/net/ena/ena_rss.c
>> @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev,
>> if (unlikely(rc != 0)) {
>> PMD_DRV_LOG(ERR,
>> "Cannot fill indirection table\n");
>> + rte_spinlock_unlock(&adapter->admin_lock);
>> return rc;
>> }
>> }
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-01-06 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 13:57 David Marchand
2023-01-05 14:05 ` Zhang, Fan
2023-01-06 20:58 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e83566-b20d-b56d-3f88-ab7a0f92ba0c@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dgr@semihalf.com \
--cc=evgenys@amazon.com \
--cc=fanzhang.oss@gmail.com \
--cc=igorch@amazon.com \
--cc=kda@semihalf.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).