From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36215A04A4 for ; Thu, 3 Mar 2022 12:31:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27C5242771; Thu, 3 Mar 2022 12:31:46 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 1591540141; Thu, 3 Mar 2022 12:31:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646307104; x=1677843104; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=bbC36xsOgynY7nUjvr/Rn0Hwbq8FZNwZfzFsCkX18kU=; b=eLx67Yrm6AAQldsp1n8CFMZu5Ss/1tm/Z/aV+ZFtMpBxEYABnAoXuC3q FSzOfBXM6q08XxykeMaB3n4Kc1zZWEIrVUjOJ44XSAzJaspDxcU2hzcIj Uy3L0OLiaRJJJvG+WDGNzILiLOJEicNPJp6SyTfKZ7k8Y01lkoloORssv bfE+4G6eoAjOzNbJdv6BGzGGyN8jMlFLEm8SbBmxOgq+Z8IpcVDu1Lg/O fvfLaLHiIhbfkiK5odxm5ndNP7YlPGjqT3Ab+tEXCXO21TKriKtEywk3I /DTe1d+1qC8rR+j6B1mkDpqkZ4hHqdaecGBu65nkxgpF7rioiY7R8SCNy w==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="253578217" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="253578217" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 03:31:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="642084529" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 03 Mar 2022 03:31:43 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 03:31:42 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 03:31:42 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 03:31:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bTZoqIkKBDxCEjfwi2fDTKqWjVCcxZ1uigKsE9SZCnxt9kDvhzRGoS1tsrws3nyIY1/jKkBGHEh7JC4TsnqrdzH4ahqjMjfo39/w99ZS7bxH6UoCZZ0rl1o3o8r2f6bP6mKSRuamLAK9NPCgOB1GRK0weVtZ36hPs3zp3s6i9Ew1YmjOwRqVW9dd49SllGENAnBY6n0mhsgC8UIMuOYSTHnv1b3ULD0AK/DwP9KN5sYA6iSS1PMgOvry8dWiJSZGQMNB6kcOO/0bUxFitK+x3mv8it6mYqkTY1/m2/1y+FjABCTQyLNvkelF/836zZuOa4BUiFU72rhWkCAt8wYHRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAKS75/t5Vge/T1A8CbjmgazNwSUutSev+S8+YIzCr4=; b=IuDP06ZqqoeLnmPGWZnLzOo2n3Fviek+IhcKMGDm5+MmjuD3idaaxMkbam7eyYQ8P/lHXPpkr98/YwkRM4nQ4VLLGCjwZCgW2Ss30N3DRqnvv0iZ6wN4kQEtkkZsCoJ/SEKpD3DhOgXzSFuXOE7RBKFsK6zoowD857GNDvI96xTm8dzRQXCWBX+H+p1gKEYgNkHCfewxIx9rXAQtB3fwdc0Yxg2QvODDtYgW9hUNrUEWYpDQ2ahrkBqAZotBL87kqK0t3Ko+RO+XvaBqsQQxU5sVqcfFIYc1qi9x+fnliqOnMyX8YkIL1jlUFxK8lu8yPwg+Rhgp1ea2xcfEuDXDdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR1101MB2337.namprd11.prod.outlook.com (2603:10b6:404:92::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 11:31:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 11:31:39 +0000 Message-ID: Date: Thu, 3 Mar 2022 11:31:32 +0000 Content-Language: en-US To: Harold Huang , CC: , Liron Himi References: <20220302123400.188209-1-baymaxhuang@gmail.com> <20220303021803.382374-1-baymaxhuang@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it X-User: ferruhy In-Reply-To: <20220303021803.382374-1-baymaxhuang@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::11) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2edb8f8-19aa-4a87-1082-08d9fd0961de X-MS-TrafficTypeDiagnostic: BN6PR1101MB2337:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TBVrJSqgulbxCSWRCXr0gwN60QERuouJbasC0f5z3jz8OBL6YrTlKDQHKohRh0F289UeyNS/i3ZJEEUz9H73eH60umy9dHP9D1laGzv30OGEVjPDU2imG2Dg+NAitjQC7ZYLf/YRetCnFuPP3pPqoiQ2MtZGdEnSvQh0aaq4l7g2ID7EYtNmDMfg1xysHgPrli3HPKCtg0Vyo5WmbH0IQLBhCZwdp5scqjv7+i2wRLHXqPNPp3iRS/AiaH5cM8XkQUatVj4Gltr2fR4U3X9iRkIkoxr/HYCr+fw1cwLphXFvny2wVwo6SkNwxSKb/w/cvRdC6SA2I1TRA5kGMCpTqVLcZ5D6w6RhK9nXh9INfPZHqb7UeXC0OCYq3Pd6Ml4NuawM35qQ5yk4ldjEd6a1rwdtCA7qDNDHwFlxRW7JcT6g+RFUL6l2mGXNeOxg1p9E78eMpqUqpu/AETPYfYEvXg/htR5tq2jn2LZAmLVxAC1ybtsVA3aqGaxD8g9GFQV9SawZHJBPV4ePbDr5+NjUo3sgZad/fkPh09f3MUbsiqmjgXm8ajCbThNBBj5E+0qOTyFw2hbhsgDyngdOLySYV2owHoLq57twPJ9MqC7vZReqFL+L+cZMh+K/Dp1azRI2+j7DX7r97PBRrEkZMxaetzd4C2PVnhe/tu5sg+QwSdAdDeMu6jjF5//tr34ZncgAP8oMZe/ug+JC8veTjVIZTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(53546011)(38100700002)(8676002)(6506007)(44832011)(5660300002)(4744005)(8936002)(4326008)(66946007)(6666004)(66476007)(66556008)(2906002)(186003)(86362001)(316002)(26005)(2616005)(31696002)(6512007)(31686004)(36756003)(508600001)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEE4VjVnQjZtUmJGLzE1VzNocndnanVXWVFuN2pMWkdRM2ZzOUdjaHBKaEhw?= =?utf-8?B?U1FBRU9ZRDA4NmIxRlArbWFwRGI4QnRkcWxqdzhtNTlBcmNIU3ltcUV4eGpP?= =?utf-8?B?bzhsTFpGcERwcVpFcWx2R0xmeEtHYlNwT1pvcmw5SkJrVEgxbk1WM203R0Iz?= =?utf-8?B?UGtaYXJuNmovc1NtaGRkVmdoOTZVNkNZYTNEdlNtNXY4cG9hcU1mRUJHVHZ4?= =?utf-8?B?WElVbXp1SHdpTWZ1Y3lic3dMTGlyUGpEQmJldW41NnZEaE5PWUtSeVFLMW9x?= =?utf-8?B?UkNZZkh4ckx5dEwrcDIwWXExN3orRTRBam1qdmhtMkhRbXE4V0pRalpXU21t?= =?utf-8?B?blRPSlgxSEw4ZG0wazF5UTF3Zm5yV0JMOTIyOVBmYTlCQnNaVzN6NjlGNUJa?= =?utf-8?B?SlcrOG5nc3oxdUlPUFdHMHFIVUp1MzZUZFYrQkhhaVlvcFhpeWcyOHNsVkVv?= =?utf-8?B?TmZ2bXRQbWJzelI4aTIrOXFrVTR1V3ZEcmdFWEZvL2FCQ2k3Y0w0ZG10MHJk?= =?utf-8?B?dnIwMkNhMmFZeUgzMXF2eWZWVHU2c2JsRHV6ZFlTUndRbjdtR3BxeTVSeEJk?= =?utf-8?B?RS9TUjJyM1l3RXdtMW1lRFlrU1E5dnBPcUJINUNjUUZMRWZzN3NUOFdjRXZw?= =?utf-8?B?a2RMLzYyUmdUSWZORHluNTdTenFnLzg0QmtFVldpaUVuZjdHRGpwWGg3cGVQ?= =?utf-8?B?K0pFK0UrUTJFOEU3eHNjbWFJSnhBaVRKUVBpOStMQnAvdk9FbU1hdWdXMW1v?= =?utf-8?B?OGFNY054OHozLzhFNzlkTXphRitjUzFIL2wyTWF6cExicXZESHVNN21TRHhV?= =?utf-8?B?Wmo1Qlp3UmQvTVBCN05qTzMwZVFYY0tRSnF4RnNnSFhtWVFtMHNzaU1oSm5X?= =?utf-8?B?QVZBUm1LRUg4eE12N0FrS0xaT1ZxLzYxNXNFbUtmUzBXRjllT0RTUFhMOThq?= =?utf-8?B?N3BkV1JBc2Q2MHhSZGkxbnkvR2JxbmZBbFJlVEgrNzl1dE5OTm8zOCthbHRE?= =?utf-8?B?YW9iM1lHcEtEQjhsZllTV3FOa29XRjNPYVJHbTlqbHprbm5uRUdoT1VvYjR4?= =?utf-8?B?NHFaOVo3cG1EMzg5SWtOaGUyZXFScGN4VEFqWkJHcnF5UDNuR2h6cS9QYjZm?= =?utf-8?B?OUdMQ2pBbysrQ1F0cVBudFJmbHlFT0JrUjZUdjBlZHArQXhDY2U4bVFXNkd6?= =?utf-8?B?b0dXclExMDhIRmZ3WTB6TWQvb0VzMXB4Q2U3YmpNQ2V4OGxkMlRHY2FRVGRZ?= =?utf-8?B?SDRETlAwaVJwbGJOODExcVBvemd4UU10ZUw5bUQvRDZHOFZWeVFZYnBZWU00?= =?utf-8?B?MU9zb0lWWWJabkhBKzNGRldHU2hoOVVIQUhYTk1OemJFOFdKbG1NRUZRbTNB?= =?utf-8?B?Y056b25IZjduWEhNQnNSOXBneC9tREZnYUZOa2phL2k4ZzNTcVkxUm9jSGEv?= =?utf-8?B?NzZWTUh6Q2o2YlNNblhIVGxoaTR2eFVuT2x2bE1Zc3Mwa3NRZVY0K0RPT2Z1?= =?utf-8?B?Q3ZwTm0zNUI0dUx3Mm4zb2JPMjFTRGFKWGVtSmdobmhwV2NkTERvUmt3cnhQ?= =?utf-8?B?YThxTFpWUUduNnVSY1J4UmwyZmt3YW8rdlk5S3BRWi9TVTE2Wkp1TEVIYkxN?= =?utf-8?B?bVRjMnc3TVFKWnhoaEYzdElzdlY0LzNNalMyMW0yZklaTWRzQ05nUGJ1Q3hl?= =?utf-8?B?ZjV1T01oL0Q4ejJtMVZ6S3BNemQyb2xHMmlaQzMyU3F1elJsUXk2WTRsc0c5?= =?utf-8?B?cVlkUUZHQndVa2NReFo3SlV5bThhMzRnelRySC96cWFWQ3pMZHBjUjVwNDg1?= =?utf-8?B?NDZwQ0pSWWpab2tBd2p6N3ZXeGVSMnY1c3I0bUt3Zk9TU3VrbmQwQUMrOWEw?= =?utf-8?B?bG1VZHl5NWtYb1FZcStRVXQyNTFTTFNrbVkvQ2RFTit6VlB4R1FnNW9JcG9s?= =?utf-8?B?UENPM0lDTWpmcVNTdWd6dWlvTHdBZVZlcUxzTFNNRE83RGVZenNFbldHVEF1?= =?utf-8?B?c2hEQy90RCsxNE8rM0ZuUm4xVzRpTGJNZ014RGlmaUtwYUZQTGhLdHJlQlVi?= =?utf-8?B?TUdXdWI4U0ViSm5PS1QxWTF1UzRWTUpGeHNEUVR5SXk3Y245Z0RjanZzMFBq?= =?utf-8?B?ZE84WUZHL1FrUUdYR3kwL2pMREJ1RVIyVXExZmQ0QlRiYWRJYzZ1OUpOZ3lZ?= =?utf-8?Q?1VbN+pYZiCtkkEmoU3aLqQQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f2edb8f8-19aa-4a87-1082-08d9fd0961de X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 11:31:39.2641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1iBh+pu0FOk8B6aMjpcAF4ARboV9bXJU7SJeqsTvQLpE2hM1ift4Xv9K7Lq72kDOg7GSjjGu++rlhdcfIQbLeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2337 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/3/2022 2:18 AM, Harold Huang wrote: > When kni driver calls eth_kni_start to start device, some fields such as > min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause > kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu > value. This is unexpected and sometimes we could not change the kni > device mtu with ip link command. > > Fixes: ff1e35fb5f83 ("kni: calculate MTU from mbuf size") > Cc: stable@dpdk.org > Signed-off-by: Harold Huang Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.