patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v1] net/iavf: fix cannot release mbufs issue
@ 2020-11-11  3:06 Ting Xu
  2020-11-11  5:16 ` Wu, Jingjing
  0 siblings, 1 reply; 3+ messages in thread
From: Ting Xu @ 2020-11-11  3:06 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, beilei.xing, jingjing.wu, Ting Xu, stable

In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs,
rxq->rxrearm_nb is given the value of rx descriptor number at last.
However, since the process to release and allocate mbufs lacks the
initialization of rxrearm_nb, if we try to release mbufs next time, it
will return without releasing directly. In this patch, rxrearm_nb is
initialized to be zero in rx queue reset.

Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
Cc: stable@dpdk.org

Signed-off-by: Ting Xu <ting.xu@intel.com>
---
 drivers/net/iavf/iavf_rxtx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index baac5d65c8..8f43208c80 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -194,6 +194,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq)
 	rxq->nb_rx_hold = 0;
 	rxq->pkt_first_seg = NULL;
 	rxq->pkt_last_seg = NULL;
+	rxq->rxrearm_nb = 0;
 }
 
 static inline void
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v1] net/iavf: fix cannot release mbufs issue
  2020-11-11  3:06 [dpdk-stable] [PATCH v1] net/iavf: fix cannot release mbufs issue Ting Xu
@ 2020-11-11  5:16 ` Wu, Jingjing
  2020-11-11  8:19   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2020-11-11  5:16 UTC (permalink / raw)
  To: Xu, Ting, dev; +Cc: Zhang, Qi Z, Xing, Beilei, stable



> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Wednesday, November 11, 2020 11:07 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>; Xu, Ting <ting.xu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v1] net/iavf: fix cannot release mbufs issue
> 
> In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs,
> rxq->rxrearm_nb is given the value of rx descriptor number at last.
> However, since the process to release and allocate mbufs lacks the
> initialization of rxrearm_nb, if we try to release mbufs next time, it will return
> without releasing directly. In this patch, rxrearm_nb is initialized to be zero in
> rx queue reset.
> 
> Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>

Acked-by: Jingjing Wu <jingjing.wu@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH v1] net/iavf: fix cannot release mbufs issue
  2020-11-11  5:16 ` Wu, Jingjing
@ 2020-11-11  8:19   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2020-11-11  8:19 UTC (permalink / raw)
  To: Wu, Jingjing, Xu, Ting, dev; +Cc: Xing, Beilei, stable



> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Wednesday, November 11, 2020 1:16 PM
> To: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v1] net/iavf: fix cannot release mbufs issue
> 
> 
> 
> > -----Original Message-----
> > From: Xu, Ting <ting.xu@intel.com>
> > Sent: Wednesday, November 11, 2020 11:07 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xu,
> > Ting <ting.xu@intel.com>; stable@dpdk.org
> > Subject: [PATCH v1] net/iavf: fix cannot release mbufs issue
> >
> > In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs,
> > rxq->rxrearm_nb is given the value of rx descriptor number at last.
> > However, since the process to release and allocate mbufs lacks the
> > initialization of rxrearm_nb, if we try to release mbufs next time, it
> > will return without releasing directly. In this patch, rxrearm_nb is
> > initialized to be zero in rx queue reset.
> >
> > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ting Xu <ting.xu@intel.com>
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-11  8:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11  3:06 [dpdk-stable] [PATCH v1] net/iavf: fix cannot release mbufs issue Ting Xu
2020-11-11  5:16 ` Wu, Jingjing
2020-11-11  8:19   ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git