From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pascal.mazon@6wind.com>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
[209.85.128.196]) by dpdk.org (Postfix) with ESMTP id BEA761B2A7
for <stable@dpdk.org>; Wed, 14 Feb 2018 14:13:30 +0100 (CET)
Received: by mail-wr0-f196.google.com with SMTP id b52so22078183wrd.10
for <stable@dpdk.org>; Wed, 14 Feb 2018 05:13:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=subject:to:cc:references:from:message-id:date:user-agent
:mime-version:in-reply-to:content-transfer-encoding:content-language;
bh=nVQuEEOZJ6ARbnQoLzGBKtMsR7nTNsGMP1A3C5GPQDU=;
b=WsF4O/MHuz6lrbh0VRxCTPtrCjzeXIHfbz+HwZdNbTgQwhN6l4VrcX/60ZuoC/9yQw
posLdFbJsEzBSAudkHRjY48R8KrTpDq2My8f9C6p+E78tfrYpUu6dFStAHIC0dKgX4Ns
QkFznRkmKzfSy6VVeckCl6Gy/A8aE/aiayjY08+wIR+zu3Y6vlFQ7SbjEBgvvjIyztPw
LICMUw9Ow/tJgT6g5JlWp7sfKh0pAfvgeF2jmjqH1QTj6nzWXrQGy3RoKtwaY+MJlEZD
wQA4P0v8Y1mUHX+CfDze4hF/QhE4euwb7SFnf8ZzWM4/6pNJXE4VwXKj6jMIhy43sqyi
qg7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:cc:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=nVQuEEOZJ6ARbnQoLzGBKtMsR7nTNsGMP1A3C5GPQDU=;
b=kCwiTPLKmbyXfFPHSINJJEjuHLhoFj68AkSTwGJnSo1KbuaJ59V3c2pxIUtK2bpDc4
jVW5eHAxyWtt+nbtLlfNbrM1LpopOnhSo9TQ3lmA6AJ7dRxTX93wlA8VrWjCVomSkymf
HWgHR4154XbI4m+0Fj8tD2A5lOso6LgCi1bHA/dB1qZRnImCVFYhKCxxgL44kFzaUU57
u8/hOs/Eu7Lmh4XuEc6P0O6tPYZaxXxPZSFoMpxC4aE7/ukj4vQx+y/YKN9vcIfaQNmu
bXH2CtfaPId1h8QLX503qvPBWXCKRQFWyW7i1uAhW2XTdHO+Se3jmj5MC5ed+xOVcXRd
pX9A==
X-Gm-Message-State: APf1xPCbUVPuumjACqlTL6xFo0ghfvCM91sEIWQ8J/WZi6AMVbS5+EAG
hX4Bw01wrBVex9r2T5QAMVG+X2pxhMY=
X-Google-Smtp-Source: AH8x224SwSM3NoFtz/vDszQreFXkV4XUgmUjR1XHPmkmuVBdD81unoHh5nfqv4KzGc+Xu6wLrdL7SQ==
X-Received: by 10.223.150.65 with SMTP id c1mr4600176wra.167.1518614010102;
Wed, 14 Feb 2018 05:13:30 -0800 (PST)
Received: from ?IPv6:2a01:e35:2e04:96e0:c150:28ea:209e:273a?
([2a01:e35:2e04:96e0:c150:28ea:209e:273a])
by smtp.gmail.com with ESMTPSA id t5sm14316794wra.47.2018.02.14.05.13.28
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 14 Feb 2018 05:13:29 -0800 (PST)
To: Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
stable@dpdk.org
References: <1518546947-20932-1-git-send-email-ophirmu@mellanox.com>
<1518607939-29121-1-git-send-email-ophirmu@mellanox.com>
From: Pascal Mazon <pascal.mazon@6wind.com>
Message-ID: <baf8bff6-6bd5-6f6d-3d7b-c759aa1859cb@6wind.com>
Date: Wed, 14 Feb 2018 14:13:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1518607939-29121-1-git-send-email-ophirmu@mellanox.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-stable] [PATCH v3] net/tap: fix promiscuous rules double
insertions
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2018 13:13:30 -0000
Good job. Looks ok to me.
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
On 14/02/2018 12:32, Ophir Munk wrote:
> Running testpmd command "port stop all" followed by command "port start
> all" may result in a TAP error:
> PMD: Kernel refused TC filter rule creation (17): File exists
>
> Root cause analysis: during the execution of "port start all" command
> testpmd calls rte_eth_promiscuous_enable() while during the execution
> of "port stop all" command testpmd does not call
> rte_eth_promiscuous_disable().
> As a result the TAP PMD is trying to add tc (traffic control command)
> promiscuous rules to the remote netvsc device consecutively. From the
> kernel point of view it is seen as an attempt to add the same rule more
> than once. In recent kernels (e.g. version 4.13) this attempt is rejected
> with a "File exists" error. In less recent kernels (e.g. version 4.4) the
> same rule may have been successfully accepted twice, which is undesirable.
>
> In the corrupted code every tc promiscuous rule included a different
> handle number parameter. If instead an identical handle number is
> used for all tc promiscuous rules - all kernels will reject the second
> identical rule with a "File exists" error, which is easy to identify and
> to silently ignore.
>
> Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> v1: initial version
> v2: add detailed commit message
> v3: textual fixes to commit message and code comments
>
> drivers/net/tap/tap_flow.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
> index 65657f0..551b2d8 100644
> --- a/drivers/net/tap/tap_flow.c
> +++ b/drivers/net/tap/tap_flow.c
> @@ -123,6 +123,7 @@ enum key_status_e {
> };
>
> #define ISOLATE_HANDLE 1
> +#define REMOTE_PROMISCUOUS_HANDLE 2
>
> struct rte_flow {
> LIST_ENTRY(rte_flow) next; /* Pointer to the next rte_flow structure */
> @@ -1692,9 +1693,15 @@ int tap_flow_implicit_create(struct pmd_internals *pmd,
> * The ISOLATE rule is always present and must have a static handle, as
> * the action is changed whether the feature is enabled (DROP) or
> * disabled (PASSTHRU).
> + * There is just one REMOTE_PROMISCUOUS rule in all cases. It should
> + * have a static handle such that adding it twice will fail with EEXIST
> + * with any kernel version. Remark: old kernels may falsely accept the
> + * same REMOTE_PROMISCUOUS rules if they had different handles.
> */
> if (idx == TAP_ISOLATE)
> remote_flow->msg.t.tcm_handle = ISOLATE_HANDLE;
> + else if (idx == TAP_REMOTE_PROMISC)
> + remote_flow->msg.t.tcm_handle = REMOTE_PROMISCUOUS_HANDLE;
> else
> tap_flow_set_handle(remote_flow);
> if (priv_flow_process(pmd, attr, items, actions, NULL,
> @@ -1709,12 +1716,16 @@ int tap_flow_implicit_create(struct pmd_internals *pmd,
> }
> err = tap_nl_recv_ack(pmd->nlsk_fd);
> if (err < 0) {
> + /* Silently ignore re-entering remote promiscuous rule */
> + if (errno == EEXIST && idx == TAP_REMOTE_PROMISC)
> + goto success;
> RTE_LOG(ERR, PMD,
> "Kernel refused TC filter rule creation (%d): %s\n",
> errno, strerror(errno));
> goto fail;
> }
> LIST_INSERT_HEAD(&pmd->implicit_flows, remote_flow, next);
> +success:
> return 0;
> fail:
> if (remote_flow)