From: Kevin Traynor <ktraynor@redhat.com>
To: Rongwei Liu <rongweil@nvidia.com>,
matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com,
suanmingm@nvidia.com, thomas@monjalon.net, stable@dpdk.org
Cc: Raslan Darawsheh <rasland@nvidia.com>, dev@dpdk.org
Subject: Re: [21.11 PATCH v1] net/mlx5: fix matcher layout size calculation
Date: Wed, 8 Nov 2023 19:24:50 +0000 [thread overview]
Message-ID: <bb13d743-0065-e6fa-34cb-b13e55894f31@redhat.com> (raw)
In-Reply-To: <20231103030721.930738-1-rongweil@nvidia.com>
On 03/11/2023 03:07, Rongwei Liu wrote:
> Initially, the rdma-core library only supported misc0 to misc3 fields in
> matching resources, misc4 and misc5 fields were added to handle new
> features. The matcher layout, passing from DPDK to rdma-core, shouldn't
> exceed the size of the engaged library version capabilities.
>
> For now, there is no way to know what is the maximum capability of
> rdma-core, and DPDK should limit the matcher layout to misc3 if
> possible (no matching on fields misc4 and misc5 are requested by the
> application).
>
> The check if misc4 and misc5 features were requested was based on checking
> the values against zeroes. The matching mask should be checked instead.
>
> Fixes: 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field")
> Cc:rongweil@nvidia.com
> Cc:stable@dpdk.org
> Signed-off-by: Rongwei Liu<rongweil@nvidia.com>
> Acked-by: Viacheslav Ovsiienko<viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Thanks Rongwei. I added upstream commit hash, removed cc's and applied
to branch 21.11 [0]. fyi - patches only for backport should go to
stable@dpdk.org only. Just makes things a bit easier for email filters,
patchwork, ci etc.
regards,
Kevin
[0]
https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=6de3135f1e2ec52d25505ae1ea3ef9a242ddcd5d
prev parent reply other threads:[~2023-11-08 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 3:07 Rongwei Liu
2023-11-08 19:24 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb13d743-0065-e6fa-34cb-b13e55894f31@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).