From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, nicknickolaev@gmail.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it
Date: Mon, 8 Oct 2018 14:56:16 +0200 [thread overview]
Message-ID: <bb818441-62f5-d40b-7f77-da143b921c1f@redhat.com> (raw)
In-Reply-To: <20181005095427eucas1p118e02435cf618d4f5306c734b423d0b1~arcEyNIT03167231672eucas1p1b@eucas1p1.samsung.com>
On 10/05/2018 11:56 AM, Ilya Maximets wrote:
> On 04.10.2018 11:13, Maxime Coquelin wrote:
>> As soons as some anciliarry datai (fds) are received, it is copied
>> without checking its length.
>>
>> This patch adds adds the number of fds received to the message,
>> which is set in read_vhost_message().
>>
>> This is preliminary work to support sending fds to Qemu.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/socket.c | 21 ++++++++++++++++-----
>> lib/librte_vhost/vhost_user.c | 2 +-
>> lib/librte_vhost/vhost_user.h | 4 +++-
>> 3 files changed, 20 insertions(+), 7 deletions(-)
>>
>> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>> index d63031747..c04d3d305 100644
>> --- a/lib/librte_vhost/socket.c
>> +++ b/lib/librte_vhost/socket.c
>> @@ -94,18 +94,23 @@ static struct vhost_user vhost_user = {
>> .mutex = PTHREAD_MUTEX_INITIALIZER,
>> };
>>
>> -/* return bytes# of read on success or negative val on failure. */
>> +/*
>> + * return bytes# of read on success or negative val on failure. Update fdnum
>> + * with number of fds read.
>> + */
>> int
>> -read_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num)
>> +read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> + int *fd_num)
>> {
>> struct iovec iov;
>> struct msghdr msgh;
>> - size_t fdsize = fd_num * sizeof(int);
>> - char control[CMSG_SPACE(fdsize)];
>> + char control[CMSG_SPACE(max_fds * sizeof(int))];
>> struct cmsghdr *cmsg;
>> int got_fds = 0;
>> int ret;
>>
>> + *fd_num = 0;
>> +
>> memset(&msgh, 0, sizeof(msgh));
>> iov.iov_base = buf;
>> iov.iov_len = buflen;
>> @@ -131,13 +136,19 @@ read_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num)
>> if ((cmsg->cmsg_level == SOL_SOCKET) &&
>> (cmsg->cmsg_type == SCM_RIGHTS)) {
>> got_fds = (cmsg->cmsg_len - CMSG_LEN(0)) / sizeof(int);
>> + if (got_fds > max_fds) {
>> + RTE_LOG(ERR, VHOST_CONFIG,
>> + "Received msg contains more fds than supported\n");
>> + return -1;
>
> Looks like we'll leak all that file descriptors here.
> I think, we need to get and close the valid ones anyway.
Indeed. I fixed it as below in upcoming iteration:
if (got_fds > max_fds) {
RTE_LOG(ERR, VHOST_CONFIG,
"Received msg contains more fds than supported\n");
tmp_fds = (int *)CMSG_DATA(cmsg);
while (got_fds--)
close(tmp_fds[got_fds]);
return -1;
}
>> + }
>> + *fd_num = got_fds;
>> memcpy(fds, CMSG_DATA(cmsg), got_fds * sizeof(int));
>> break;
>> }
>> }
>>
>> /* Clear out unused file descriptors */
>> - while (got_fds < fd_num)
>> + while (got_fds < max_fds)
>> fds[got_fds++] = -1;
>>
>> return ret;
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
>> index b6eae8dc5..ad69a267e 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -1518,7 +1518,7 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg)
>> int ret;
>>
>> ret = read_fd_message(sockfd, (char *)msg, VHOST_USER_HDR_SIZE,
>> - msg->fds, VHOST_MEMORY_MAX_NREGIONS);
>> + msg->fds, VHOST_MEMORY_MAX_NREGIONS, &msg->fd_num);
>> if (ret <= 0)
>> return ret;
>>
>> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
>> index 42166adf2..dd0262f8f 100644
>> --- a/lib/librte_vhost/vhost_user.h
>> +++ b/lib/librte_vhost/vhost_user.h
>> @@ -132,6 +132,7 @@ typedef struct VhostUserMsg {
>> VhostUserVringArea area;
>> } payload;
>> int fds[VHOST_MEMORY_MAX_NREGIONS];
>> + int fd_num;
>> } __attribute((packed)) VhostUserMsg;
>>
>> #define VHOST_USER_HDR_SIZE offsetof(VhostUserMsg, payload.u64)
>> @@ -146,7 +147,8 @@ int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
>> int vhost_user_host_notifier_ctrl(int vid, bool enable);
>>
>> /* socket.c */
>> -int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num);
>> +int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> + int *fd_num);
>> int send_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num);
>>
>> #endif
>>
next prev parent reply other threads:[~2018-10-08 12:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:13 [dpdk-stable] [PATCH v3 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-04 14:50 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-04 14:49 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 15:06 ` Maxime Coquelin
2018-10-04 15:11 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-05 9:56 ` Ilya Maximets
2018-10-08 12:56 ` Maxime Coquelin [this message]
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-05 11:55 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-05 11:58 ` Ilya Maximets
2018-10-05 13:36 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-05 12:02 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-05 12:34 ` Ilya Maximets
2018-10-08 13:03 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-05 12:37 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-05 14:24 ` Ilya Maximets
2018-10-08 16:25 ` Ilya Maximets
2018-10-08 16:54 ` Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb818441-62f5-d40b-7f77-da143b921c1f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=i.maximets@samsung.com \
--cc=jfreimann@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).