From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9E8EA0583 for ; Thu, 19 Mar 2020 15:32:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 994B5292D; Thu, 19 Mar 2020 15:32:24 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id DED5EF94 for ; Thu, 19 Mar 2020 15:32:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584628341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O00a2PWvIHCXd33iUI/w6Y5VAqedOZh/s0ABc3ePbJI=; b=UPX3Y9MzOSbNMopI9PGx2d9vjaivpqTbMx/eo1Qz5maAeDw0s9FE46V5ZZSJTwcd+Ky2P4 F3ulQWCzbozUMGLmX5E79rzIqqndoa3n5DKBpZnB1EWZgBkm9H1cxU24PLlon+uobBvpe/ EPIDu/hWFvhRQKm8CzngbAVXxNjtbDI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-EeUw9_YlOfuAqgFbONg4iw-1; Thu, 19 Mar 2020 10:32:19 -0400 X-MC-Unique: EeUw9_YlOfuAqgFbONg4iw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3114801E6D; Thu, 19 Mar 2020 14:32:17 +0000 (UTC) Received: from [10.33.36.217] (unknown [10.33.36.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 948AB104C43D; Thu, 19 Mar 2020 14:32:16 +0000 (UTC) To: Pablo de Lara , "stable@dpdk.org" References: <20200305153454.724874-1-pablo.de.lara.guarch@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Cc: Luca Boccassi , "dev@dpdk.org" Message-ID: Date: Thu, 19 Mar 2020 14:32:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200305153454.724874-1-pablo.de.lara.guarch@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [RFC PATCH 0/5] Support Intel IPSec MB v0.53 in DPDK 18.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" +stable@dpdk.org Hi Pablo, Sorry, but I'm not comfortable with these patches for 18.11. On 05/03/2020 15:34, Pablo de Lara wrote: > This patchset adds support to the following crypto PMDs to use > Intel IPSec MB v0.53, in DPDK v18.11: > - AESNI MB PMD: had support up to v0.52, extending to v0.53 > - AESNI GCM PMD: had support up to v0.52, extending to v0.53 For the AES ones, it looks like it is removing support for <0.50? I'm also not clear if it's changing the default or not. The patches are very intrusive too. My concern is that it might break backwards compatibility and introduce regressions. > - SNOW3G PMD: linking now to IPSec MB v0.53, instead of libsso > - ZUC PMD: linking now to IPSec MB v0.53, instead of libsso > - KASUMI PMD: linking now to IPSec MB v0.53, instead of libsso >=20 Aren't these the ones we discussed offline? If so, Luca and I both commented that this will break build for existing users and is not a backwards compatible change that could be put on stable branches. > Pablo de Lara (5): > crypto/zuc: use IPSec MB library v0.53 > crypto/snow3g: use IPSec MB library v0.53 > crypto/kasumi: use IPSec MB library v0.53 > crypto/aesni_mb: support IPSec MB library v0.53 > crypto/aesni_gcm: support IPSec MB library v0.53 >=20 > devtools/test-build.sh | 14 +- > doc/guides/cryptodevs/kasumi.rst | 62 +-- > doc/guides/cryptodevs/snow3g.rst | 58 ++- > doc/guides/cryptodevs/zuc.rst | 52 +- > drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 65 +-- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 130 +++-- > drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 4 +- > .../crypto/aesni_gcm/aesni_gcm_pmd_private.h | 4 + > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 476 ++++++++++++------ > .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 205 +++++--- > .../aesni_mb/rte_aesni_mb_pmd_private.h | 30 +- > drivers/crypto/kasumi/Makefile | 26 +- > drivers/crypto/kasumi/meson.build | 11 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 79 +-- > drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 8 +- > .../crypto/kasumi/rte_kasumi_pmd_private.h | 12 +- > drivers/crypto/snow3g/Makefile | 29 +- > drivers/crypto/snow3g/meson.build | 21 + > drivers/crypto/snow3g/rte_snow3g_pmd.c | 79 +-- > drivers/crypto/snow3g/rte_snow3g_pmd_ops.c | 8 +- > .../crypto/snow3g/rte_snow3g_pmd_private.h | 12 +- > drivers/crypto/zuc/Makefile | 28 +- > drivers/crypto/zuc/meson.build | 13 +- > drivers/crypto/zuc/rte_zuc_pmd.c | 58 ++- > drivers/crypto/zuc/rte_zuc_pmd_ops.c | 2 + > drivers/crypto/zuc/rte_zuc_pmd_private.h | 6 +- > mk/rte.app.mk | 6 +- > 27 files changed, 972 insertions(+), 526 deletions(-) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This is a *lot* of code churn > create mode 100644 drivers/crypto/snow3g/meson.build >=20 thanks, Kevin.