From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A22FA0A0C for ; Thu, 1 Jul 2021 11:24:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8827B40141; Thu, 1 Jul 2021 11:24:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 0556740040 for ; Thu, 1 Jul 2021 11:24:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10031"; a="195791941" X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="195791941" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 02:24:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,313,1616482800"; d="scan'208";a="420337065" Received: from irsmsx603.ger.corp.intel.com ([163.33.146.9]) by fmsmga007.fm.intel.com with ESMTP; 01 Jul 2021 02:24:00 -0700 Received: from irsmsx601.ger.corp.intel.com (163.33.146.7) by irsmsx603.ger.corp.intel.com (163.33.146.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 1 Jul 2021 10:24:00 +0100 Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by irsmsx601.ger.corp.intel.com ([163.33.146.7]) with mapi id 15.01.2242.008; Thu, 1 Jul 2021 10:24:00 +0100 From: "Richardson, Bruce" To: Dmitry Kozlyuk , "stable@dpdk.org" CC: Luca Boccassi , Rob Scheepens Thread-Topic: [PATCH] doc: fix build on Windows with meson 0.58 Thread-Index: AQHXbcsgbGQx6MQ0DEerHlgQKWjbxast2e8Q Date: Thu, 1 Jul 2021 09:23:59 +0000 Message-ID: References: <20210630161505.266381-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20210630161505.266381-1-dmitry.kozliuk@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] doc: fix build on Windows with meson 0.58 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Wednesday, June 30, 2021 5:15 PM > To: stable@dpdk.org > Cc: Dmitry Kozlyuk ; Richardson, Bruce > ; Luca Boccassi ; Rob > Scheepens > Subject: [PATCH] doc: fix build on Windows with meson 0.58 >=20 > The `doc` target used `echo` as its command. > On Windows, `echo` is always a shell built-in, there is no binary. > Starting from meson 0.58, `run_target()` always searches for command > executable and no longer accepts `echo` as such on Windows. > Replace plain `echo` with a Python one-liner. >=20 > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson") > Cc: Bruce Richardson > Cc: Luca Boccassi > Cc: stable@dpdk.org >=20 > Reported-by: Rob Scheepens > Signed-off-by: Dmitry Kozlyuk > --- > doc/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/meson.build b/doc/meson.build > index 959606b965..abd7d70421 100644 > --- a/doc/meson.build > +++ b/doc/meson.build > @@ -11,5 +11,6 @@ if doc_targets.length() =3D=3D 0 > else > message =3D 'Building docs:' > endif > -run_target('doc', command: ['echo', message, doc_target_names], > +echo =3D [py3, '-c', 'import sys; print(*sys.argv[1:])'] > +run_target('doc', command: [echo, message, doc_target_names], > depends: doc_targets) > -- > 2.29.3 LGTM Acked-by: Bruce Richardson