From: Luca Boccassi <bluca@debian.org>
To: patrick.fu@intel.com, stable@dpdk.org
Cc: ktraynor@redhat.com, maxime.coquelin@redhat.com,
zhihong.wang@intel.com, tiwei.bie@intel.com
Subject: Re: [dpdk-stable] [PATCH 17.11] net/virtio: init MTU in case no control channel
Date: Thu, 24 Oct 2019 09:48:49 +0100 [thread overview]
Message-ID: <be1e62940e21bd3f598e7d2be723ede4432c820b.camel@debian.org> (raw)
In-Reply-To: <1570775742-413094-1-git-send-email-patrick.fu@intel.com>
On Fri, 2019-10-11 at 14:35 +0800, patrick.fu@intel.com wrote:
> From: Patrick Fu <
> patrick.fu@intel.com
> >
>
> [backport from commit id: 240da8b2143b7be372cf6388f028b26b15f16776]
>
> The max_mtu is kept as zero in case no CRTL channel, which leads
> to failure when calling virtio_mtu_set().
>
> Signed-off-by: Patrick Fu <
> patrick.fu@intel.com
> >
> ---
> drivers/net/virtio/virtio_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> index e0328f6..c9076ea 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1508,6 +1508,8 @@ static int virtio_dev_xstats_get_names(struct
> rte_eth_dev *dev,
> } else {
> PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=1");
> hw->max_queue_pairs = 1;
> + hw->max_mtu = VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN -
> + VLAN_TAG_LEN - hw->vtnet_hdr_size;
> }
>
> ret = virtio_alloc_queues(eth_dev);
>
Acked-by: Luca Boccassi <bluca@debian.org>
Thanks, applied
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2019-10-24 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 6:35 patrick.fu
2019-10-24 8:48 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1e62940e21bd3f598e7d2be723ede4432c820b.camel@debian.org \
--to=bluca@debian.org \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).