From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 98DD2475D; Mon, 14 Nov 2016 18:59:43 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B8EFA8F22B; Mon, 14 Nov 2016 17:59:42 +0000 (UTC) Received: from ktraynor.remote.csb (vpn1-5-126.ams2.redhat.com [10.36.5.126]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAEHxeTq007355; Mon, 14 Nov 2016 12:59:41 -0500 To: Remy Horton , dev@dpdk.org References: <1479104089-27862-1-git-send-email-remy.horton@intel.com> <1479104089-27862-2-git-send-email-remy.horton@intel.com> Cc: Helin Zhang , Jingjing Wu , stable@dpdk.org, Yuanhan Liu From: Kevin Traynor X-Enigmail-Draft-Status: N1110 Organization: Red Hat Message-ID: Date: Mon, 14 Nov 2016 17:59:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1479104089-27862-2-git-send-email-remy.horton@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 14 Nov 2016 17:59:42 +0000 (UTC) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/2] net/i40e: fix incorrect xstats value mapping X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 17:59:43 -0000 On 11/14/2016 06:14 AM, Remy Horton wrote: > The offsets used in rte_i40evf_stats_strings for transmission > statistics were wrong, returning the total byte count rather than > the respective (unicast, multicast, broadcast, drop, & error) > packet counts. > > Fixes: da61cd084976 ("i40evf: add extended stats") This should go to the LTS branch also. Acked-by: Kevin Traynor > > Signed-off-by: Remy Horton > --- > drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index aa306d6..afae2ec 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -176,11 +176,11 @@ static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = { > {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, > rx_unknown_protocol)}, > {"tx_bytes", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > - {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_bytes)}, > + {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)}, > + {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)}, > + {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)}, > + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)}, > + {"tx_error_packets", offsetof(struct i40e_eth_stats, tx_errors)}, > }; > > #define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \ >