From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC2F3A04B1 for ; Mon, 23 Nov 2020 16:05:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CAB737AF; Mon, 23 Nov 2020 16:05:39 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 4D46837AF for ; Mon, 23 Nov 2020 16:05:38 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id s8so18878521wrw.10 for ; Mon, 23 Nov 2020 07:05:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=IKt3zQnT4sJBUlPUPDgN5xx027os9bFgi2EEmHB/6LM=; b=acATt1EADqKlmudhCF9Py1DKBtLhUKCfPlgPWyKb6jUNSNm/dYfAuIugpFwju7HT1y vvZqUA2aHbComw/x7xrWGui9eyxiFEtqNY8ktkIo7B+DT/WqlgWfr5tuFuTmZiYme9i9 DROP6mxjheq4DE0RwOGKWRl2RvN/v8uZkZGehswqmxSbJxs9P3czRwlDpCWmBeRjuiLA db/M2MN/UH1amdcZkzKg05Fdq4IoyWtg3zkcUO8DOpWc42g5jAjbeycdcW2DNIdivdOS 8NPlzGnoB5bfhxtCxdtlb7YQJO6iK6VekkbG6QU5/XlbmZY4UoOATGGcCu1hGo4FpxMv ufDg== X-Gm-Message-State: AOAM532bzyw981Lp2iQUa+776VbIvwTbG2bJNC1enOsNfbrE3/3gm4jv /RdPc3IRbBGAF75ijGIiV78= X-Google-Smtp-Source: ABdhPJx+JefCbDLxDWEIGEBCwQXJPLFP4X5bCAmaOGuulDZc/891B4SUHzaCXvLld6mwatF2n3REwg== X-Received: by 2002:adf:dc0a:: with SMTP id t10mr74742wri.314.1606143936975; Mon, 23 Nov 2020 07:05:36 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id v8sm18151971wmg.28.2020.11.23.07.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 07:05:35 -0800 (PST) Message-ID: From: Luca Boccassi To: Kevin Traynor , stable@dpdk.org, ferruh.yigit@intel.com Date: Mon, 23 Nov 2020 15:05:35 +0000 In-Reply-To: <20201123144948.40420-1-ktraynor@redhat.com> References: <20201123144948.40420-1-ktraynor@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 18.11] kni: fix ethtool build error on kernel 5.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 2020-11-23 at 14:49 +0000, Kevin Traynor wrote: > read_barrier_depends() is removed from kernel 5.9 as per Linux > commit 93fab07c2293 ("locking/barriers: Remove definitions for [smp_]read= _barrier_depends()") >=20 > It is used by ethtool and produces an error when building on kernel 5.9: >=20 > /kernel/linux/kni/ethtool/igb/igb_main.c: In function =E2=80=98igb_clean_= tx_irq=E2=80=99: > /dpdk-stable/kernel/linux/kni/ethtool/igb/igb_main.c:7067:3: > error: implicit declaration of function =E2=80=98read_barrier_depends=E2= =80=99 > [-Werror=3Dimplicit-function-declaration] > 7067 | read_barrier_depends(); > | ^~~~~~~~~~~~~~~~~~~~ >=20 > Fix by replacing with rmb() as is done for < 2.6 kernels. >=20 > Signed-off-by: Kevin Traynor > --- > kernel/linux/kni/ethtool/igb/kcompat.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/et= htool/igb/kcompat.h > index 459fda3dad..e89033818a 100644 > --- a/kernel/linux/kni/ethtool/igb/kcompat.h > +++ b/kernel/linux/kni/ethtool/igb/kcompat.h > @@ -3974,3 +3974,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __alw= ays_unused int type) > #endif > =20 > +#if LINUX_VERSION_CODE >=3D KERNEL_VERSION(5, 9, 0) > +#define read_barrier_depends() rmb() > +#endif > + > #endif /* _KCOMPAT_H_ */ Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi