patches for DPDK stable branches
 help / color / Atom feed
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
       [not found]   ` <20190912124049.GA71525@intel.com>
@ 2019-09-13  9:00     ` Eelco Chaudron
  2019-09-13 13:24       ` Kevin Traynor
  0 siblings, 1 reply; 2+ messages in thread
From: Eelco Chaudron @ 2019-09-13  9:00 UTC (permalink / raw)
  To: Ye Xiaolong, stable
  Cc: David Marchand, Beilei Xing, Qi Zhang, dev, Kevin Traynor

Forgot to include the stable alias to get this in 18.11, sorry Kevin

//Eelco

On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:

> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> 
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF 
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>                         }
>>>                         break;
>>>                 default:
>>> -                       PMD_DRV_LOG(ERR, "Request %u is not 
>>> supported yet",
>>> +                       PMD_DRV_LOG(DEBUG, "Request %u is not 
>>> supported yet",
>>>                                     aq_opc);
>>>                         break;
>>>                 }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
  2019-09-13  9:00     ` [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log Eelco Chaudron
@ 2019-09-13 13:24       ` Kevin Traynor
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Traynor @ 2019-09-13 13:24 UTC (permalink / raw)
  To: Eelco Chaudron, Ye Xiaolong, stable
  Cc: David Marchand, Beilei Xing, Qi Zhang, dev

On 13/09/2019 10:00, Eelco Chaudron wrote:
> Forgot to include the stable alias to get this in 18.11, sorry Kevin
> 

No problem, I'll take a note to backport it and add
Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")

> //Eelco
> 
> On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:
> 
>> On 09/12, David Marchand wrote:
>>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> 
>>> wrote:
>>>>
>>>> When receiving the unsupported AQ messages, it's taken as an
>>>> error. It's not appropriate and triggers too much unnecessary print.
>>>>
>>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>>> unnecessary error log") which made the same change for the PF 
>>>> instance.
>>>>
>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>>> ---
>>>>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
>>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> index c77b30c54..7b1d485c6 100644
>>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>>                         }
>>>>                         break;
>>>>                 default:
>>>> -                       PMD_DRV_LOG(ERR, "Request %u is not 
>>>> supported yet",
>>>> +                       PMD_DRV_LOG(DEBUG, "Request %u is not 
>>>> supported yet",
>>>>                                     aq_opc);
>>>>                         break;
>>>>                 }
>>>> --
>>>> 2.18.1
>>>>
>>>
>>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>>
>>>
>>> --
>>> David Marchand
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>>
>> Applied to dpdk-next-net-intel.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <8daee65a8edeae439ba9c2542877744b5be53684.1568284682.git.echaudro@redhat.com>
     [not found] ` <CAJFAV8whJfx4+ZSfh4SOBFdZRAMAcgmkabrtLK1XrA5o6eU7AQ@mail.gmail.com>
     [not found]   ` <20190912124049.GA71525@intel.com>
2019-09-13  9:00     ` [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log Eelco Chaudron
2019-09-13 13:24       ` Kevin Traynor

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox