patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Ali Alnubani <alialnu@nvidia.com>,
	Luca Boccassi <luca.boccassi@gmail.com>,
	David Marchand <david.marchand@redhat.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Abhishek Marathe <Abhishek.Marathe@microsoft.com>,
	"benjamin.walker@intel.com" <benjamin.walker@intel.com>,
	David Christensen <drc@linux.vnet.ibm.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Ian Stokes <ian.stokes@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Ju-Hyoung Lee <juhlee@microsoft.com>,
	Pei Zhang <pezhang@redhat.com>,
	"qian.q.xu@intel.com" <qian.q.xu@intel.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	Yanghang Liu <yanghliu@redhat.com>,
	"yuan.peng@intel.com" <yuan.peng@intel.com>,
	"zhaoyan.chen@intel.com" <zhaoyan.chen@intel.com>
Subject: Re: 20.11.8 patches review and test
Date: Wed, 19 Apr 2023 15:26:51 +0100	[thread overview]
Message-ID: <c108cc95-1e24-c128-1e83-f03c243ea3ae@redhat.com> (raw)
In-Reply-To: <DM4PR12MB51670AE72B5E8CC9604310C0DA629@DM4PR12MB5167.namprd12.prod.outlook.com>

On 19/04/2023 15:23, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Luca Boccassi <luca.boccassi@gmail.com>
>> Sent: Wednesday, April 19, 2023 5:15 PM
>> To: David Marchand <david.marchand@redhat.com>
>> Cc: Ali Alnubani <alialnu@nvidia.com>; stable@dpdk.org; dev@dpdk.org;
>> Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
>> Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>;
>> qian.q.xu@intel.com; Raslan Darawsheh <rasland@nvidia.com>; NBU-
>> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Yanghang
>> Liu <yanghliu@redhat.com>; yuan.peng@intel.com;
>> zhaoyan.chen@intel.com
>> Subject: Re: 20.11.8 patches review and test
>>
>> On Wed, 19 Apr 2023 at 14:25, David Marchand
>> <david.marchand@redhat.com> wrote:
>>>
>>> On Wed, Apr 19, 2023 at 3:14 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>>>>>
>>>>> I don't think this function prototype is really different in the 20.11
>>>>> stable branch (putting the __rte_internal tag aside).
>>>>> Can you trigger this issue on the main branch?
>>>>>
>>>>
>>>> The main branch doesn't reproduce on the same environment.
>>>
>>> Ok, same for me, I reproduced for 20.11 but not for main.
>>>
>>>
>>> I think I have the reason.
>>> We filter headers to be processed by doxygen via a name filter:
>>>
>>> FILE_PATTERNS           = rte_*.h \
>>>
>>> But this rte_cryptodev_pmd.h driver header has been renamed as
>>> cryptodev_pmd.h in 21.11.
>>> So the issue you reported only affects 20.11.
>>
>> I can reproduce in debian testing, after backporting the mentioned
>> commit from main it seems fine, can you confirm as well that it works
>> in fedora?
>>
>> https://github.com/bluca/dpdk-
>> stable/commit/77f65b61f955fd817b3791049dda3032c459ac59
> 
> Now I see a different error:
> 
> [2/4] Generating doc/api/doxygen with a custom command
> FAILED: doc/api/html
> /tmp/dpdk/doc/api/generate_doxygen.sh doc/api/doxy-api.conf doc/api/html /tmp/dpdk/doc/api/doxy-html-custom.sh
> /tmp/dpdk/lib/librte_vhost/rte_vhost_async.h:49: error: rte_vhost_async_channel_ops::transfer_data has @param documentation sections but no arguments (warning treated as error, aborting now)

See 
https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=adeaf361f0a5bb3992756fd4e727dd11ecca0943


  reply	other threads:[~2023-04-19 14:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 18:20 luca.boccassi
2023-04-06  7:19 ` Xu, HailinX
2023-04-11  5:17   ` Xu, HailinX
2023-04-14 10:06     ` Luca Boccassi
2023-04-17 10:34       ` Xu, HailinX
2023-04-12 15:15 ` Ali Alnubani
2023-04-14  8:28   ` YangHang Liu
2023-04-19  9:22   ` Ali Alnubani
2023-04-19 13:02     ` Luca Boccassi
2023-04-19 13:10       ` Ali Alnubani
2023-04-19 13:11     ` David Marchand
2023-04-19 13:14       ` Ali Alnubani
2023-04-19 13:24         ` David Marchand
2023-04-19 14:14           ` Luca Boccassi
2023-04-19 14:23             ` Ali Alnubani
2023-04-19 14:26               ` Kevin Traynor [this message]
2023-04-19 14:30                 ` Luca Boccassi
2023-04-19 14:35                   ` Ali Alnubani
2023-04-19 14:35                   ` David Marchand
2023-04-19 14:38                     ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c108cc95-1e24-c128-1e83-f03c243ea3ae@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=Abhishek.Marathe@microsoft.com \
    --cc=alialnu@nvidia.com \
    --cc=benjamin.walker@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=ian.stokes@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=juhlee@microsoft.com \
    --cc=luca.boccassi@gmail.com \
    --cc=pezhang@redhat.com \
    --cc=qian.q.xu@intel.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yanghliu@redhat.com \
    --cc=yuan.peng@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).