From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE7B2A0A0B for ; Tue, 26 Jan 2021 03:19:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A10191411AD; Tue, 26 Jan 2021 03:19:24 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DE35C14116E; Tue, 26 Jan 2021 03:19:20 +0100 (CET) IronPort-SDR: VC5XxyObWgcLy2oWo3I6cwtmLyK0cm1OlA+iMZnIpLpLjY43v9NpsBycO322zG5556HID2EEm8 a3LaPaopbhTg== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="167509900" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="167509900" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2021 18:19:19 -0800 IronPort-SDR: dxayggThjc8vwCGMlBho+4Ep1gA/zNjoKgTIpfb/iXAD1JCDYYl4Cw58neWfPqvKzVCWJ8lDs2 cf7QEDzNcS/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="353292292" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 25 Jan 2021 18:19:19 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 25 Jan 2021 18:19:18 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 26 Jan 2021 10:19:16 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 26 Jan 2021 10:19:15 +0800 From: "Yu, DapengX" To: "Guo, Jia" , "Wang, Haiyue" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ixgbe: disable NFS filtering Thread-Index: AQHW8seyxf5/nZ66zkOPCaC0j5rH26o4pWWAgACHu+A= Date: Tue, 26 Jan 2021 02:19:15 +0000 Message-ID: References: <20210120092700.105207-1-dapengx.yu@intel.com> <20210125031041.429268-1-dapengx.yu@intel.com> <84f0e4cfc8064a5988c0c814f3816c96@intel.com> In-Reply-To: <84f0e4cfc8064a5988c0c814f3816c96@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] net/ixgbe: disable NFS filtering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Jia, Thanks for the remind, I will submit patch v3 to include the reason to fix. -----Original Message----- From: Guo, Jia=20 Sent: Tuesday, January 26, 2021 10:11 AM To: Yu, DapengX ; Wang, Haiyue ; Yang, Qiming Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org Subject: RE: [PATCH v2] net/ixgbe: disable NFS filtering Hi, dapeng > -----Original Message----- > From: dapengx.yu@intel.com > Sent: Monday, January 25, 2021 11:11 AM > To: Guo, Jia ; Wang, Haiyue=20 > ; Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH v2] net/ixgbe: disable NFS filtering >=20 > From: Dapeng Yu >=20 > Disable NFS header filtering whether NFS packets coalescing are=20 > required or not. >=20 > This behavior is aligned with ixgbe kernel driver. >=20 I saw your comments about the reason in another email, so could you briefly= add the reason in the commit log? You just said what you do with this patch, but why or say without this patc= h what is the problem, it it better be mentioned if this is a fixing patch. Other is LGTM. > Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is=20 > disabled") > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c=20 > b/drivers/net/ixgbe/ixgbe_rxtx.c index cc8f70e6d..2efd054f7 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) > /* RFCTL configuration */ > rfctl =3D IXGBE_READ_REG(hw, IXGBE_RFCTL); > if ((rsc_capable) && (rx_conf->offloads & > DEV_RX_OFFLOAD_TCP_LRO)) > - /* > - * Since NFS packets coalescing is not supported - clear > - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is > - * enabled. > - */ > - rfctl &=3D ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS > | > - IXGBE_RFCTL_NFSR_DIS); > + rfctl &=3D ~IXGBE_RFCTL_RSC_DIS; > else > rfctl |=3D IXGBE_RFCTL_RSC_DIS; > + /* disable NFS filtering */ > + rfctl |=3D IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS; > IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl); >=20 > /* If LRO hasn't been requested - we are done here. */ > -- > 2.27.0