From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 037A0A0093 for ; Fri, 17 Jun 2022 14:42:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4C82410D2; Fri, 17 Jun 2022 14:42:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E34E440DDD for ; Fri, 17 Jun 2022 14:42:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655469768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tbc3NLGGFFM4ovGNATb38SnSc4BnN0O3KYn1LZdzDi8=; b=VPLwvqUoG5r7CIwlOGN/e1znBKgOOL9akY8Nh2vAMUg67KVxoymroGZ8SFU3vi+IhULVHY 7/h+59kGEdkTikwh+cjmR0/yohjEWx6tJCnXdkctbAPI0O11E1o24xEVYMpFlpT7bZdDRV l90nZWWRIgOtYKiHtqZvMVw6HK7YjhY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-wiJYeStwOPuxtxRwWeduAQ-1; Fri, 17 Jun 2022 08:42:47 -0400 X-MC-Unique: wiJYeStwOPuxtxRwWeduAQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADAD985A582; Fri, 17 Jun 2022 12:42:46 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12E3010725; Fri, 17 Jun 2022 12:42:44 +0000 (UTC) Message-ID: Date: Fri, 17 Jun 2022 14:42:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding" To: "Singh, Aman Deep" , dev@dpdk.org, jasowang@redhat.com, chenbo.xia@intel.com, david.marchand@redhat.com, olivier.matz@6wind.com, wenwux.ma@intel.com, yuying.zhang@intel.com Cc: stable@dpdk.org References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-2-maxime.coquelin@redhat.com> <81ca6e19-969a-18ad-8ef4-65c331cc8564@intel.com> From: Maxime Coquelin In-Reply-To: <81ca6e19-969a-18ad-8ef4-65c331cc8564@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/13/22 14:24, Singh, Aman Deep wrote: > Hi Maxime, > > On 6/8/2022 6:19 PM, Maxime Coquelin wrote: >> This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in >> csum forwarding"), >> as the checksum forwarding is expected to only perform >> checksum and not also overwrites the source and destination >> MAC addresses. >> >> Doing so, we can test checksum offloading with real traffic >> without breaking broadcast packets. >> >> Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") >> Cc: stable@dpdk.org >> >> Signed-off-by: Maxime Coquelin >> Acked-by: Chenbo Xia > > Acked-by: Aman Singh > >> --- >>   app/test-pmd/csumonly.c | 4 ---- >>   1 file changed, 4 deletions(-) >> >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c >> index 7df201e047..1a3fd9ce8a 100644 >> --- a/app/test-pmd/csumonly.c >> +++ b/app/test-pmd/csumonly.c >> @@ -916,10 +916,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) >>            * and inner headers */ >>           eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); >> -        rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], >> -                ð_hdr->dst_addr); >> -        rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, >> -                ð_hdr->src_addr); >>           parse_ethernet(eth_hdr, &info); >>           l3_hdr = (char *)eth_hdr + info.l2_len; > > LGTM, In principle csum mode should not modify the mac addresses. > This code has been there from start, so might break some TC's. > > Agree, some tests will need to be adapted. David showed me some tests in DTS were removing the MAC rewriting. Thanks, Maxime