From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Bing Zhao <bingz@nvidia.com>, dmitry.kozliuk@gmail.com, dev@dpdk.org
Cc: aman.deep.singh@intel.com, yuying.zhang@intel.com,
matan@nvidia.com, stable@dpdk.org,
Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: Re: [PATCH v2] app/testpmd: fix releasing action handle flush memory
Date: Thu, 18 Apr 2024 22:41:49 +0100 [thread overview]
Message-ID: <c4b0ebed-7dea-48d7-9c07-d608476d252d@amd.com> (raw)
In-Reply-To: <20240325105826.393231-1-bingz@nvidia.com>
On 3/25/2024 10:58 AM, Bing Zhao wrote:
> The memory of the indirect action handles should be freed after
> being destroyed in the flush. The behavior needs to be consistent
> with the single handle destroy port_action_handle_destroy().
>
> Or else, there would be some memory leak when closing / detaching a
> port without quitting the application. In the meanwhile, since the
> action handles are already destroyed, it makes no sense to hold the
> indirect action software resources anymore.
>
> Fixes: f7352c176bbf ("app/testpmd: fix use of indirect action after port close")
> Cc: dmitry.kozliuk@gmail.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Reviewed-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2024-04-18 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:32 [PATCH] " Bing Zhao
2024-03-19 14:20 ` Ferruh Yigit
2024-03-25 9:03 ` Bing Zhao
2024-03-25 10:58 ` [PATCH v2] " Bing Zhao
2024-04-18 21:41 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b0ebed-7dea-48d7-9c07-d608476d252d@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).