From: Kevin Traynor <ktraynor@redhat.com>
To: Ciara Power <ciara.power@intel.com>, stable@dpdk.org
Cc: John Griffin <john.griffin@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>
Subject: Re: [PATCH 21.11] crypto/qat: fix raw API null algorithm digest
Date: Thu, 23 Nov 2023 10:48:33 +0000 [thread overview]
Message-ID: <c4ba7024-abcc-d6a9-5539-1ca93ef3ba56@redhat.com> (raw)
In-Reply-To: <20231121162209.3945846-1-ciara.power@intel.com>
On 21/11/2023 16:22, Ciara Power wrote:
> [ upstream commit d7d52b37e89132f07121323c449ac838e6448ae0 ]
>
> QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is
> requested for NULL. This caused test failures when the test vector had
> digest len 0, as the buffer has unexpected changed bytes.
>
> By placing the digest into the cookie for NULL authentication,
> the buffer remains unchanged as expected, and the digest
> is placed to the side, as it won't be used anyway.
>
> This fix was previously added for the main QAT code path, but it also
> needs to be included for the raw API code path.
>
> Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
>
> Signed-off-by: Ciara Power<ciara.power@intel.com>
> ---
> drivers/crypto/qat/qat_sym_hw_dp.c | 42 +++++++++++++++++++++++++++---
> 1 file changed, 38 insertions(+), 4 deletions(-)
Applied to 21.11 branch. Thanks for backporting.
prev parent reply other threads:[~2023-11-23 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:22 Ciara Power
2023-11-23 10:48 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ba7024-abcc-d6a9-5539-1ca93ef3ba56@redhat.com \
--to=ktraynor@redhat.com \
--cc=ciara.power@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).