From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3413433A7 for ; Thu, 23 Nov 2023 11:48:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABF5142F27; Thu, 23 Nov 2023 11:48:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A2EEA42F25 for ; Thu, 23 Nov 2023 11:48:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700736517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XCEi7cYU5lD/Lm1bUXrP5XYgZ7sgjy8GpyZVpnucjPY=; b=Vs9CQiqVIEEXu0KRiEvzqC45jM/p4TH6pQAGoSKdJiFhz/WV1qSZotELgPGySAw0gQm6oC KGXPDutBdQ8wWXDvNEK1X45iBTeD1but8WrrpVuu2cxyKRT4CcPacdqcbhiPZHEqyg5G8+ BLPLi2D9gbJK/IOB0GBmwosBzeFmWiw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-UjtO22x1NNyFHCD5BmlqOA-1; Thu, 23 Nov 2023 05:48:35 -0500 X-MC-Unique: UjtO22x1NNyFHCD5BmlqOA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40b2bc8af6fso3784775e9.0 for ; Thu, 23 Nov 2023 02:48:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736514; x=1701341314; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XCEi7cYU5lD/Lm1bUXrP5XYgZ7sgjy8GpyZVpnucjPY=; b=D8xBWU1S7SmkVIDLv54t/lIXcvun2LeAUjy1aj1jKL+0JuKHVGVyX4NAWOPf7PGWRH pZ9hyH0rxhywlbiTyyTWW0wVb/WjLIxky2+rJ1DJisoL9awYCbZssqHI2XyvJXuWOzbt LE4KIyVlFj+bWn8zTRaXqI3cYDcV36iJ2EOIwnW5BFs2NPU5EKoRWulTCLVccII+GvN1 FGDaNREpsqQgeyPmflCG10j61ejqh5O6GiaeTopUXRcb4aW2AiLDwdZcoOUayyjWPXVS sNEaXUBBKF0CeG6dDOF1jdrs+FxPgmCdWTuu+6Cxe8j22Mz8W/DJhh6dn1FnJjdFwnQ6 uRbQ== X-Gm-Message-State: AOJu0YxUoWUP4PxEBgD2VFgCdBAUBGkEOmxskvE3OjWN0XDCJFvq3fCN DzKW4NjhbpVD9QWCWgifDk/utyz17dKWcB9BYbDdoN1LB241BjqDHYX1rgQURVsT915+cJoqUpy 5ScjTs4w= X-Received: by 2002:a05:600c:4708:b0:40b:36e5:e1e9 with SMTP id v8-20020a05600c470800b0040b36e5e1e9mr726531wmo.24.1700736514693; Thu, 23 Nov 2023 02:48:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQYMUY1DEs0lrBlAFzWXBCFOEYBhsMYaIUuESqqctsgLFW8f8oA+EfeaICRR4fcmaviaEK2g== X-Received: by 2002:a05:600c:4708:b0:40b:36e5:e1e9 with SMTP id v8-20020a05600c470800b0040b36e5e1e9mr726519wmo.24.1700736514430; Thu, 23 Nov 2023 02:48:34 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id jg28-20020a05600ca01c00b004063cd8105csm2275973wmb.22.2023.11.23.02.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:48:34 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 10:48:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Ciara Power , stable@dpdk.org Cc: John Griffin , Fiona Trahe , Deepak Kumar Jain References: <20231121162209.3945846-1-ciara.power@intel.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] crypto/qat: fix raw API null algorithm digest In-Reply-To: <20231121162209.3945846-1-ciara.power@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 21/11/2023 16:22, Ciara Power wrote: > [ upstream commit d7d52b37e89132f07121323c449ac838e6448ae0 ] > > QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is > requested for NULL. This caused test failures when the test vector had > digest len 0, as the buffer has unexpected changed bytes. > > By placing the digest into the cookie for NULL authentication, > the buffer remains unchanged as expected, and the digest > is placed to the side, as it won't be used anyway. > > This fix was previously added for the main QAT code path, but it also > needs to be included for the raw API code path. > > Fixes: db0e952a5c01 ("crypto/qat: add NULL capability") > > Signed-off-by: Ciara Power > --- > drivers/crypto/qat/qat_sym_hw_dp.c | 42 +++++++++++++++++++++++++++--- > 1 file changed, 38 insertions(+), 4 deletions(-) Applied to 21.11 branch. Thanks for backporting.