From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: David Hunt <david.hunt@intel.com>, dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 3/6] power: rename public structs Date: Wed, 20 Jan 2021 14:27:51 +0000 Message-ID: <c513a31e-9d5f-2568-b479-e66b7f9a448c@intel.com> (raw) In-Reply-To: <20210120135556.33763-4-david.hunt@intel.com> On 20-Jan-21 1:55 PM, David Hunt wrote: > From: Bruce Richardson <bruce.richardson@intel.com> > > rename the public structs to have an rte_power_ prefix. > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > Signed-off-by: David Hunt <david.hunt@intel.com> > --- <snip> > RTE_LOG(ERR, GUEST_CLI, "Error receiving message.\n"); > @@ -293,14 +294,15 @@ cmd_query_caps_list_parsed(void *parsed_result, > { > struct cmd_query_caps_result *res = parsed_result; > unsigned int lcore_id; > - struct channel_packet_caps_list pkt_caps_list; > - struct channel_packet pkt; > + struct rte_power_channel_packet_caps_list pkt_caps_list; > + struct rte_power_channel_packet pkt; > bool query_list = false; > int ret; > char *ep; > > - memset(&pkt, 0, sizeof(struct channel_packet)); > - memset(&pkt_caps_list, 0, sizeof(struct channel_packet_caps_list)); > + memset(&pkt, 0, sizeof(struct rte_power_channel_packet)); > + memset(&pkt_caps_list, 0, > + sizeof(struct rte_power_channel_packet_caps_list)); Here and in other places where you do sizeof(), you might want to avoid future changes by replacing it with sizeof(*pkt) instead? -- Thanks, Anatoly
next prev parent reply other threads:[~2021-01-20 14:27 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 11:36 [dpdk-stable] [PATCH v1] power: fix make build for power apps David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH 0/6] " David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 1/6] power: create guest channel public header file David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 0/6] power: fix make build for power apps David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 1/6] power: create guest channel public header file David Hunt 2021-01-20 15:09 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:12 ` David Hunt 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps David Hunt 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 0/6] power: fix make build for power apps David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 2/6] power: make channel msg functions public David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 3/6] power: rename public structs David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 4/6] power: rename defines David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 5/6] power: add new header file to export list David Hunt 2021-01-29 10:21 ` [dpdk-stable] [PATCH v5 6/6] power: clean up includes David Hunt 2021-01-29 10:30 ` [dpdk-stable] [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps Thomas Monjalon 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 2/6] power: make channel msg functions public David Hunt 2021-01-22 12:12 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-02-22 9:53 ` [dpdk-stable] " Ferruh Yigit 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 3/6] power: rename public structs David Hunt 2021-01-22 12:15 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-28 22:57 ` [dpdk-stable] " Thomas Monjalon 2021-02-22 9:56 ` Ferruh Yigit 2021-01-21 17:21 ` [dpdk-stable] [PATCH v4 4/6] power: rename defines David Hunt 2021-01-22 13:50 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-stable] [PATCH v4 5/6] power: add new header file to export list David Hunt 2021-01-22 13:51 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-stable] [PATCH v4 6/6] power: clean up includes David Hunt 2021-01-22 13:53 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-29 10:27 ` [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps Thomas Monjalon 2021-02-24 13:16 ` [dpdk-stable] [PATCH] power: remove duplicated symbols from map file Ferruh Yigit 2021-02-24 15:24 ` Aaron Conole 2021-02-24 14:54 ` Ferruh Yigit 2021-02-25 9:11 ` [dpdk-stable] [dpdk-dev] " David Marchand 2021-02-25 10:41 ` Ferruh Yigit 2021-02-25 10:44 ` David Marchand 2021-02-25 10:54 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit 2021-02-25 14:38 ` David Marchand 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 2/6] power: make channel msg functions public David Hunt 2021-01-20 14:26 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:08 ` David Hunt 2021-01-20 15:23 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 3/6] power: rename public structs David Hunt 2021-01-20 14:27 ` Burakov, Anatoly [this message] 2021-01-20 15:03 ` [dpdk-stable] [dpdk-dev] " David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 4/6] power: rename defines David Hunt 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 5/6] power: add new header file to export list David Hunt 2021-01-20 14:28 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly 2021-01-20 15:01 ` David Hunt 2021-01-20 15:17 ` Burakov, Anatoly 2021-01-20 15:08 ` Bruce Richardson 2021-01-20 15:18 ` Burakov, Anatoly 2021-01-20 15:29 ` David Hunt 2021-01-20 15:43 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-stable] [PATCH v3 6/6] power: clean up includes David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 2/6] power: make channel msg functions public David Hunt 2021-01-19 14:31 ` Thomas Monjalon 2021-01-19 14:51 ` David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 3/6] power: rename public structs David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 4/6] power: rename defines David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 5/6] power: add new header file to export list David Hunt 2021-01-08 14:30 ` [dpdk-stable] [PATCH v2 6/6] power: clean up includes David Hunt 2021-01-13 11:08 ` [dpdk-stable] [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Burakov, Anatoly 2021-01-13 11:14 ` David Hunt 2021-01-13 11:18 ` Burakov, Anatoly 2021-01-13 13:25 ` David Hunt 2021-01-13 17:30 ` Burakov, Anatoly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c513a31e-9d5f-2568-b479-e66b7f9a448c@intel.com \ --to=anatoly.burakov@intel.com \ --cc=bruce.richardson@intel.com \ --cc=david.hunt@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git