From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C9DAA09D9 for ; Wed, 11 Nov 2020 14:26:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E046A37B4; Wed, 11 Nov 2020 14:26:19 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D272A2AB; Wed, 11 Nov 2020 14:26:15 +0100 (CET) IronPort-SDR: cRqnJOxKxJ1WaHmma26mAbBYbOrJ2ETcyJ9skYdLF+F0n1Mou3+XZj4AeDq3Oeif3+IwLtsKCn PD/yukBdraew== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="149992687" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="149992687" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 05:26:07 -0800 IronPort-SDR: AxMQ891dOdzpUo4Uoc8n9WoZPhvtlRgqoHE4tBfyXfQqCUaIXa4eksuHJLhNxmGsKUvaIzIV9t MmyS25sJHC/w== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="473849174" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.123]) ([10.213.241.123]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 05:26:03 -0800 To: "Loftus, Ciara" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20201109133005.67035-1-ferruh.yigit@intel.com> <14e704b269f94f3ea8b52cdfbf3f3d4c@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 11 Nov 2020 13:25:59 +0000 MIME-Version: 1.0 In-Reply-To: <14e704b269f94f3ea8b52cdfbf3f3d4c@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH] net/af_xdp: do not use fixed size storage for pointer X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 11/9/2020 6:00 PM, Loftus, Ciara wrote: >> >> 'uint64_t' is used to hold the pointer, for 32-bits build this >> assumption is wrong and giving following build error: >> >> rte_eth_af_xdp.c: In function ‘xdp_umem_configure’: >> rte_eth_af_xdp.c:970:15: >> error: cast to pointer from integer of different size >> [-Werror=int-to-pointer-cast] >> 970 | base_addr = (void *)get_base_addr(mb_pool, &align); >> | ^ >> >> Replacing the 'uint64_t' return type of the 'get_base_addr()' to the >> 'uintptr_t'. >> Although not sure if the overall logic supports the 32-bits, using >> 'uintptr_t' should be safe both for 64/32 bits. >> >> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit >> >> --- >> >> Hi Ciara, >> >> I am not sure if 32-bit is supported for the af_xdp, but even not does >> this change make sense for the 64-bits? > > Hi Ferruh, > > LGTM. I've tested it for 64bit and all looks good to me. > > Tested-by: Ciara Loftus > > I've been looking into 32-bit compatibility and will submit a patch for at least the docs when I've verified what works. > Applied to dpdk-next-net/main, thanks.