From: Kevin Traynor <ktraynor@redhat.com>
To: Suanming Mou <suanmingm@nvidia.com>,
viacheslavo@nvidia.com, matan@nvidia.com
Cc: stable@dpdk.org, Suanming Mou <suanmingm@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH 18.11] net/mlx5: fix secondary process resources release
Date: Tue, 8 Dec 2020 10:50:20 +0000 [thread overview]
Message-ID: <c6558ce9-aaa8-6283-a43f-bc90e7413b88@redhat.com> (raw)
In-Reply-To: <1607315398-354529-1-git-send-email-suanmingm@nvidia.com>
On 07/12/2020 04:29, Suanming Mou wrote:
> From: Suanming Mou <suanmingm@mellanox.com>
>
> [ upstream commit 2786b7bf9084b32dde9a346d92ab1c27f0ffc476 ]
>
> When secondary process starts, it will allocate its own process private
> data, and also does remap to UAR register of the Tx queue. Once the
> secondary process exits, these resources should be released accordingly.
> And the shared resources owned by primary should not be touched.
>
> Currently, once one port in the secondary process spawn failed, all the
> other spawned ports will also be released during process exits. However,
> the mlx5_dev_close() function does not add the cases for secondary
> process, it means call the mlx5_dev_close() function directly in
> secondary process releases the resources it should not touch.
>
> Add the case for secondary process release to its own resources in
> mlx5_dev_close() function to help it quits gracefully.
>
> Fixes: 3a8207423a0f ("net/mlx5: close all ports on remove")
>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 34 ++++++++++++++++++++++++++++------
> drivers/net/mlx5/mlx5_rxtx.h | 1 +
> drivers/net/mlx5/mlx5_txq.c | 24 ++++++++++++++++++++++++
> 3 files changed, 53 insertions(+), 6 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2020-12-08 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 4:29 Suanming Mou
2020-12-08 10:50 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6558ce9-aaa8-6283-a43f-bc90e7413b88@redhat.com \
--to=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@mellanox.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).