From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4670FA034E for ; Thu, 17 Feb 2022 18:55:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37A024114B; Thu, 17 Feb 2022 18:55:18 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id ABE9B40042; Thu, 17 Feb 2022 18:55:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645120515; x=1676656515; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=pYe+gQTw1dPo+5T7QbRDShiHOQHIWOm8BZvrA568m4w=; b=CsPKRGbAnZGgNwU/vmp1oiKvocVepL2d/A4rQcdTnMMWhLiX5lA3TLoL GMg+gLRctDIHqYlKJh2WIguTiargXqrWRztvlb5SV3oMb2bj5pAhLVwYz Gjtx7FgPlVp/VG1Ww9TG69ez9LEAcDt4PimbWiXSM8H1mYtVFVQZ5B6Zi zLGLE95KDJSHQ6H5SR+4ryri1Epc+HA6FIyz5CFH5OsXNIkYllxnB5dlW gpcUfyku0nXDQYy6nE0qR/MwPcyoPrUI4g6dQZZcG146wkGSb4xXHF+vU YGlbZu4++6IP7MOcLU9XCiAW1EfgupDZPppP5qfJ7wR6mS34UtC0qog/y w==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="314199469" X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="314199469" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 09:55:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="589609253" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 17 Feb 2022 09:55:13 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 09:55:13 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 09:55:13 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 09:55:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FEuKr7kEFelJ9SBxqFlAAJSn8Woq6zAnxHPjbrz+qN+851JDRVGZCG7ehzC43K4Hj5R530IzThCrfrx5kWC5W09rN7zkzY9j3MkWJaeoZoRs//EML+uawHqlLFQrmuCVH0HkFYXHlYlnyzOUNV2tVI5Epy+CLZhzhGARo9qHHD5SEbVY4I7vlwuVbDnZfFiKHIdAGtEXudCzQ16Fn7+zOqV987KeCUzfSjvvWCeq+H2Wf8cIKR6M4zNyvXFAd3Ny6msLTCyVJFphxugUIZwL5jA0yNURpNG1I12d/rORPP/YZgU3YgsyCMDkt98VRf85NRneRZuGw+mycCafblCAgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JWHItL2cZt3QOhToDGIVv7a9MyO+UhseEahXkRjEhsY=; b=Lk+SDa7lriwN7/hFOqpNu9a90SeOEo2jdLcJ2H/ogEkbAbHOgMNapHLLFoak0Sl8V/HmE/mzyVx2t22hkYM4KbrD+8jaxirEMI1rVygW3OM7u9WUSVt5gYLEkjoNJMrlypq+w8n5s2lPhRz0yb50Rc1uJ1+74yV5yM6rcQ+4yYdHInuf++1nm4UJmD/9GcVb2WdsyCwIXi+qcwn/9qzBtA8nwHj7qqOWIXkgzf3ooYXeIXgsg25i1qfmaii1KZlHkY4f2JYzhdq+Vfh9nOXZalU/0mdYQTnNV9cZy6Ce4Ujz0UdQG5O1cCiZ14WdbPEijljugkPBJHdtQfaNxFfM8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5609.namprd11.prod.outlook.com (2603:10b6:510:e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 17 Feb 2022 17:55:06 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.017; Thu, 17 Feb 2022 17:55:06 +0000 Message-ID: Date: Thu, 17 Feb 2022 17:55:00 +0000 Subject: Re: [PATCH] net/af_xdp: add missing trailing newline in logs Content-Language: en-US To: "Loftus, Ciara" , David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , Xiaolong Ye , Stephen Hemminger , Luca Boccassi , "Laatz, Kevin" References: <20220217130614.23255-1-david.marchand@redhat.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0476.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b635660-512d-403c-2654-08d9f23ea165 X-MS-TrafficTypeDiagnostic: PH0PR11MB5609:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VSo/njydk7ScRFd1vP7VWpHAhiythGXM7wnPmU/I7IFiIa3nrTcOSKXT/Gid89p+Hlv4I6KMzPDPYVTuTh8Wj7nyGSnGPo0Pw0oMtzgaPRJqDBNCOUXEI5NK//HriZq7pAmDnKRdC2MpExJBmatHHT5+oz1TooJdRyZUU97I28pjf+JdQ+6wKGT7HwHFiH+Wlw7jQ1Wde6Hr+rrdxXu1slFzzYtPe9mlnO0hX5G7PBujlpFlD1K2qSXjO2Rp50AcpbiuiCBV9Zx3aAlOoPQZRwojatw7W4/urJCrTkKr+9zlrX8lYYSH1hdLoafKnRxpI471PJTbhWNTbLNqe0NI0fDufGSBEcVBkUX+UIYWAG6CySAqyHShYpnRCQmdrLWCq7hnuT0WpEaYMRLsvYOPOibNHljmeT7rJ90RlkNi62PWxwEleP80pNRKrLgIUecMlbV+H5kWLm6km0em/mdoc2LCntTsBP0sWwqFkJniiU7mauRqRiz5jJavyhRPONHYoBVSovu5w5PR5y/bD/vxB3IRwJSgWqXsAImeGndJhmNioNcLWAmGOXXUgLnfxd5wU2lGyAcWKMOVKgB7znevu0jq6ySxY4iY/1iswvY0GGIxPONvKaobzi/UsUQ6Rybrxu5bMx164C65HIl4a5Zy9LDwNtJ9S8MrvvFT3Th5RZHiYO6ZWH1E6T95SKL9pusERiM33X672wQ649k0QFcc1g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(4326008)(66476007)(66946007)(66556008)(36756003)(8676002)(2616005)(31686004)(44832011)(4744005)(86362001)(107886003)(316002)(6512007)(110136005)(54906003)(8936002)(31696002)(82960400001)(186003)(26005)(6506007)(53546011)(6486002)(6666004)(83380400001)(508600001)(2906002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHROSkNkbzNtQ05EZThtOW93dlJZQ1JITGhJaFJCbW5oRHY2eXBWcnJIU2k0?= =?utf-8?B?LytnMnJHK0kzKy9vNG1qTGdGQytqNHZKZFhuMTN6cVhKZkRQeHUzSkh1NzBL?= =?utf-8?B?VjZScWd2dytPMHZLUjBneksyVWpyc3V1bldLZ3VNdE9HUGhKVmFTUXY1QW9D?= =?utf-8?B?YUpJYnlnWTdDL0tPVStQMThtZHRXeklVeE5EdDlnZEgvL0VhYzRvQVVxL3Ar?= =?utf-8?B?S1B0cjJ0ays2Uk1LZEt5YndHbkJscVFQNmFTV0dBdDVzblIrSlVrbHJsNFpK?= =?utf-8?B?K3BKbC9iTmd1NE04Y2F1S3FlSEZLem5vcGxsaWF5YjVlWFdzMmFCSk5NN1FE?= =?utf-8?B?U2w0c0wyb0tBK1RibDd3bHFPWVdFTkxEVGpLbjJPSlZhZ2JCOXJFSXVVWUNr?= =?utf-8?B?TmU1a25id05ITW1yZWtrenpnTHlYd3lHMzVFTVo4QVBWT2k1eE5Ub044eUEr?= =?utf-8?B?eHlJajBFOXdUME9TK1FnazBheGFlVncrVjFtd0xOV1RsRUNsMC9WaW1KYjNS?= =?utf-8?B?T1lyME9YTUtGRmNDcGhtZFVZZndsdzQxMUFUUkZOSTBqYktQUzkvTDkxNDJL?= =?utf-8?B?aXVxcS9IaFh5clNEMmlLczhXMHhmaDRrRjd2OVBKU2JQTXVPb3hFVFZmczYr?= =?utf-8?B?K3N0K29tRHNRek4rRXBQZUNJWE5ENlNDQ3dwYkF2ZWFSVDVTVzhaMnNIN2VN?= =?utf-8?B?TGtLaTlyS3hMZ0Q3VTNlZnZiaDJycWdNN3RhVnRjVHNSRXBzWE1ZMXI4aG53?= =?utf-8?B?dHVNWWdOaVJJZGFaTUVlRW5QZFNic05NRitNSFdmaG84dm1RSnk2NVNUeTY5?= =?utf-8?B?UXIwaTN5dERaM0l0dWZ1cDk0ZTZJRlFaQ0phUStjT0kxU1RNK3J0SUEwakJa?= =?utf-8?B?NVdTWFNXOVMzV3UvaU9nbG1VZmEzUGlnY0VKRVFGOFRHaFdiVEZ4aWp3QUVl?= =?utf-8?B?cGFYY2FJNHlFMmFiZUdDY09qVHMwbk5tOWNkdjRmQVhEdGU4c3ROUCttT21C?= =?utf-8?B?RXUvUmxKKy9VTks2UXJBV3lRSGY0NEVSVjhFQnIxZHVrdlZwdm1LbS93a044?= =?utf-8?B?Tmt1TEV6Sy9CL2RoMmJCSGJuc1U5SWVZK05hRVVLSER2Zis2SkF6U1dNTnFt?= =?utf-8?B?N1N0OEdub1AyeldhcmUxOVlwbjQyVVNZZWZOQnpXK2xTb1JuL1JpMzF3SVAx?= =?utf-8?B?TWpycVFZMlcwUE1xT1VpVXErdGRnRkFkOHVuZHVVQTF4R0taaFluZ0pUeFNu?= =?utf-8?B?ZUp3THptdlMxZWdmODNIOTBGVDJCaWl4Z1c1RHZ0ZnArMHI4MEduM3JnK3dh?= =?utf-8?B?emIzZlQzYW1iZUtULzZRVG54Z0RtSHdtdlJjeE9xTXpKUjcyMkRRM2VZbmtN?= =?utf-8?B?cjlVa0ZGbk5sMWxTQmRwb21jblgvOG44cUl2bGpMYUNqRkd4d2NjY0x3aTNk?= =?utf-8?B?VG5kNklvNHpQcUN5VEwzOWhjM0R5am8rSFpndmhXakVkTXNoNFZ2QnovNHBM?= =?utf-8?B?VVNoNEdSUWlVSExsa0hzME9YZk9uSUNBRU9VU0hmZVUxUUp0OHNLaklXa1NV?= =?utf-8?B?TUxhNUdmUzNtQS9icU51TmFCTVI2VUNQT3pBMXNiV2lHRmZpVzM3OGlaQUJi?= =?utf-8?B?OStBZDBraFZhK20xUnd2ZUtKY3ArS1diNU05WlE5ejNmME1iMy92dkNQMExr?= =?utf-8?B?Y0FzMTRXMUNiU0Rvd0JUVjVNdkUzY2wrOGM4bjNZL3RDZ0p4c1FHU2llYXVn?= =?utf-8?B?WTQyK2NaeG12SStWaGlUYjNaZ3NJZmdYYzQvTEkxeVJlOENXZUVFQ2kxTUtj?= =?utf-8?B?dExRSktnaWhMOUtXbVUweVdJN242Mk1BYWVnTnVvbGpxYjlJRDBVMzg5YXJG?= =?utf-8?B?YmhyQ0ZRamZ0UUZpekpyRklSbU50YmlnbzVCNmJoUVhMbG5wY1RDUmM1Zk5B?= =?utf-8?B?WTBZUkZ3dURtSWc0QnBMcWRhaHUvN1VuRnpyc1FmMURFWU1IbEdRall1bmw2?= =?utf-8?B?dERzc05rNmxWZjNZRUd1Y2lLMUNIN3NHQWVobUhzS0hNMGlMZnVPK0JIamR2?= =?utf-8?B?YUJxYk80ZXdralFWSjB0QWlRRTNxUjZWOG9Wa3lnV3ZhQzE5UHJPVzU2akdo?= =?utf-8?B?c2hEWGc4YkJVa096QlJYbitkczBDSTNUbmhQbHpFeC9IWElWSEd5YWxsNnph?= =?utf-8?Q?BphfalR+11Lv/YLZ9vIEB+I=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0b635660-512d-403c-2654-08d9f23ea165 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 17:55:06.2258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 43bb8R5E7ixR7HvbFmbJ1TzBGbTSzwj7c2Ki97OSk2Bi6r7wZq94oRURTEKUQiA6GqsQirA/4JuQ1q8+aUv7rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5609 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/17/2022 1:34 PM, Loftus, Ciara wrote: >> Subject: [PATCH] net/af_xdp: add missing trailing newline in logs >> >> Caught while trying --in-memory mode, some log messages in this driver >> are not terminated with a newline: >> rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC >> callback: Operation not supportedvdev_probe(): failed to initialize >> net_af_xdp device >> >> Other locations in this driver had the same issue, fix all at once. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") >> Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support") >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand > > Thanks David, LGTM. > > Acked-by: Ciara Loftus > Applied to dpdk-next-net/main, thanks.