From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C687A04C0 for ; Thu, 17 Sep 2020 17:40:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32B581D6AD; Thu, 17 Sep 2020 17:40:14 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140080.outbound.protection.outlook.com [40.107.14.80]) by dpdk.org (Postfix) with ESMTP id 47F481D449; Thu, 17 Sep 2020 17:40:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EvTaFpiECXyHJaM0GNGMz7xY/gKEgtiOOrTdHOFp0fn9mbnPRdaQPVU0L4Yzl5L66C8B3K9sUaxu1OaPGvMYOa3ubD9Amqq9ABRowuS/7VihvjkTjLc4BkrxQpdKZzQvw4sgFCMy7llhN/gPyA567tJ1bNt3ruiWwhblH3EgO8neod+fObQwyckrXW4/KNNEnzqFMxxBJRSUQNUJ1yXaHcMcbdH7hzx/ioDQM2ArrIcFP8EtGGpArn0WXV4Z0DiYpKfxW5bSlKGkA7jM5mdK6KDrEUgNZQrhHCn/ZPam78jB9upqUc9SyEwEzVXpBlbZ6gOh0y+MdB3/G1IJXTXW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxVPfjPcHzyd5b/W9h0oRPbs4Uh0pKkjemmc+RuIwh4=; b=Y5xGZNJGZvn4Y1e8PQJgIjaQbGcfAe/ZX9ETyQrJEOcPN7uDDfnSOQMWbPPMErqzeeQU9j0EfDUzNxsew231LBjAF4j9eXignDMtquw2DY8+Q7KvOBCtRWRx30U59w+RLz/rgxm/yKZUvP+uO3X/ndT4gasr7iuqTbjTHzIa0jBpm5yHsjgnXWZv2k63MX2DP8VNRa0nSDtLX+x/T09sREnogmZsg8WrfsRm8Wd1XsQQeNBA3XGZN2fGneaOaRQburxMPtjSZkgB+AZVHuJs1jGWTbY2+Mbc6w/OGhEUra3aoay8QGQDW8ygvFCchCIBYOkUDJaoOCO3mik392Qf6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxVPfjPcHzyd5b/W9h0oRPbs4Uh0pKkjemmc+RuIwh4=; b=XMO+3aiDVXPCBn4ZDvlgNh7DgQjTUH2X1E2kWU15ATV03/lG1hHnfU49mlhh/vpCYQJDBnz/0/LoYYGuDziZ1c8qtAmlEJD6WYg9MzJp2gx61S7nDnzNxBQcwCzS9CTBkkHAYQUq60YH1xfdS/iN/wcWTfxhd2LDQQKvIW543kM= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oss.nxp.com; Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM6PR04MB4325.eurprd04.prod.outlook.com (2603:10a6:209:47::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 15:40:09 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0%7]) with mapi id 15.20.3391.014; Thu, 17 Sep 2020 15:40:09 +0000 To: Ferruh Yigit , "Di, ChenxuX" , "hemant.agrawal@nxp.com" Cc: "sachin.saxena@nxp.com" , "stable@dpdk.org" , "dev@dpdk.org" , "Richardson, Bruce" References: <20200915024055.72103-1-chenxux.di@intel.com> <974e79a6-6a52-c84c-6ae2-cf802e551444@intel.com> <2ada3c33bf2b4dcf862e6fa4e6a97cbc@intel.com> <59ceb607-4ffc-550e-45bf-293b97248ff3@intel.com> From: Hemant Agrawal Message-ID: Date: Thu, 17 Sep 2020 21:10:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: SG2PR06CA0216.apcprd06.prod.outlook.com (2603:1096:4:68::24) To AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.2] (122.176.3.89) by SG2PR06CA0216.apcprd06.prod.outlook.com (2603:1096:4:68::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11 via Frontend Transport; Thu, 17 Sep 2020 15:40:07 +0000 X-Originating-IP: [122.176.3.89] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 17543b0a-2a3d-40ba-2c01-08d85b1ff58b X-MS-TrafficTypeDiagnostic: AM6PR04MB4325: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bbCswB+jCfIXtu6fXAphpczC2KLnvS43fxmM4uHvy6QAYCKpHpzFZNLEtfxV0kP8pvYxruGShNmN3KudBSWa0iEx/jESpVUf///GEsytODssJA3gBMNHuGdlscMn/gGeyahHCgrsQy3H1EVUio+HmERlbteF4F2spY4wXfVN2QmpY3RcrdJKOJoMOAepqTqHM1igfOTkaiy01I+RddjARVINNBedon1ixR9LWO/kAeYKqEWzBdNtFnA3L1+sguezbU9rDSXV3sfG2QUFTw9flhR209KqwUyzYAeNV+lQTzAfDahcQHn/kKuv71SLOpG9pnMilYf7ASdQnyvjxKIPVNVcBedK8D3oglRJZZsDXwFKJVCX8uZfV3HpkeJ58oBWByOvP666/8dsW9rWUyaTjzfHrp8KtbI5AsdFdBr1U+G8zY6hfVPWYKvttaiENpcb X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(16526019)(53546011)(2906002)(6486002)(52116002)(55236004)(26005)(186003)(31686004)(316002)(4326008)(8676002)(16576012)(8936002)(44832011)(956004)(2616005)(54906003)(110136005)(5660300002)(478600001)(6666004)(31696002)(86362001)(66476007)(66556008)(83380400001)(66946007)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: nuXnKi1b6g0MPOj0PV87gac4fCXXt8fw2sAAjo85PEnY469V1fpSYocyFmRZ6RkSq8zQkGdopB9Q9OHnyoxKajpRQoTveVMb5jBJD1AQPszZJt2CcXrLOPThwPN3IGr0XYDVnEf1FlZREYRVNV0ajpcMhWWb4p2bXWyeb8KZWwtOiVXglvQ1XYxWOCMKm2U8OQvCmpFydrFldduaN2Pumm1QeLYJzzfOJqjOcD9XGWDFrUISrZc8eQjk7z+/LzwkIIFczfJixx2+Z7Th82CSmTR7tdmB5E7yHXpZY6YtNui4spjojhUF3X7Bu5uvU3ULufUB2M3XnRG0Tpo2sOl3f5/GxrUlM0vtRFMMb1NPWxOdI+r8TXGfusQHxvYMXki5SYMkduZlUA/yVSjac+CCggAYLzVxm/i/qjY3GQXhfUgxdm/u+5Q0cIxurnO/8vKFsSr4Txg+6jFXYS8WGl5Y/j1mafY+Gy6YL1ITgauKy28A9i/scWm4K8dZb+Aows/wbk+8XFuGV77byoV9mKVcgUTATamHrk1gRfwcPBAHpvIGfosgiXw1+n0nvMfCX1aWh0PI6rVo/gTY0hLnd4DhP06H/bjFO0ycyRXmnhsmqZ5EtqhnUs7idDkWsJb4175znopBoZ1QscVPs15X5vcHJg== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17543b0a-2a3d-40ba-2c01-08d85b1ff58b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2020 15:40:09.7585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b29CUtI3Pua2FCadoWaFblFqZi56YJGPQrjbFhRlm2ui9TgVNPCQM1Ux3tFzEy1yW6vi5oUUOJCYt/UrhuEBpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4325 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/dpaa2: fix build error about timesync functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: hemant.agrawal@nxp.com List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/17/2020 5:29 PM, Ferruh Yigit wrote: > On 9/17/2020 12:50 PM, Hemant Agrawal wrote: >> >> On 9/17/2020 5:08 PM, Ferruh Yigit wrote: >>> On 9/17/2020 3:03 AM, Di, ChenxuX wrote: >>>> Hi, >>>> >>>>> -----Original Message----- >>>>> From: Ferruh Yigit >>>>> Sent: Wednesday, September 16, 2020 11:29 PM >>>>> To: Di, ChenxuX ; hemant.agrawal@nxp.com >>>>> Cc: sachin.saxena@nxp.com; stable@dpdk.org; dev@dpdk.org; Richardson, >>>>> Bruce >>>>> Subject: Re: [dpdk-stable] [PATCH] net/dpaa2: fix build error >>>>> about timesync >>>>> functions >>>>> >>>>> On 9/15/2020 3:40 AM, Chenxu Di wrote: >>>>>> When the build option has '-DRTE_LIBRTE_IEEE1588=1', the announce of >>>>>> timesync functions will be build. >>>>>> However the dpdk_conf doesn't hav RTE_LIBRTE_IEEE1588 so that the >>>>>> file >>>>>> dpaa2_ptp.c will not be build. >>>>>> It cause the build error. >>>>>> This patch fixes it by adding set for dpdk_conf. >>>>>> >>>>>> Fixes: 184c39d16568 ("net/dpaa2: add DPRTC sub-module") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Chenxu Di >>>>>> --- >>>>>>    drivers/net/dpaa2/meson.build | 4 ++++ >>>>>>    1 file changed, 4 insertions(+) >>>>>> >>>>>> diff --git a/drivers/net/dpaa2/meson.build >>>>>> b/drivers/net/dpaa2/meson.build index 6dd0eb274..d9aadfdae 100644 >>>>>> --- a/drivers/net/dpaa2/meson.build >>>>>> +++ b/drivers/net/dpaa2/meson.build >>>>>> @@ -17,6 +17,10 @@ sources = files('base/dpaa2_hw_dpni.c', >>>>>>            'mc/dpdmux.c', >>>>>>            'mc/dpni.c') >>>>>> >>>>>> +if '-DRTE_LIBRTE_IEEE1588=1' in get_option('c_args') >>>>> >>>>> The "RTE_LIBRTE_IEEE1588=1" can fail, >>>>> all places looking for "#ifdef RTE_LIBRTE_IEEE1588", so a "-Dc_args=- >>>>> DRTE_LIBRTE_IEEE1588" is more likely, but why not "-Dc_args=- >>>>> DRTE_LIBRTE_IEEE1588=666" >>>>> >>>> >>>> Yes, I will change it >>>> >>>>>> + dpdk_conf.set('RTE_LIBRTE_IEEE1588', 1) endif >>>>>> + >>>>>>    if dpdk_conf.has('RTE_LIBRTE_IEEE1588') >>>>>>        sources += files('mc/dprtc.c') >>>>>>        sources += files('dpaa2_ptp.c') >>>>>> >>>>> >>>>> Can't we just remove the conditional build: >>>>> >>>>>    -if dpdk_conf.has('RTE_LIBRTE_IEEE1588') >>>>>    -       sources += files('mc/dprtc.c') >>>>>    -       sources += files('dpaa2_ptp.c') >>>>>    -endif >>>>>    +sources += files('mc/dprtc.c') >>>>>    +sources += files('dpaa2_ptp.c') >>>> >>>> The announce of timesync functions are in the #define >>>> DRTE_LIBRTE_IEEE1588 >>>> While the define of the functions are in the file 'dpaa2_ptp.c'. >>>> So they should be both build or not build by whether the build >>>> option -DRTE_LIBRTE_IEEE1588=1 or not. >>>> So it seems not a good idea that remove the conditional. >>>> >>> >>> timesyncs_* dev_ops functions defined but not used is not big >>> problem, only can increase the library size. >>> >>> I believe more concern is on: >>> 'RTE_PMD_REGISTER_DPAA2_OBJECT(dprtc, rte_dpaa2_dprtc_obj);' >>> which looks like register function to run in constructor when >>> 'dpaa2_ptp.c' is compiled, but not sure affect of it. >>> It can be possible to wrap that call with 'RTE_LIBRTE_IEEE1588' >>> ifdef, that should work. >>> >>> It is preferred to remove the compile time flag instead of finding >>> ways to make it work. >>> >>> Let's wait for the dpaa2 maintainers' response, perhaps they can >>> come with a smart way to remove the compile time flag. >> >> Hi Ferruh, >> >>     enabling  IEEE1588 causes some performance drop in the dpaa2 >> performance. That is the reason, we have kept this code in compile >> time flag. >> >> >> However, we will work in future to make it run-time configurable but >> that will require some code restructuring and it will be a moderate >> size work. >> > > OK, thanks Hemant. > > At least can it be possible to remove it from the build files, what do > you think about wrapping those two files (or their relevant parts) > with 'RTE_LIBRTE_IEEE1588' ifdef and remove the checks from meson file? > ok.