From: Luca Boccassi <luca.boccassi@gmail.com>
To: Yuan Wang <yuanx.wang@intel.com>, stable@dpdk.org
Cc: maxime.coquelin@redhat.com, chenbo.xia@intel.com,
jiayu.hu@intel.com, cheng1.jiang@intel.com, weix.ling@intel.com
Subject: Re: [PATCH 21.11] examples/vhost: fix retry logic on Rx path
Date: Fri, 08 Jul 2022 11:55:02 +0100 [thread overview]
Message-ID: <c6b68d26806ba40a9323c0e5620327afdfe4ac88.camel@gmail.com> (raw)
In-Reply-To: <20220708171435.60845-1-yuanx.wang@intel.com>
On Sat, 2022-07-09 at 01:14 +0800, Yuan Wang wrote:
> [ upstream commit 1907ce4baec392a750fbeba5e946920b2f00ae73 ]
>
> drain_eth_rx() uses rte_vhost_avail_entries() to calculate
> the available entries to determine if a retry is required.
> However, this function only works with split rings, and
> calculating packed rings will return the wrong value and cause
> unnecessary retries resulting in a significant performance penalty.
>
> This patch fix that by using the difference between tx/rx burst
> as the retry condition.
>
> Fixes: be800696c26e ("examples/vhost: use burst enqueue and dequeue from lib")
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> examples/vhost/main.c | 79 ++++++++++++++++++-------------------------
> 1 file changed, 33 insertions(+), 46 deletions(-)
Thanks, applied.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2022-07-08 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 17:14 Yuan Wang
2022-07-08 10:55 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b68d26806ba40a9323c0e5620327afdfe4ac88.camel@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=weix.ling@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).