From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9AFD4A2EDB
	for <public@inbox.dpdk.org>; Tue,  1 Oct 2019 10:48:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5E334493D;
	Tue,  1 Oct 2019 10:48:17 +0200 (CEST)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
 [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id B2B4944C7
 for <stable@dpdk.org>; Tue,  1 Oct 2019 10:48:16 +0200 (CEST)
Received: by mail-wm1-f67.google.com with SMTP id y21so2273873wmi.0
 for <stable@dpdk.org>; Tue, 01 Oct 2019 01:48:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:user-agent:mime-version;
 bh=0SF8kDfb1DmQmIGLUhqsXl6492nS67lKqJrxR13U2F8=;
 b=HDtad9u5kJ/dCDqRYgDQWcPG+spbD3FGedMvuoM/RlCj3mSyBNrCzp2Jqz7zy/opRI
 +rqKv1PJYBH2vnJJBMJp2q/5+AhEBt1uyUoKAAJ9v6m36hGdYWPIkykNPiGPmpvsYQbB
 mi+x0Kg2I/ED62yFziHfstnI6k9t+SGohb0CM2JMwqDFVuV3UZAjL3TLzb0ZjTNR0/4L
 5J1meeN0T56LCiKvvwsEB6RhgKhFjdhAsmLcRsjJewvGQrFTjxunFQmZPWX1KVi6er4E
 LEya66PgfKHEqVJLVFYypMTYDCWbkZhX6HlhzcyiZ21aFD2+i/0AI/AYGNVYcW/UCmYx
 8L5w==
X-Gm-Message-State: APjAAAWDPWj9aQMUHGJ3yv0qYg3u+cOJIVal5g3JRZwHlBc0F+fDfusz
 Thhk+WtuE2q/JWHx7Iu7xpk=
X-Google-Smtp-Source: APXvYqy+AneoKWMhGMS5X+D6ypC9c2AmD7jECNexqAUdPJM0B/2Iw/lmVSmpGUBkjGelrdQHpWMD2g==
X-Received: by 2002:a7b:c7d4:: with SMTP id z20mr2691427wmk.49.1569919696218; 
 Tue, 01 Oct 2019 01:48:16 -0700 (PDT)
Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3])
 by smtp.gmail.com with ESMTPSA id j11sm994712wrw.86.2019.10.01.01.48.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 01 Oct 2019 01:48:15 -0700 (PDT)
Message-ID: <c77d967af8a5c9c024581aa635c70807d2825b8c.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>, Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org, honnappa.nagarahalli@arm.com, Nipun Gupta
 <nipun.gupta@nxp.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Tue, 01 Oct 2019 09:48:14 +0100
In-Reply-To: <2613008.bAPQ5MWe9V@xps>
References: <2613008.bAPQ5MWe9V@xps>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Subject: Re: [dpdk-stable] missing ring memory barrier in 17.11
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> Hi Luca, Gavin,
>=20
> It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> slots")
> should be backported in 17.11.
>=20
> This patch is missing because the root cause is wrongly identified.
> It is referenced as
> 	Fixes: c9fb3c62896f ("ring: move code in a new header file")
> in 18.02, but in reality it is from 17.05:
> 	Fixes: 0dfc98c507b1 ("ring: separate out head index
> manipulation")
>=20
> Do you agree?

Hi,

Makes sense to me, and it applies cleanly (after accounting for the
source file name change). I'll queue it up for 17.11.8.

--=20
Kind regards,
Luca Boccassi