From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70799A0C41 for ; Wed, 15 Sep 2021 12:40:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A5624003C; Wed, 15 Sep 2021 12:40:23 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 908274003C; Wed, 15 Sep 2021 12:40:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="202450071" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="202450071" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 03:40:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="508717910" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 15 Sep 2021 03:40:10 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 03:40:09 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 03:40:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 03:40:09 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 03:39:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqJnJCR7QicXKjB8eiTAb+AUX20bUENhKO6Im830FWwSkBZcbE6AXYNFCPMCjjLkH8j7UkA1353JewtpNa+SEDOEq7kVirMDGUz+mYwCU/mccfV1leFVBkG/+4yhSkGwSc07bnz181hbAX8ZBb8Ow8OzBWwBe/ggDBWmiXvCJffup45ltPQPlmKzrnb3ZSCk1RXEcEI7/u3MvnjPgv3F91LGe4nUTO69ufqEK1NpCBNkcuCl5ieHMtRH1ZgfWiR9UgALNOfdl80/iBhojmTPZntt7K5AeMMFx5FvPYqH8UK+N+8HKTGMn92g1Z14bZ8Ot7QG0HUuZ4YumiFFkqZHGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3J/Vit/5Njy3F7XbYe6Du9JvFhdqfG3i+smGdKLtUzQ=; b=RbTmi2pcDcXgXOsP/V2OO+k5vX7sDWG3nQ6H8UkSq88QcU3Qn4GVMOf5PkRqH929ZJ6r5bZ3YKPcLEkeJeXa9h2XB0zcjlj+uxBApsn1dLM1kMky3i04UVeAy53jHBjmClCpCdmXB5m4r2rRyWqz9VvIrg6xd2KpgUXpT8Ha7LS54Ec+ez9XbF+UBf7M22cErefHi++EQbrKixC0XIRF/TMBKzJjA6WHxzuVoJ72Rbyh0tVvfUJL83opr96C+w3ehazO/DjbkUl4A/34CSMxhHLSqodwPIRl7eCMDrhMw5D8BEDVAzgI0MBWMwi33St2dq1zRvlV8mPV2iqMerDbpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3J/Vit/5Njy3F7XbYe6Du9JvFhdqfG3i+smGdKLtUzQ=; b=T5APi3JAkhPGgzdSiwERjzgEUl6XYHns59nUfxcYHQ4XWUTI75Xgn9UkVuDhaImStoL0KvKt6H8pbj97BClBJ/uacuttjRD8GT9nC5c3qWyigLdTp2ImVPJEFRb7AAav/HEZpU++P42qtZ0pwOMoaCL/No1pRTkM82jhXPoj08s= Authentication-Results: amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5158.namprd11.prod.outlook.com (2603:10b6:510:3b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 15 Sep 2021 10:39:31 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 10:39:31 +0000 To: Mohsin Kazmi , , "Konstantin Ananyev" , Olivier Matz CC: , Andrew Rybchenko , Marcin Wojtas , Michal Krawczyk , "Shai Brandes" , Evgeny Schemeilin , "Igor Chauskin" References: <20210707094019.40945-1-mohsin.kazmi14@gmail.com> <20210907104916.27560-1-mohsin.kazmi14@gmail.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 15 Sep 2021 11:39:24 +0100 In-Reply-To: <20210907104916.27560-1-mohsin.kazmi14@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0601CA0009.eurprd06.prod.outlook.com (2603:10a6:4:7b::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0601CA0009.eurprd06.prod.outlook.com (2603:10a6:4:7b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 10:39:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28e93a6e-475f-4803-155c-08d97835198b X-MS-TrafficTypeDiagnostic: PH0PR11MB5158: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +UJ2Ur7WCqBiac8hI/BZL5nzV30L9+Esa0eeFlhDDoG8XJ7u7AZJWxrkuN3G8X8DFt0oFSIQO68cYFvGPHiqAWMGjOgNs0aoV6qPSAHfQV0fgKaHpwbdwMbhp52Wzs2alWVhm8QO58lVCaFyqlUusw/PawQGOhWOQbh/PUDReTFXy4dRR0dSMDoeJkf26mjrZc7CeXHq9WKg9BcPyspA+aoHoA5b6r4ilmQ7l5JaIcVC1E0CLVzbQxhs1Ze7j8iZkBkYAznIGMhqTO9gQtIbAQh9VNUwRz69p+1q2MClQ8SZ/TWmSj2OmJewFeLgSfyqM65ajmX+GKasU0b5TyhU0cMmFEwCBOk3ngQeBAMzkBmhIlPqYpYB2zjSuUQH492iwZQOZYmjnmv3kZBPc7Uz/wxUJGHoY4i+Kl/1HftQpOQ4tGIiFbZMkyTAED/iEHf2bv2Jg9ssPld6T/brxvMSmMOvxKn9e5dxYcfcZSNwv6j3nOUzVU/AnUI9pktdmQ8UMkzwdUw9ZeH8hMxDusNNDdNoIGEtu+O3PlO9oPUZ14CAWI5bmwmNxNmQCvBwKWctMNLGtr6MpZvVd6rM3waCfc+O0+3BAWMDkMZNfRHV2byZb4z/ZbSxjYG1NqkKcELVX5Wlr4lPNqEPqCOg7bbB5iVWpEw1UZGOSpDl5519EPYJegCyh9iH5Lz5SlcqeMN9D1Iq2NkKiAbi9MtBkbwdXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(39860400002)(346002)(396003)(54906003)(2906002)(316002)(66946007)(4744005)(66556008)(110136005)(16576012)(38100700002)(31696002)(66476007)(31686004)(956004)(8676002)(44832011)(8936002)(36756003)(86362001)(186003)(4326008)(53546011)(6666004)(26005)(478600001)(2616005)(5660300002)(6486002)(7416002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkdBVkJVRHBDVko5R3NwTVlDT1FSM0kxa3hJSUR3amZGRkdWZHZMMkVmN0pT?= =?utf-8?B?L05yeFplNkVZK0o4VkprWFBwNzlXOFZPQ2NvUHE1d3B6emZTbmw5d3JMQlhl?= =?utf-8?B?L01Sb09YZms2eWtWVnRNTldEaG1IdXlhL3dsOXZGVDVBcjR1QzJ2akw1RlRw?= =?utf-8?B?MEgzZ25qY1JIbm40dmZBM0Jub0hUZHo2ZTQrb2Z1VGZkZ1hVOUQzRlBpbmE0?= =?utf-8?B?TU9EdzlqaXY3SjNNYzhGYVVaZGZ2ZldCUllqRUhOajFyTXdzTk1udjVFK0s2?= =?utf-8?B?TEYvRjRSbVZ4N1pvbHhoNVNoZEYxNzU1d1YrWTVQYncwdWhUL1l2WUd2R29K?= =?utf-8?B?bFZEM1dvK2hJUlZXNGNqNGovckJ4TWRaeGFRRWtEZHRiSmY5RUJDM3lDMWRC?= =?utf-8?B?UXEzZE1iVXpXNTNzVkg2ekZWVXh6Wk5tNktNc3ZoekdRakdVZ0xxVmpGaHJi?= =?utf-8?B?V2c4ZVhZV2RUM2pwcXREZzFMQWwwdDYxVmxpS0s1NmNpei91eXZEZSszYzRN?= =?utf-8?B?WUt2VkpPdjk3OFVETmxNRktQOERvRVVUcUxEQkJDcXFaVWFncnBidUlMZXJD?= =?utf-8?B?dkdOVTFkWFdmc3hVUFlZL1JPVHBDU0VIWTN4Wkg0MnpLTkxCSHZYQkhBbDVw?= =?utf-8?B?RC9RVmNGcWZXa2plRGtET3lZdWNKOHB6emh1VFpEeUl0M2NLT0RTNGdkdk5u?= =?utf-8?B?YXRsZmxwWllrM29Qc08waWgvK2JocTZnVnRMamRXSDJVdHdLWTNoeUh0OG5Z?= =?utf-8?B?WHRpWWRIMm1nMzI5Ymx4a1NIUVpPVVFVV2E5eWJXTDBvV2svMXJBTHl0YnRY?= =?utf-8?B?YitySzFndHd6NnNyZk9xb0VTdkhRamcrNUlvY2x6ZFRGRnQvcEU4Q0Nvck1q?= =?utf-8?B?SVdFcVpWbWlZQjl0M0xaYU0vc1VQU3B2Vnd4UVVYT0k3TzYwRDhVTFFTYW9T?= =?utf-8?B?Qm1LSjl4UGdhekdYUmxEdmZHdlQ0bHdKTFhIY0czSm5aNkdHVnNlUWQyQXEw?= =?utf-8?B?SGw0M1lCRUprVUxLclZTSEREZ3R3a0xxemZoZHFVNUlpS2pBSzFzZlFlWDhU?= =?utf-8?B?emJWYnJvSE9hVmVCbXhkUDhlQzB0SUtpZkNmWHlaTHRjRlJBNHBHbis1eDZk?= =?utf-8?B?a1FWdjdmYnZWZ200M3laTjU4RHNKY2hUdXNHMU1kZ3JQRy9JQ2JqMGwwNXdr?= =?utf-8?B?VjlDZWlQakZOYXNtK1JKZGx4UXl5UmlRQ0JtUjdwQXFLeldYZjFNekpWQ2xk?= =?utf-8?B?MUtId01yRy8zSUJxbDVLWWdvUnFwSFZlT3cxdXhKcytIY05qb2p4c2M5Rlho?= =?utf-8?B?Qmtidm9NTDVweWhib1kvWHkzYU9HdGNhRnFDNXBsVS9YRVNBWEIzTU9QZldv?= =?utf-8?B?R0g3S2VPeURmNFZ2Uk9HcW9hRk9QYWU5Z0dhakJXdTJyMkFLTjRkY2ppNFJl?= =?utf-8?B?dzFWWVBwRzE2dXlQN0M0K0dNWnlGYzZBYkxmbDY3U0puWkgwb0VzM3I5L1A2?= =?utf-8?B?MzlkMm9JWTg2Nk8xb0JFTkxwRytkNFc5SE9oU3VVa1RUc1FCLzdwcWU3Z0Zq?= =?utf-8?B?MHNLNWdTWEVlelJqM1o3ZGxVR0d6LzhrL0FLaWZCZ1Q5cmxTS05WaGxyNUV4?= =?utf-8?B?OEhvOXZJaUxyWVh1VjNCYWZtV2FKVXFyZXMreFFzTmhpc3pnSnFsQ21DUjdp?= =?utf-8?B?cDgzMTZuSy9GWmNtUlBkSkIzdkNoRkFjcmlISTV5MGNtTWVyNlBZbkdpLzdF?= =?utf-8?Q?G79AmcfMKAg10h0y3VwXtVYY14icLhszGrBpKN3?= X-MS-Exchange-CrossTenant-Network-Message-Id: 28e93a6e-475f-4803-155c-08d97835198b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 10:39:30.9080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nA+cbrCHJmd44dbdjCKagm1XodIpDEc7MXuce3eLDuwNW9KtpjOHyQgo+eP6IuQb2bflE66Ft2MgvDA8TsmfSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5158 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 hdr for checksum X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/7/2021 11:49 AM, Mohsin Kazmi wrote: > Preparation of the headers for the hardware offload > misses the outer IPv4 checksum offload. > It results in bad checksum computed by hardware NIC. > > This patch fixes the issue by setting the outer IPv4 > checksum field to 0. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: stable@dpdk.org > > Signed-off-by: Mohsin Kazmi > Acked-by: Qi Zhang > Acked-by: Olivier Matz <...> > diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h > index 434435ffa2..42639bc154 100644 > --- a/lib/net/rte_net.h > +++ b/lib/net/rte_net.h > @@ -125,11 +125,22 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags) Not directly related with this patch, but is the function 'rte_net_intel_cksum_flags_prepare()' really Intel specific? I can see sfc & ena are also using this function, should we rename it?