From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 2B2E21E35;
Tue, 20 Mar 2018 15:12:15 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
20 Mar 2018 07:12:15 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,335,1517904000"; d="scan'208";a="35353304"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63])
([10.237.221.63])
by FMSMGA003.fm.intel.com with ESMTP; 20 Mar 2018 07:12:13 -0700
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: skhare@vmware.com, Chas Williams <chas3@att.com>, stable@dpdk.org
References: <20180318014552.16703-1-3chas3@gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <c7a2017c-c78b-4b7c-a7a5-6e172724d4a1@intel.com>
Date: Tue, 20 Mar 2018 14:12:12 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180318014552.16703-1-3chas3@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 14:12:16 -0000
On 3/18/2018 1:45 AM, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>
> The vmxnet3 never attempts link speed negotiation. As a virtual device
> the link speed is vague at best. However, it is important for certain
> applications, like bonding, to see a consistent link_status. 802.3ad
> requires that only links of the same cost (link speed) be enslaved.
> Keeping the link status consistent in vmxnet3 avoids races with bonding
> enslavement.
>
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date: Fri Jan 5 18:38:55 2018 +0100
>
> Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
> Cc: stable@dpdk.org
There were a few more PMDs [1] they have been updated from FIXED to AUTONEG with
above commit, do you think should we update them back to FIXED as well?
[1]
pcap
softnic
vmxnet3
>
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 426008722..48a4d4f98 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
> link.link_status = ETH_LINK_UP;
> link.link_duplex = ETH_LINK_FULL_DUPLEX;
> link.link_speed = ETH_SPEED_NUM_10G;
> - link.link_autoneg = ETH_LINK_AUTONEG;
> + link.link_autoneg = ETH_LINK_FIXED;
>
> return rte_eth_linkstatus_set(dev, &link);
> }
>