* [PATCH] net/nfp: fix getting firmware VNIC version
@ 2024-03-11 1:54 Chaoyong He
2024-03-11 23:34 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2024-03-11 1:54 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, Qin Ke, Chaoyong He, stable, Long Wu, Peng Zhang
From: Qin Ke <qin.ke@corigine.com>
When getting firmware VNIC version, the logic for representor
ports and other ports is inverse, fix it.
Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port")
Cc: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org
Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_net_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 20e628bfd1..bd43925960 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2155,7 +2155,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,
hw = nfp_net_get_hw(dev);
- if (rte_eth_dev_is_repr(dev)) {
+ if (!rte_eth_dev_is_repr(dev)) {
snprintf(vnic_version, FW_VER_LEN, "%d.%d.%d.%d",
hw->ver.extend, hw->ver.class,
hw->ver.major, hw->ver.minor);
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: fix getting firmware VNIC version
2024-03-11 1:54 [PATCH] net/nfp: fix getting firmware VNIC version Chaoyong He
@ 2024-03-11 23:34 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-03-11 23:34 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, Qin Ke, stable, Long Wu, Peng Zhang
On 3/11/2024 1:54 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke@corigine.com>
>
> When getting firmware VNIC version, the logic for representor
> ports and other ports is inverse, fix it.
>
> Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qin Ke <qin.ke@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-11 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 1:54 [PATCH] net/nfp: fix getting firmware VNIC version Chaoyong He
2024-03-11 23:34 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).