meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting

meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting

[Li, WeiyuanX]

Hi Ivan,

This patch is merged into dpdk22.11.0rc1  we execute meson test case link_bonding_autotest, link_bonding_rssconf_autotest and link_bonding_mode4_autotest test failed.
Could you please have a look at it, also submitted a Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=1118

Regards,
Li, Weiyuan

> -----Original Message-----
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> Sent: Sunday, September 11, 2022 8:19 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Chas Williams <chas3@att.com>; Min
> Hu (Connor) <humin29@huawei.com>; Hari Kumar Vemula
> <hari.kumarx.vemula@intel.com>
> Subject: [PATCH] net/bonding: fix descriptor limit reporting
> 
> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks
> reporting of "nb_min" and "nb_align" values obtained from back-end
> devices' descriptor limits. This means that work done by
> eth_bond_slave_inherit_desc_lim_first() as well as
> eth_bond_slave_inherit_desc_lim_next() gets dismissed.
> 
> Revert the offending commit and use proper workaround for the test case
> mentioned in the said commit.
> 
> Meanwhile, the test case itself might be poorly constructed.
> It tries to run a bond with no back-end devices attached, but, according to [1]
> ("Requirements / Limitations"), at least one back-end device must be
> attached.
> 
> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
> 
> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---

Re: meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting

[Ivan Malov]

Hi,

Please see 
https://patches.dpdk.org/project/dpdk/patch/20221031131744.2340150-1-ivan.malov@oktetlabs.ru/ 
.

Thank you.

On Mon, 31 Oct 2022, Li, WeiyuanX wrote:

> Hi Ivan,
>
> This patch is merged into dpdk22.11.0rc1  we execute meson test case link_bonding_autotest, link_bonding_rssconf_autotest and link_bonding_mode4_autotest test failed.
> Could you please have a look at it, also submitted a Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=1118
>
> Regards,
> Li, Weiyuan
>
>> -----Original Message-----
>> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Sent: Sunday, September 11, 2022 8:19 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; Chas Williams <chas3@att.com>; Min
>> Hu (Connor) <humin29@huawei.com>; Hari Kumar Vemula
>> <hari.kumarx.vemula@intel.com>
>> Subject: [PATCH] net/bonding: fix descriptor limit reporting
>>
>> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks
>> reporting of "nb_min" and "nb_align" values obtained from back-end
>> devices' descriptor limits. This means that work done by
>> eth_bond_slave_inherit_desc_lim_first() as well as
>> eth_bond_slave_inherit_desc_lim_next() gets dismissed.
>>
>> Revert the offending commit and use proper workaround for the test case
>> mentioned in the said commit.
>>
>> Meanwhile, the test case itself might be poorly constructed.
>> It tries to run a bond with no back-end devices attached, but, according to [1]
>> ("Requirements / Limitations"), at least one back-end device must be
>> attached.
>>
>> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
>>
>> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> ---
>

RE: meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting

[Li, WeiyuanX]

Hi,

The following patches apply to successfully resolve this issue.

https://patches.dpdk.org/project/dpdk/patch/20221031131744.2340150-1-ivan.malov@oktetlabs.ru/
https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.malov@oktetlabs.ru/

Regards,
Li, Weiyuan

> -----Original Message-----
> From: Li, WeiyuanX
> Sent: Monday, October 31, 2022 5:05 PM
> To: Ivan Malov <ivan.malov@oktetlabs.ru>; dev@dpdk.org
> Cc: stable@dpdk.org; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Chas Williams <chas3@att.com>; Min
> Hu (Connor) <humin29@huawei.com>; Hari Kumar Vemula
> <hari.kumarx.vemula@intel.com>
> Subject: meson test link bonding failed//RE: [PATCH] net/bonding: fix
> descriptor limit reporting
> 
> Hi Ivan,
> 
> This patch is merged into dpdk22.11.0rc1  we execute meson test case
> link_bonding_autotest, link_bonding_rssconf_autotest and
> link_bonding_mode4_autotest test failed.
> Could you please have a look at it, also submitted a Bugzilla ticket:
> https://bugs.dpdk.org/show_bug.cgi?id=1118
> 
> Regards,
> Li, Weiyuan
> 
> > -----Original Message-----
> > From: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Sent: Sunday, September 11, 2022 8:19 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Andrew Rybchenko
> > <andrew.rybchenko@oktetlabs.ru>; Chas Williams <chas3@att.com>; Min
> Hu
> > (Connor) <humin29@huawei.com>; Hari Kumar Vemula
> > <hari.kumarx.vemula@intel.com>
> > Subject: [PATCH] net/bonding: fix descriptor limit reporting
> >
> > Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
> > breaks reporting of "nb_min" and "nb_align" values obtained from
> > back-end devices' descriptor limits. This means that work done by
> > eth_bond_slave_inherit_desc_lim_first() as well as
> > eth_bond_slave_inherit_desc_lim_next() gets dismissed.
> >
> > Revert the offending commit and use proper workaround for the test
> > case mentioned in the said commit.
> >
> > Meanwhile, the test case itself might be poorly constructed.
> > It tries to run a bond with no back-end devices attached, but,
> > according to [1] ("Requirements / Limitations"), at least one back-end
> > device must be attached.
> >
> > [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
> >
> > Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > ---