Re: please help backporting some patches to stable release 21.11.4

[Kevin Traynor <ktraynor@redhat.com>]

On 01/03/2023 16:16, Kundapura, Ganapati wrote:
> Hi Kevin,
>       Below mentioned crypto patches has dependency on below commit
> 
> commit 2ae84b39ae7b92c6b72f9dc9aa0a4aa2572e10e1
> Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
> Date:   Thu Feb 10 11:41:16 2022 -0600
> 
>      eventdev/crypto: store operations in circular buffer
> 
>      Move crypto ops to circular buffer to retain crypto
>      ops when cryptodev/eventdev are temporarily full.
> 
>      Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
>      Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> 
> Could you please pull this commit and try applying other patches?
> 

Similar to 20.11, it does not apply. So your choice is to refactor the 
commits so they apply on 21.11 and test, or if they are not critical we 
can drop from backporting.

If you are not confident about the backports or have not tested them 
then I suggest to drop them. I prefer to avoid regressions than to take 
risky fixes.

thanks,
Kevin.

> Thanks,
> Ganapati
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, February 28, 2023 11:55 PM
>> To: dpdk stable <stable@dpdk.org>
>> Cc: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Akhil Goyal
>> <gakhil@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Xia, Chenbo
>> <chenbo.xia@intel.com>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>; David Marchand
>> <david.marchand@redhat.com>; Dongdong Liu
>> <liudongdong3@huawei.com>; Fan Zhang <fanzhang.oss@gmail.com>;
>> Fengnan Chang <changfengnan@bytedance.com>; Kundapura, Ganapati
>> <ganapati.kundapura@intel.com>; Hanumanth Pothula
>> <hpothula@marvell.com>; Harman Kalra <hkalra@marvell.com>; Huisong Li
>> <lihuisong@huawei.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Ji, Kai
>> <kai.ji@intel.com>; Kiran Kumar K <kirankumark@marvell.com>; Matan
>> Azrad <matan@nvidia.com>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Chautru, Nicolas
>> <nicolas.chautru@intel.com>; Nithin Dabilpuram
>> <ndabilpuram@marvell.com>; Pavan Nikhilesh
>> <pbhagavatula@marvell.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
>> Satheesh Paul <psatheesh@marvell.com>; Shijith Thotton
>> <sthotton@marvell.com>; Stephen Hemminger
>> <stephen@networkplumber.org>; Steve Yang <stevex.yang@intel.com>;
>> Suanming Mou <suanmingm@nvidia.com>; Tyler Retzlaff
>> <roretzla@linux.microsoft.com>; Viacheslav Ovsiienko
>> <viacheslavo@nvidia.com>; Jangra, Yogesh <yogesh.jangra@intel.com>
>> Subject: please help backporting some patches to stable release 21.11.4
>>
>> Hi commit authors (and maintainers),
>>
>> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
>> fixes.sh I didn't apply following commits from DPDK main to 21.11 stable
>> branch, as conflicts or build errors occur.
>>
>> Can authors check your patches in the following list and either:
>>      - Backport your patches to the 21.11 branch, or
>>      - Indicate that the patch should not be backported
>>
>> Please do either of the above by 03/06/23.
>>
>> You can find the a temporary work-in-progress branch of the coming 21.11.4
>> release at:
>>      https://github.com/kevintraynor/dpdk-stable
>> It is recommended to backport on top of that to minimize further conflicts or
>> misunderstandings.
>>
>> Some notes on stable backports:
>>
>> A backport should contain a reference to the DPDK main branch commit in it's
>> commit message in the following fashion:
>>      [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>>
>> For example:
>>      https://git.dpdk.org/dpdk-
>> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>>
>> When sending the backported patch, please indicate the target branch in the
>> subject line, as we have multiple branches, for example:
>>      [PATCH 21.11] foo/bar: fix baz
>>
>> With git format-patch, this can be achieved by appending the parameter:
>>      --subject-prefix='PATCH 21.11'
>>
>> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>>
>> FYI, branch 21.11 is located at tree:
>>     https://git.dpdk.org/dpdk-stable
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
>> c5b531d6ee  Anoob Joseph     app/crypto-perf: fix session freeing
>> cc75968228  Fengnan Chang    eal: cleanup alarm and hotplug before memory
>> detach
>> 04dac73643  Ganapati Kundapura eventdev/crypto: fix enqueue count
>> 4b04134cbb  Ganapati Kundapura eventdev/crypto: fix failed events
>> da73a2a0d1  Ganapati Kundapura eventdev/crypto: fix offset used while
>> flushing events
>> f442c04001  Ganapati Kundapura eventdev/crypto: fix overflow in circular
>> buffer 5a0f64d84b  Hanumanth Pothula net/cnxk: fix configuring large Rx/Tx
>> queues
>> 59ceaa72d5  Harman Kalra     common/cnxk: fix part number for CN10K
>> 4ba28c957a  Huisong Li       net/hns3: extract common functions to set Rx/Tx
>> 10f91af5a5  Huisong Li       net/hns3: fix burst mode query with dummy
>> function
>> 5172f9c464  Huisong Li       net/hns3: fix RSS key size compatibility
>> 2aec7beaba  Huisong Li       net/hns3: make getting Tx function static
>> 6a934ba4c6  Huisong Li       net/hns3: separate Tx prepare from getting Tx
>> function
>> 31a28a99fd  Jiawen Wu        net/ngbe: add spinlock protection on YT PHY
>> 585283f9a7  Maxime Coquelin  vhost: fix possible FD leaks
>> 8abe31b1d9  Nicolas Chautru  app/bbdev: add allocation checks e77d682aad
>> Nicolas Chautru  baseband/acc100: fix input error related to padding
>> 5781638519  Nithin Dabilpuram common/cnxk: fix RQ mask config for CN10KB
>> chip 3fe71706ab  Pavan Nikhilesh  event/cnxk: fix stale data in workslot
>> 927cb43fe9  Pavan Nikhilesh  examples/l3fwd: fix port group mask with
>> AltiVec
>> 4741248656  Satheesh Paul    common/cnxk: fix dual VLAN parsing
>> 2245ccf746  Stephen Hemminger crypto/ipsec_mb: remove unnecessary null
>> check
>> 0f044b6681  Steve Yang       net/iavf: fix refine protocol header
>> 0b241667cc  Steve Yang       net/iavf: fix tainted scalar
>> b125c0e721  Steve Yang       net/iavf: fix tainted scalar
>> cedb44dc87  Suanming Mou     common/mlx5: improve AES-XTS tweak
>> capability check
>> 9b31fc9007  Viacheslav Ovsiienko net/mlx5: fix read device clock in real time
>> mode
>> a774cba0bb  Yogesh Jangra    pipeline: fix validate header instruction
>