From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5615343A0D for ; Tue, 30 Jan 2024 13:17:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CDAA41132; Tue, 30 Jan 2024 13:17:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9896541109 for ; Tue, 30 Jan 2024 13:17:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706617065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Gdl4O37hdwLXwOV9Y3KAX8kvY07m/4gMNUehIn+R1xM=; b=RZy5sSzQF/ckefn29uqtCCAf5PTwVAipyAZJHPYJt9jUknjd5gi/LwdO0SnnYDF9jfS8nC FFhZxjLqxWaXaGd+BTP8A6uUp33KWumYjQ8FehuWV0fynHwxn6zy5YhuCsngJbHt+zKH/P n/VeOX+Hi9ViByILEpkKzJvtJkqTpDU= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-Hf6yQ4D0NTGbLJaUMPZh9g-1; Tue, 30 Jan 2024 07:17:40 -0500 X-MC-Unique: Hf6yQ4D0NTGbLJaUMPZh9g-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5101e12059aso3141460e87.0 for ; Tue, 30 Jan 2024 04:17:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706617059; x=1707221859; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gdl4O37hdwLXwOV9Y3KAX8kvY07m/4gMNUehIn+R1xM=; b=vHg8ZHQaEMgYXQkS0nrIfBy1TubYKfnykoBARca6h259rW/Cs0uO1fBQQA9MzRMttE MuXv9B37I5drR4BajCAu4SrbsYS0mn7qZ2ZzV3Ok9Lrfh5MvQGupkCw9IEkz2nbESaje i1bJ9P2YEHLazq83i/p99FNDzBBGPLEWU0GpfU3EjGiywx1TjF5hmI3yWSlzA6UBhxew 2Uww67JFg+W8q/VcTbBeulYK5T0qJGY/cxUT7lD1K8oGOQLaar3fXJfsKmbi0UZTJ/f9 V+i7ftVtfrqyvvI0o08/fcnZY3Os29DPbO4YHcIsos7z+CqpQmAkWmtYu3Pz6P2pgr7X QKAg== X-Gm-Message-State: AOJu0Yyhheu8DhT0vfj8Qf//fH2DUuOzGa1ilo1lLMA6PecZOBG9mnNY 02KAlbohiOHBXr4Mj9FwmdQbUD/Of0XaSRdUN0NcPu8EXefbn6gyJDysRpUCxq41xfvSdtwlA9K EdAx0slFlHUMp33SPOtPWmsVSCEPHTOE6FHjV/8MXzgZd X-Received: by 2002:a05:6512:3f0c:b0:511:19b0:3f22 with SMTP id y12-20020a0565123f0c00b0051119b03f22mr1591856lfa.31.1706617058862; Tue, 30 Jan 2024 04:17:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsWW9D/M5XzRbihvCmld9ER9N/D10/JqLlX6DILRkOyXPWpEHhzh7nPDzcbgAxC3Gw3lB1uw== X-Received: by 2002:a05:6512:3f0c:b0:511:19b0:3f22 with SMTP id y12-20020a0565123f0c00b0051119b03f22mr1591844lfa.31.1706617058467; Tue, 30 Jan 2024 04:17:38 -0800 (PST) Received: from [192.168.0.36] ([78.16.129.35]) by smtp.gmail.com with ESMTPSA id x11-20020adfec0b000000b0033afc875fd5sm1203417wrn.49.2024.01.30.04.17.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 04:17:38 -0800 (PST) Message-ID: Date: Tue, 30 Jan 2024 12:17:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] net/nfp: fix stop cpp service problem To: Ferruh Yigit , Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , stable@dpdk.org, Peng Zhang , Luca Boccassi References: <20240124092541.2011874-1-chaoyong.he@corigine.com> <20240124092541.2011874-5-chaoyong.he@corigine.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 30/01/2024 12:07, Ferruh Yigit wrote: > On 1/24/2024 9:25 AM, Chaoyong He wrote: >> From: Long Wu >> >> Stop cpp service if all representors are closed and cpp service is running. >> >> Fixes: bab0e6f48b6d ("net/nfp: fix infinite loop") >> Cc: chaoyong.he@corigine.com >> Cc: stable@dpdk.org >> > > This fix is using a new function that is introduced in previous patches > in this set, so this fix can't be backported. > > Can you please change the order of the patches in this set, make this > patch first patch in the set and update it to use old version of > functions, so it can be backported? > Later you can update old function with new one in the patch that > introduces the new functions. > Agree, it makes sense to put fixes at the start of the series to make the backport easier. If it's not possible for some reason, then you can also send a rebased revision of the fix to the stable mailing list with the correct prefix (http://doc.dpdk.org/guides/contributing/patches.html#backporting-patches-for-stable-releases) > > Also instead of saying "cpp service problem" in the title, can you > please describe the problem, I guess the problem you are referring is > something like, "CPP service is consuming resources even there is no > device remaining that requires it" ? Or is it something else? > +1 >> Signed-off-by: Long Wu >> Reviewed-by: Chaoyong He >> Reviewed-by: Peng Zhang >> --- >> drivers/net/nfp/flower/nfp_flower_representor.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c >> index bf67dc3ba2..2e8eb13e4e 100644 >> --- a/drivers/net/nfp/flower/nfp_flower_representor.c >> +++ b/drivers/net/nfp/flower/nfp_flower_representor.c >> @@ -400,6 +400,9 @@ nfp_flower_repr_dev_close(struct rte_eth_dev *dev) >> /* Stop flower service first */ >> nfp_flower_service_stop(app_fw_flower); >> >> + /* Disable cpp service if need */ >> + nfp_service_disable(&pf_dev->cpp_service_info); >> + >> /* Now it is safe to free all PF resources */ >> nfp_uninit_app_fw_flower(pf_dev); >> nfp_pf_uninit(pf_dev); >