From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,
<stable@dpdk.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [PATCH 12/12] test/ipsec: fix build with GCC 12
Date: Thu, 2 Jun 2022 19:41:48 +0100 [thread overview]
Message-ID: <ccefe759-73db-9655-ed7a-0f4cc8b80556@intel.com> (raw)
In-Reply-To: <20220518101657.1230416-13-david.marchand@redhat.com>
Hi David,
On 18/05/2022 11:16, David Marchand wrote:
> GCC 12 raises the following warning:
>
> In function ‘_mm256_loadu_si256’,
> inlined from ‘rte_mov32’ at
> ../lib/eal/x86/include/rte_memcpy.h:319:9,
> inlined from ‘rte_mov128’ at
> ../lib/eal/x86/include/rte_memcpy.h:344:2,
> inlined from ‘rte_memcpy_generic’ at
> ../lib/eal/x86/include/rte_memcpy.h:438:4,
> inlined from ‘rte_memcpy’ at
> ../lib/eal/x86/include/rte_memcpy.h:882:10,
> inlined from ‘setup_test_string.constprop’ at
> ../app/test/test_ipsec.c:572:4:
> /usr/lib/gcc/x86_64-redhat-linux/12/include/avxintrin.h:929:10: error:
> array subscript ‘__m256i_u[3]’ is partly outside array bounds of
> ‘const char[108]’ [-Werror=array-bounds]
> 929 | return *__P;
> | ^~~~
> ../app/test/test_ipsec.c: In function ‘setup_test_string.constprop’:
> ../app/test/test_ipsec.c:539:12: note: at offset 96 into object
> ‘null_plain_data’ of size 108
> 539 | const char null_plain_data[] =
> | ^~~~~~~~~~~~~~~
>
> Split copy request into copies of string lengths and remove unused
> blocksize.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> app/test/test_ipsec.c | 48 ++++++++++++++++++++++++++-----------------
> 1 file changed, 29 insertions(+), 19 deletions(-)
>
> diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
> index 8da025bf66..d7455fd021 100644
> --- a/app/test/test_ipsec.c
> +++ b/app/test/test_ipsec.c
> @@ -554,24 +554,28 @@ struct rte_ipv4_hdr ipv4_outer = {
> };
>
> static struct rte_mbuf *
> -setup_test_string(struct rte_mempool *mpool,
> - const char *string, size_t len, uint8_t blocksize)
> +setup_test_string(struct rte_mempool *mpool, const char *string,
> + size_t string_len, size_t len)
> {
> struct rte_mbuf *m = rte_pktmbuf_alloc(mpool);
> - size_t t_len = len - (blocksize ? (len % blocksize) : 0);
>
> if (m) {
> memset(m->buf_addr, 0, m->buf_len);
> - char *dst = rte_pktmbuf_append(m, t_len);
> + char *dst = rte_pktmbuf_append(m, len);
>
> if (!dst) {
> rte_pktmbuf_free(m);
> return NULL;
> }
> - if (string != NULL)
> - rte_memcpy(dst, string, t_len);
> - else
> - memset(dst, 0, t_len);
> + if (string != NULL) {
> + size_t off;
> +
> + for (off = 0; off + string_len < len; off += string_len)
I think it should be off + string_len <= len here, because otherwise, if
len is a multiple of string_len, the last ret_memcpy (after this loop)
will copy 0 bytes.
> + rte_memcpy(&dst[off], string, string_len);
> + rte_memcpy(&dst[off], string, len % string_len);
> + } else {
> + memset(dst, 0, len);
> + }
> }
>
> return m;
> @@ -1365,7 +1369,8 @@ test_ipsec_crypto_outb_burst_null_null(int i)
> /* Generate input mbuf data */
> for (j = 0; j < num_pkts && rc == 0; j++) {
> ut_params->ibuf[j] = setup_test_string(ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->ibuf[j] == NULL)
> rc = TEST_FAILED;
> else {
> @@ -1483,7 +1488,8 @@ test_ipsec_inline_crypto_inb_burst_null_null(int i)
> /* Generate test mbuf data */
> ut_params->obuf[j] = setup_test_string(
> ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->obuf[j] == NULL)
> rc = TEST_FAILED;
> }
> @@ -1551,16 +1557,17 @@ test_ipsec_inline_proto_inb_burst_null_null(int i)
>
> /* Generate inbound mbuf data */
> for (j = 0; j < num_pkts && rc == 0; j++) {
> - ut_params->ibuf[j] = setup_test_string(
> - ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + ut_params->ibuf[j] = setup_test_string(ts_params->mbuf_pool,
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->ibuf[j] == NULL)
> rc = TEST_FAILED;
> else {
> /* Generate test mbuf data */
> ut_params->obuf[j] = setup_test_string(
> ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->obuf[j] == NULL)
> rc = TEST_FAILED;
> }
> @@ -1660,7 +1667,8 @@ test_ipsec_inline_crypto_outb_burst_null_null(int i)
> /* Generate test mbuf data */
> for (j = 0; j < num_pkts && rc == 0; j++) {
> ut_params->ibuf[j] = setup_test_string(ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->ibuf[0] == NULL)
> rc = TEST_FAILED;
>
> @@ -1738,15 +1746,16 @@ test_ipsec_inline_proto_outb_burst_null_null(int i)
> /* Generate test mbuf data */
> for (j = 0; j < num_pkts && rc == 0; j++) {
> ut_params->ibuf[j] = setup_test_string(ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + null_plain_data, sizeof(null_plain_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->ibuf[0] == NULL)
> rc = TEST_FAILED;
>
> if (rc == 0) {
> /* Generate test tunneled mbuf data for comparison */
> ut_params->obuf[j] = setup_test_string(
> - ts_params->mbuf_pool,
> - null_plain_data, test_cfg[i].pkt_sz, 0);
> + ts_params->mbuf_pool, null_plain_data,
> + sizeof(null_plain_data), test_cfg[i].pkt_sz);
> if (ut_params->obuf[j] == NULL)
> rc = TEST_FAILED;
> }
> @@ -1815,7 +1824,8 @@ test_ipsec_lksd_proto_inb_burst_null_null(int i)
> for (j = 0; j < num_pkts && rc == 0; j++) {
> /* packet with sequence number 0 is invalid */
> ut_params->ibuf[j] = setup_test_string(ts_params->mbuf_pool,
> - null_encrypted_data, test_cfg[i].pkt_sz, 0);
> + null_encrypted_data, sizeof(null_encrypted_data),
> + test_cfg[i].pkt_sz);
> if (ut_params->ibuf[j] == NULL)
> rc = TEST_FAILED;
> }
--
Regards,
Vladimir
next prev parent reply other threads:[~2022-06-02 18:42 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220518101657.1230416-1-david.marchand@redhat.com>
2022-05-18 10:16 ` [PATCH 01/12] common/cpt: " David Marchand
2022-05-20 20:23 ` Stephen Hemminger
2022-06-10 13:11 ` David Marchand
2022-06-13 11:40 ` [EXT] " Ankur Dwivedi
2022-06-16 9:30 ` David Marchand
2022-06-16 11:59 ` Ankur Dwivedi
2022-05-18 10:16 ` [PATCH 02/12] crypto/cnxk: " David Marchand
2022-05-20 20:24 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 03/12] crypto/ipsec_mb: " David Marchand
2022-06-02 9:50 ` Bruce Richardson
2022-06-10 13:07 ` David Marchand
2022-06-11 15:34 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 04/12] net/ena: " David Marchand
2022-05-20 20:28 ` Stephen Hemminger
2022-05-21 9:49 ` Morten Brørup
2022-05-21 16:23 ` Stephen Hemminger
2022-05-22 20:30 ` Morten Brørup
2022-06-11 15:34 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 05/12] net/enetfec: " David Marchand
2022-06-10 13:08 ` David Marchand
2022-06-13 5:22 ` Sachin Saxena (OSS)
2022-06-14 8:16 ` Sachin Saxena (OSS)
2022-06-11 15:35 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 06/12] net/ice: " David Marchand
2022-06-11 15:36 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 07/12] net/ice/base: " David Marchand
2022-05-18 10:16 ` [PATCH 08/12] net/qede/base: " David Marchand
2022-05-20 20:29 ` Stephen Hemminger
2022-06-21 23:17 ` Stephen Hemminger
2022-06-22 15:42 ` David Marchand
2022-05-18 10:16 ` [PATCH 09/12] vdpa/ifc: " David Marchand
2022-05-18 11:48 ` Wang, Xiao W
2022-06-11 15:36 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 10/12] vhost/crypto: " David Marchand
2022-06-02 10:08 ` Bruce Richardson
2022-06-14 9:22 ` David Marchand
2022-06-14 9:25 ` Bruce Richardson
2022-06-16 9:27 ` David Marchand
2022-06-11 15:36 ` Stephen Hemminger
2022-06-16 9:32 ` [PATCH v2] " David Marchand
2022-06-16 14:53 ` David Marchand
2022-05-18 10:16 ` [PATCH 11/12] app/flow-perf: " David Marchand
2022-06-02 10:21 ` Bruce Richardson
2022-06-08 9:03 ` Wisam Monther
2022-06-08 12:20 ` David Marchand
2022-06-13 7:49 ` Wisam Monther
2022-06-11 15:37 ` Stephen Hemminger
2022-05-18 10:16 ` [PATCH 12/12] test/ipsec: " David Marchand
2022-06-02 18:41 ` Medvedkin, Vladimir [this message]
2022-06-03 7:45 ` David Marchand
2022-06-03 7:56 ` Bruce Richardson
2022-06-03 9:41 ` David Marchand
2022-06-03 15:57 ` Medvedkin, Vladimir
2022-06-11 15:38 ` Stephen Hemminger
2022-06-16 9:33 ` [PATCH v2] " David Marchand
2022-06-17 12:06 ` David Marchand
2022-06-20 9:07 ` [EXT] " Akhil Goyal
2022-06-20 15:06 ` Medvedkin, Vladimir
2022-06-16 14:46 ` [PATCH v3] vhost/crypto: " David Marchand
2022-06-17 13:59 ` Maxime Coquelin
2022-06-21 9:31 ` Maxime Coquelin
2022-06-22 9:01 ` Poczatek, Jakub
2022-06-22 9:26 ` Zhang, Roy Fan
2022-06-22 14:07 ` David Marchand
2022-06-22 15:21 ` Poczatek, Jakub
2022-06-22 15:31 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccefe759-73db-9655-ed7a-0f4cc8b80556@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).