From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Chenxu Di <chenxux.di@intel.com>
Cc: Priyanka Jain <priyanka.jain@nxp.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3] net/dpaa2: fix build error about timesync functions
Date: Fri, 9 Oct 2020 12:22:41 +0100 [thread overview]
Message-ID: <cd94b515-2493-be53-ef95-1736c723cabd@intel.com> (raw)
In-Reply-To: <02d268fc-d039-13a0-366e-0e88d4b3bc1f@oss.nxp.com>
On 10/9/2020 8:48 AM, Sachin Saxena (OSS) wrote:
> On 08-Oct-20 6:42 PM, Ferruh Yigit wrote:
>> On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote:
>>
>> [please don't top post, I moved reply to down]
>>
>>>
>>> On 06-Oct-20 10:46 PM, Ferruh Yigit wrote:
>>>> From: Chenxu Di<chenxux.di@intel.com>
>>>>
>>>> Some timesync related source files are built only when
>>>> 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson.
>>>>
>>>> Building with '-DRTE_LIBRTE_IEEE1588' cflag will enable timesync
>>>> functionality in the files that are build, but it won't build files
>>>> that require 'RTE_LIBRTE_IEEE1588' config.
>>>> This causes the build error.
>>>>
>>>> Fixing by removing config check in meson file and build all .c files by
>>>> default, but wrap relevant code part with 'RTE_LIBRTE_IEEE1588' macro.
>>>>
>>>> Also removing 'RTE_LIBRTE_IEEE1588' ifdef around some fields of the data
>>>> structures, to not require finer grained macro wraps on the functions
>>>> using them.
>>>> Since the registration of the function disabled with macro check, having
>>>> functions compiled shouldn't affect the functionality.
>>>>
>>>> Fixes: 184c39d16568 ("net/dpaa2: add DPRTC sub-module")
>>>> Cc:stable@dpdk.org
>>>>
>>>> Signed-off-by: Chenxu Di<chenxux.di@intel.com>
>>>> Signed-off-by: Ferruh Yigit<ferruh.yigit@intel.com>
>
> Acked-by: Sachin Saxena<sachin.saxena@oss.nxp.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-09 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 2:40 [dpdk-stable] [PATCH] " Chenxu Di
2020-09-15 3:22 ` Hemant Agrawal
2020-09-16 5:12 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W
2020-09-16 15:29 ` [dpdk-stable] " Ferruh Yigit
2020-09-17 2:03 ` Di, ChenxuX
2020-09-17 11:38 ` Ferruh Yigit
2020-09-17 11:50 ` [dpdk-stable] [dpdk-dev] " Hemant Agrawal
2020-09-17 11:59 ` Ferruh Yigit
2020-09-17 15:40 ` Hemant Agrawal
2020-09-30 15:09 ` Ferruh Yigit
2020-09-17 8:43 ` [dpdk-stable] [PATCH v2] " Chenxu Di
2020-09-17 11:48 ` [dpdk-stable] [dpdk-dev] " Hemant Agrawal
2020-10-06 17:16 ` [dpdk-stable] [PATCH v3] " Ferruh Yigit
2020-10-08 2:24 ` Sachin Saxena (OSS)
2020-10-08 13:12 ` Ferruh Yigit
2020-10-09 7:48 ` Sachin Saxena (OSS)
2020-10-09 11:22 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd94b515-2493-be53-ef95-1736c723cabd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).