From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A86B5A04BC for ; Fri, 9 Oct 2020 13:22:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 763181D502; Fri, 9 Oct 2020 13:22:52 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 18BEC1D502; Fri, 9 Oct 2020 13:22:48 +0200 (CEST) IronPort-SDR: uxe9BAIu96R9YAd4PW4GO8JaDpHVvP5Gj/NgI5V11mTpVQYCYi6Wf++g+9Of1xEWKqrhmHR3yj jfHO8NKhNL4w== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="229656763" X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="229656763" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 04:22:46 -0700 IronPort-SDR: nyUu4V4bb5X4K3M9QHOt8U9b4Jg6rdRtGeLwb22tp0/HoyqPbjDeY1+L6+aDd2uAuaTYtsVjru 3rdmlpxNBolA== X-IronPort-AV: E=Sophos;i="5.77,354,1596524400"; d="scan'208";a="462155370" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.18.7]) ([10.252.18.7]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 04:22:45 -0700 To: "Sachin Saxena (OSS)" , Hemant Agrawal , Chenxu Di Cc: Priyanka Jain , dev@dpdk.org, stable@dpdk.org References: <20200917084357.14717-1-chenxux.di@intel.com> <20201006171638.2636145-1-ferruh.yigit@intel.com> <99c18cb1-855b-f034-ede7-4f9686d80110@intel.com> <02d268fc-d039-13a0-366e-0e88d4b3bc1f@oss.nxp.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Oct 2020 12:22:41 +0100 MIME-Version: 1.0 In-Reply-To: <02d268fc-d039-13a0-366e-0e88d4b3bc1f@oss.nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v3] net/dpaa2: fix build error about timesync functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/9/2020 8:48 AM, Sachin Saxena (OSS) wrote: > On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: >> On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: >> >> [please don't top post, I moved reply to down] >> >>> >>> On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: >>>> From: Chenxu Di >>>> >>>> Some timesync related source files are built only when >>>> 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson. >>>> >>>> Building with '-DRTE_LIBRTE_IEEE1588' cflag will enable timesync >>>> functionality in the files that are build, but it won't build files >>>> that require 'RTE_LIBRTE_IEEE1588' config. >>>> This causes the build error. >>>> >>>> Fixing by removing config check in meson file and build all .c files by >>>> default, but wrap relevant code part with 'RTE_LIBRTE_IEEE1588' macro. >>>> >>>> Also removing 'RTE_LIBRTE_IEEE1588' ifdef around some fields of the data >>>> structures, to not require finer grained macro wraps on the functions >>>> using them. >>>> Since the registration of the function disabled with macro check, having >>>> functions compiled shouldn't affect the functionality. >>>> >>>> Fixes: 184c39d16568 ("net/dpaa2: add DPRTC sub-module") >>>> Cc:stable@dpdk.org >>>> >>>> Signed-off-by: Chenxu Di >>>> Signed-off-by: Ferruh Yigit > > Acked-by: Sachin Saxena > Applied to dpdk-next-net/main, thanks.