From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Vipin Varghese" <vipin.varghese@amd.com>,
dev@dpdk.org, stable@dpdk.org, honest.jiang@foxmail.com
Cc: Thiyagrajan P <thiyagarajan.p@amd.com>
Subject: Re: [PATCH] app/dma-perf: replace pktmbuf with mempool objects
Date: Tue, 12 Dec 2023 14:38:09 +0000 [thread overview]
Message-ID: <cda38f30-dbe6-4628-87d5-2677675d2e4e@amd.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F0BF@smartserver.smartshare.dk>
On 12/12/2023 11:40 AM, Morten Brørup wrote:
>> From: Vipin Varghese [mailto:vipin.varghese@amd.com]
>> Sent: Tuesday, 12 December 2023 11.38
>>
>> Replace pktmbuf pool with mempool, this allows increase in MOPS
>> especially in lower buffer size. Using Mempool, allows to reduce
>> the extra CPU cycles.
>
> I get the point of this change: It tests the performance of copying raw memory objects using respectively rte_memcpy and DMA, without the mbuf indirection overhead.
>
> However, I still consider the existing test relevant: The performance of copying packets using respectively rte_memcpy and DMA.
>
This is DMA performance test application and packets are not used, using
pktmbuf just introduces overhead to the main focus of the application.
I am not sure if pktmuf selected intentionally for this test
application, but I assume it is there because of historical reasons.
> So, instead of replacing mbufs with mempool objects, please add new test variants using mempool objects.
>
next prev parent reply other threads:[~2023-12-12 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 10:37 Vipin Varghese
2023-12-12 11:40 ` Morten Brørup
2023-12-12 14:38 ` Ferruh Yigit [this message]
2023-12-12 15:16 ` Morten Brørup
2023-12-12 15:37 ` Bruce Richardson
2023-12-12 17:13 ` Varghese, Vipin
2023-12-12 18:09 ` Morten Brørup
2023-12-12 18:13 ` Varghese, Vipin
2023-12-20 9:17 ` Varghese, Vipin
2023-12-20 9:21 ` David Marchand
2023-12-19 16:35 Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda38f30-dbe6-4628-87d5-2677675d2e4e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=honest.jiang@foxmail.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thiyagarajan.p@amd.com \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).