patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] fbarray: fix uninitialized variable usage
@ 2021-02-19 17:54 Anatoly Burakov
  2021-03-03  8:17 ` [dpdk-stable] [dpdk-dev] " David Marchand
  2021-03-04 10:39 ` David Marchand
  0 siblings, 2 replies; 6+ messages in thread
From: Anatoly Burakov @ 2021-02-19 17:54 UTC (permalink / raw)
  To: dev; +Cc: stable

When file truncation fails, the log message attempts to print a path of
file we failed to truncate, but this path was never set to anything and,
what's worse, was uninitialized. Fix it by passing path from the caller.

Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: stable@dpdk.org
Coverity ID: 366122

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_fbarray.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
index d974f3dab7..592ec58594 100644
--- a/lib/librte_eal/common/eal_common_fbarray.c
+++ b/lib/librte_eal/common/eal_common_fbarray.c
@@ -81,9 +81,8 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len)
 }
 
 static int
-resize_and_map(int fd, void *addr, size_t len)
+resize_and_map(int fd, const char *path, void *addr, size_t len)
 {
-	char path[PATH_MAX];
 	void *map_addr;
 
 	if (eal_file_truncate(fd, len)) {
@@ -792,7 +791,7 @@ rte_fbarray_init(struct rte_fbarray *arr, const char *name, unsigned int len,
 		if (eal_file_lock(fd, EAL_FLOCK_SHARED, EAL_FLOCK_RETURN))
 			goto fail;
 
-		if (resize_and_map(fd, data, mmap_len))
+		if (resize_and_map(fd, path, data, mmap_len))
 			goto fail;
 	}
 	ma->addr = data;
@@ -895,7 +894,7 @@ rte_fbarray_attach(struct rte_fbarray *arr)
 	if (eal_file_lock(fd, EAL_FLOCK_SHARED, EAL_FLOCK_RETURN))
 		goto fail;
 
-	if (resize_and_map(fd, data, mmap_len))
+	if (resize_and_map(fd, path, data, mmap_len))
 		goto fail;
 
 	/* store our new memory area */
-- 
2.25.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
  2021-02-19 17:54 [dpdk-stable] [PATCH] fbarray: fix uninitialized variable usage Anatoly Burakov
@ 2021-03-03  8:17 ` David Marchand
  2021-03-03  8:30   ` Andrew Rybchenko
  2021-03-03 14:43   ` Andrew Boyer
  2021-03-04 10:39 ` David Marchand
  1 sibling, 2 replies; 6+ messages in thread
From: David Marchand @ 2021-03-03  8:17 UTC (permalink / raw)
  To: Anatoly Burakov, Andrew Rybchenko; +Cc: dev, dpdk stable

On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> When file truncation fails, the log message attempts to print a path of
> file we failed to truncate, but this path was never set to anything and,
> what's worse, was uninitialized. Fix it by passing path from the caller.
>
> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> Cc: stable@dpdk.org
> Coverity ID: 366122
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Andrew had reported it too, and proposed something close:
http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/

I prefer Anatoly's version.
If no one objects, I'll proceed with this one.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
  2021-03-03  8:17 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2021-03-03  8:30   ` Andrew Rybchenko
  2021-03-03  8:35     ` David Marchand
  2021-03-03 14:43   ` Andrew Boyer
  1 sibling, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2021-03-03  8:30 UTC (permalink / raw)
  To: David Marchand, Anatoly Burakov, Andrew Boyer; +Cc: dev, dpdk stable

On 3/3/21 11:17 AM, David Marchand wrote:
> On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> When file truncation fails, the log message attempts to print a path of
>> file we failed to truncate, but this path was never set to anything and,
>> what's worse, was uninitialized. Fix it by passing path from the caller.
>>
>> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
>> Cc: stable@dpdk.org
>> Coverity ID: 366122
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Andrew had reported it too, and proposed something close:
> http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/

Not me, adding Andrew B. to recipients list

> I prefer Anatoly's version.
> If no one objects, I'll proceed with this one.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
  2021-03-03  8:30   ` Andrew Rybchenko
@ 2021-03-03  8:35     ` David Marchand
  0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2021-03-03  8:35 UTC (permalink / raw)
  To: Andrew Rybchenko; +Cc: Anatoly Burakov, Andrew Boyer, dev, dpdk stable

On Wed, Mar 3, 2021 at 9:31 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 3/3/21 11:17 AM, David Marchand wrote:
> > On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
> > <anatoly.burakov@intel.com> wrote:
> >>
> >> When file truncation fails, the log message attempts to print a path of
> >> file we failed to truncate, but this path was never set to anything and,
> >> what's worse, was uninitialized. Fix it by passing path from the caller.
> >>
> >> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> >> Cc: stable@dpdk.org
> >> Coverity ID: 366122
> >>
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >
> > Andrew had reported it too, and proposed something close:
> > http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/
>
> Not me, adding Andrew B. to recipients list

That's gmail completion fault!
/me hides

Thanks Andrew R.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
  2021-03-03  8:17 ` [dpdk-stable] [dpdk-dev] " David Marchand
  2021-03-03  8:30   ` Andrew Rybchenko
@ 2021-03-03 14:43   ` Andrew Boyer
  1 sibling, 0 replies; 6+ messages in thread
From: Andrew Boyer @ 2021-03-03 14:43 UTC (permalink / raw)
  To: David Marchand; +Cc: Anatoly Burakov, Andrew Rybchenko, dev, dpdk stable



> On Mar 3, 2021, at 3:17 AM, David Marchand <david.marchand@redhat.com> wrote:
> 
> On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>> 
>> When file truncation fails, the log message attempts to print a path of
>> file we failed to truncate, but this path was never set to anything and,
>> what's worse, was uninitialized. Fix it by passing path from the caller.
>> 
>> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
>> Cc: stable@dpdk.org
>> Coverity ID: 366122
>> 
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Andrew had reported it too, and proposed something close:
> http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/
> 
> I prefer Anatoly's version.
> If no one objects, I'll proceed with this one.
> 
> 
> -- 
> David Marchand
> 

Fine with me

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
  2021-02-19 17:54 [dpdk-stable] [PATCH] fbarray: fix uninitialized variable usage Anatoly Burakov
  2021-03-03  8:17 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2021-03-04 10:39 ` David Marchand
  1 sibling, 0 replies; 6+ messages in thread
From: David Marchand @ 2021-03-04 10:39 UTC (permalink / raw)
  To: Anatoly Burakov; +Cc: dev, dpdk stable, Andrew Boyer

On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> When file truncation fails, the log message attempts to print a path of
> file we failed to truncate, but this path was never set to anything and,
> what's worse, was uninitialized. Fix it by passing path from the caller.
>

Coverity issue: 366122
> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> Cc: stable@dpdk.org

Reported-by: Andrew Boyer <aboyer@pensando.io>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>


Applied, thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-04 10:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 17:54 [dpdk-stable] [PATCH] fbarray: fix uninitialized variable usage Anatoly Burakov
2021-03-03  8:17 ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-03-03  8:30   ` Andrew Rybchenko
2021-03-03  8:35     ` David Marchand
2021-03-03 14:43   ` Andrew Boyer
2021-03-04 10:39 ` David Marchand

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git