From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH 2/2] net/txgbe: fix debug log
Date: Mon, 21 Feb 2022 13:10:00 +0000 [thread overview]
Message-ID: <cfd3179c-7408-5240-823f-35172d089197@intel.com> (raw)
In-Reply-To: <20220221092121.2145802-3-jiawenwu@trustnetic.com>
On 2/21/2022 9:21 AM, Jiawen Wu wrote:
> diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h
> index 67e9bfb3af..38c5d05984 100644
> --- a/drivers/net/txgbe/txgbe_logs.h
> +++ b/drivers/net/txgbe/txgbe_logs.h
> @@ -48,11 +48,8 @@ extern int txgbe_logtype_tx_free;
> #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
> #endif
>
> -#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args)
> -
> -#define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args)
> -#define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(" >>")
> -#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt)
> +#define DEBUGOUT(fmt, args...) PMD_DRV_LOG(fmt, ##args)
> +#define PMD_INIT_FUNC_TRACE() PMD_DRV_LOG(" >>")
>
Hi Jiawen,
This won't work, macros are missing the log type.
I guess intention is to change as done in ngbe patch [1].
I wonder if you send the patches even without compiling them?
Expectation is authors test the patches before sending them out!
[1]
PMD_DRV_LOG(DEBUG, fmt, ##args)
next prev parent reply other threads:[~2022-02-21 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220221092121.2145802-1-jiawenwu@trustnetic.com>
2022-02-21 9:21 ` [PATCH 1/2] net/ngbe: " Jiawen Wu
2022-02-21 13:06 ` Ferruh Yigit
2022-02-21 9:21 ` [PATCH 2/2] net/txgbe: " Jiawen Wu
2022-02-21 13:10 ` Ferruh Yigit [this message]
2022-02-22 2:03 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd3179c-7408-5240-823f-35172d089197@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).