From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "stable@dpdk.org" <stable@dpdk.org>,
"ktraynor@redhat.com" <ktraynor@redhat.com>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>
Subject: [dpdk-stable] [PATCH v2 18.11 07/10] net/atlantic: bad logic with offsets talking with firmware
Date: Tue, 21 May 2019 08:55:34 +0000 [thread overview]
Message-ID: <d0801971b66454161a50e130b96ea0a92fb7b4d0.1558426315.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1558426315.git.igor.russkikh@aquantia.com>
From: Pavel Belous <pavel.belous@aquantia.com>
eeprom write accesses start using non zero configuration memory
accesses. This revealed an issue where firmware interface was actually
always did the uploads starting with zero offset
Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations")
cc: stable@dpdk.org
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>
---
drivers/net/atlantic/hw_atl/hw_atl_utils.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index bb5c6ed1512e..262601941d47 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
@@ -333,12 +333,13 @@ int hw_atl_utils_fw_upload_dwords(struct aq_hw_s *self, u32 a, u32 *p,
goto err_exit;
}
if (IS_CHIP_FEATURE(REVISION_B1)) {
- u32 offset = 0;
+ u32 mbox_offset = (a - self->rpc_addr) / sizeof(u32);
+ u32 data_offset = 0;
- for (; offset < cnt; ++offset) {
- aq_hw_write_reg(self, 0x328, p[offset]);
+ for (; data_offset < cnt; ++mbox_offset, ++data_offset) {
+ aq_hw_write_reg(self, 0x328, p[data_offset]);
aq_hw_write_reg(self, 0x32C,
- (0x80000000 | (0xFFFF & (offset * 4))));
+ (0x80000000 | (0xFFFF & (mbox_offset * 4))));
hw_atl_mcp_up_force_intr_set(self, 1);
/* 1000 times by 10us = 10ms */
AQ_HW_WAIT_FOR((aq_hw_read_reg(self,
--
2.17.1
next prev parent reply other threads:[~2019-05-21 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 8:55 [dpdk-stable] [PATCH v2 18.11 00/10] Aquantia atlantic bugfixes Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 01/10] net/atlantic: enable broadcast traffic Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 02/10] net/atlantic: extra line at eof Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 03/10] net/atlantic: error handling for mailbox access Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 04/10] net/atlantic: eeprom get/set should consider offset Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 05/10] net/atlantic: fix max eeprom size Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 06/10] net/atlantic: validity check for eeprom dev address Igor Russkikh
2019-05-21 8:55 ` Igor Russkikh [this message]
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 08/10] net/atlantic: flow control settings synchronization on rx Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 09/10] net/atlantic: use capability bits to detect eeprom access Igor Russkikh
2019-05-21 8:55 ` [dpdk-stable] [PATCH v2 18.11 10/10] net/atlantic: eliminate excessive log levels on Rx/Tx Igor Russkikh
2019-05-21 12:55 ` [dpdk-stable] [PATCH v2 18.11 00/10] Aquantia atlantic bugfixes Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0801971b66454161a50e130b96ea0a92fb7b4d0.1558426315.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).