From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 761D6A04A8 for <public@inbox.dpdk.org>; Mon, 7 Feb 2022 17:04:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 674DB410FF; Mon, 7 Feb 2022 17:04:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id A91FD410EA; Mon, 7 Feb 2022 17:04:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644249877; x=1675785877; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=WCra2N8Svr5sVNK/pFQB6G/21gDmgRQ6DBEOeOiTEno=; b=Yi1H4dpbcZoEVxgtCc4vC7Q3n10GVMLQJzlrcZT+FKoSxe6kOIv+kuDo yzIKCDCqxoplnwrTyzx2HNuhtk9Sp0OH2vcuzUvTmB27WlV5pqpexSKVc 3bFGhFb+ugBZiYmGSwt7KEChoQeu7zjWbae6p9BSEFZ2gvGz6HruFvber LMY+MDhiilljaTUEOdlHosaQbzcPxkrk31RucHWTMcxac3PyghCbvdYYh K+6Ds+fBYX4zc3Vxf6DcnhEW9aTC5IT6gk414QG6qbsM7781ksca2hDPR F9GXftl6VEh38DW9BotHYRbsnYmuryoBn3KVv1yBZgtEd/GUmc5roaDPr w==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="309488627" X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="309488627" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 08:04:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="584873715" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 07 Feb 2022 08:04:35 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 08:04:35 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 08:04:35 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 08:04:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EjTLudJr+mcZ4SqouO47rDf9uBldbqoZ+0TlAQnPcnwp8RPf2cxOHD3DJ5jSwfPd5E5hpw9I8bTwL1VXyDV26KQkuMaY1KD7odG9YuH/cixDZlRYubix+KeY5n6C+I6UtQkINKdz3F7u2sO7sviKlOLpWO7JrOSmcys+C29dF6/SUlYAi/MD5pTO3iI8De0EkVvNG9ZjwMFmoYMfATgllM4Cr4cZPsFyjMcU1EwA9Ny03TRiMlDs5OxrFs60ZaKXu1yTd6LIzmGeQvR4CnyJT/rGJESKFzru1tWyb4PXL2cJ3xUFvkoVj44/F2h4wblUiYFhysyZPPCeYjXHQFC+Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hqlh5mymYYgvflaEP+sWFki1whhcGD4bSpDZ/usL4Yw=; b=FX+cjuILLm947fHyohUDLfSKX71i3jiYcPCKTpv87GTkWqRldDKgdYJR4PoZ9xHMliPsR2HEzfhjFNpsBe/bvj63Y9cUKvtz3InSAV4vyQSTlQ1i+AcyrArMF7oslr70P53iWHW4o2qc8GehMHKs/EXI0J3EolMea75bm+iPQYx31Iv8kqqisFR0D9GI8ALMTY2UQp2E65Rz5D/1aZD/lIba5gF1XZoGLTnNIg4utimOD1phnNm/Ftk9NZPA4EYxXCtjMceSuKy/niuUo8Qm8py4UWvpUqJtqguCOwKqIt/H63eMTFmDTI70GoCm3adgzrXh9FP3hg1YY+OZ8TWipw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR1101MB2287.namprd11.prod.outlook.com (2603:10b6:301:4e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Mon, 7 Feb 2022 16:04:31 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 16:04:31 +0000 Message-ID: <d109bd24-59a2-677c-08fe-64ec8ef677ce@intel.com> Date: Mon, 7 Feb 2022 16:04:25 +0000 Content-Language: en-US To: "Wang, Haiyue" <haiyue.wang@intel.com>, "stephend@silicom-usa.com" <stephend@silicom-usa.com>, =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Wang, Wen" <wenw@silicom-usa.com>, "stable@dpdk.org" <stable@dpdk.org> References: <20211206221922.644187-1-stephend@silicom-usa.com> <20211206221922.644187-4-stephend@silicom-usa.com> <BYAPR11MB349569C90D97F3E3C6B89480F77B9@BYAPR11MB3495.namprd11.prod.outlook.com> <d14039a7-88c2-083a-e484-be29eeeb6dd1@silicom-usa.com> <BYAPR11MB34957184FD7BED1AE8BD286FF77C9@BYAPR11MB3495.namprd11.prod.outlook.com> <98CBD80474FA8B44BF855DF32C47DC35D86D8B@smartserver.smartshare.dk> <BYAPR11MB3495CBCD530B3053A4A9B956F77D9@BYAPR11MB3495.namprd11.prod.outlook.com> <98CBD80474FA8B44BF855DF32C47DC35D86D9B@smartserver.smartshare.dk> <BYAPR11MB3495D39F065F0A328613607EF77D9@BYAPR11MB3495.namprd11.prod.outlook.com> <cb07809f-4a1a-8e9f-7a43-c1fda47b203a@silicom-usa.com> <BL0PR11MB34909A0C6BC926BAC7BB3F06F77E9@BL0PR11MB3490.namprd11.prod.outlook.com> <0f4a78d5-df1d-fea7-6e5c-15ea07d80886@silicom-usa.com> <BYAPR11MB3495E9B5DBE0A4B14CE6F8BEF7599@BYAPR11MB3495.namprd11.prod.outlook.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write X-User: ferruhy In-Reply-To: <BYAPR11MB3495E9B5DBE0A4B14CE6F8BEF7599@BYAPR11MB3495.namprd11.prod.outlook.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0065.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7777c788-3535-48bb-5d8a-08d9ea538694 X-MS-TrafficTypeDiagnostic: MWHPR1101MB2287:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: <MWHPR1101MB22871C96985438F4FE91CA07952C9@MWHPR1101MB2287.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v3INez2pJEN9ArA5Tvy6XvUq2PTrux+/fxzHyyZ1XBUSEEXCB1xdxKcXO341+WsJbJb79DQLXkk86E3fPOAKmyTYZfapSDbIBNb+Ey3UI4C7HygCqiYQLTRXXDX4iF3yictpFB8jvQUEFtrzMN9+FU2Uh4rrUKMfu++EWweaSWAr2tB0BlZpknMiTBlgnxzYOmi+T/bAXCvkwJYnrRpCVcQHQ0d8GI38i8+IqrQhCvOaaNdMfPD+fHH5FKLyIeFIIxa64y2/UFbo+Z/JUS7TzDc96pgVuVuyBvk+7M0NMZ2V/UxZg6IufVVEFTpwXMyxaFX5r3aEzXfG15e/M60dSnzGxaZ3BmS+bfX3d8CBootFIwBDkvQ1/NqGQTIV4lkDEoA/FjBfydQyCcfcojVJ1zqWvC+wmtRs0UHFgU82morexwL8dP5T+Cmz7D95fpwKlQJtuedYlluzNonABu6eb4oH29j490N8EG/huOpDQ4BtYYjv+LJf2juLDc1wEd9HFPJXkigDKThvEQ8UR4ODhVUSOLfThl0NQhOzwQiBjzMiF5sNFIsJ0Wd4x+LPYJjFfdmvAcTjVpbGxx0eRIKQjX7Vu83GT6WFTmlj6lri6JhVAo+Oaxgu/kTObTPBiltJiehWQkP1srCR+Va9mN2GApBs40Ce36hV3T0V+g19o89w3R7e/5BivEyZGg+P2jzgZmlWD6N8vlIWmJe0xkki3Y0MJDhfm+As2LGxNW1K4fA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(66574015)(6486002)(44832011)(31686004)(2616005)(31696002)(53546011)(55236004)(66556008)(66476007)(66946007)(8936002)(4326008)(508600001)(2906002)(26005)(8676002)(186003)(6506007)(6636002)(6666004)(38100700002)(921005)(36756003)(316002)(86362001)(82960400001)(6512007)(110136005)(83380400001)(54906003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Myt5STFHbEpyb1NQNEFNWk96cmFFSE9ZbEdCdElrMDhJU2wxVDdRZXpCUUpH?= =?utf-8?B?R2d6UnZ4TC9mRG9TeXpmaDg0Mk1LMDArYS9JSjJOQ3RBZ3YydmxSVEpreUFO?= =?utf-8?B?RkxNazcxWUJBU1VUa0RvTkNZbTVKUFNZWU5sSzh2Vk9HWmk1OWdDQUNIdkQ0?= =?utf-8?B?aE5IRlhWTk9nOVFqM2ZnM0NkbFpGeUExR3NTOUdMa2NjWE00eXZOcHVlWFRY?= =?utf-8?B?QXQ0N2NkZjlsQjRiY3FFYXpldkFxa0xwOUkrWUFteXVrWEllaWVCYnJ0T0ho?= =?utf-8?B?WHhyd0c5L2VaaU4xdDl4WndHYmV5SVV4M1FZQlNSVUI5Tlk2QnltRk5oSGJj?= =?utf-8?B?aEdlZHBBWHpzRjh6aythVGNaUFJNZHdtWklCbkgzS3I4S3psNlM3WnRwSE1M?= =?utf-8?B?Uzc1bWs1OWtiRElYNTJXc0JkeDRETUxTK0YzN2xzcDV1endpZVRBM0hIUS9Y?= =?utf-8?B?TmV3Wm53aFhUa2NmcmNBYVN5T3RsZHBvR3pJRGdubkpYcjdGVmxjTGhyY0pj?= =?utf-8?B?enRNdkQ1QjJwZldxQWtsZ2RxM0NoY1RqdGVIa1MveU1CeFdzYlVzZTBzRFdM?= =?utf-8?B?ZWVGeWlSK3lzdWc5aHdGbnVhMmxjSE5vSW02OGVjL29HdDUzZXljZnR2cnFB?= =?utf-8?B?dXlhM0VuM0ljRXRKOStmem1tVE4zcWhrV2JxQnp6ZHdSMS9obC9xVlpCQUdQ?= =?utf-8?B?YnFSUmN3T2FaRzRZcWRxQk5CWWJVUGgya1l5QTNNMnYyWko4RElVTzd3RGdO?= =?utf-8?B?bDBVMXhlamFzL0FRVjNJY09MZGJJaWQyNWlxNm5UdUJKOFp0L25oaUNRYlda?= =?utf-8?B?Nlk0VzJKb0tudUJvU1dkMjlZU1NmaUo2ayttYWpvNlE2eFRtV0wzdTZxeFFr?= =?utf-8?B?TkFvQzVtSmdnUFFrVDlSdFllVGJ1VGh1YXZUVU8wejRYZU14OG4xWHZxVUJQ?= =?utf-8?B?YVlGZnJvWFhkZk03UzR5aHlMRHpYcnpVSHd2WjF1aEUxTHlUa25WdWl6N0ZU?= =?utf-8?B?a1V3OG9YT3phNURlNENiOHo5M21lRHdlTXRQNnFmVHllY255YzF4S3RvQzhS?= =?utf-8?B?T0llTnBzNGl0aW53cjJHSWZmUkFYY0VGV0I4ZmpxbkdCWFFKYmtONmFCTjI4?= =?utf-8?B?TFBhb2RCKzhKZFVMNlRiVVpVd3ZRSGVpd0JGQ2dZZFdWSTA4VjYwVTF4VkVi?= =?utf-8?B?ZW0vTTZmNGwwclJXTVJqUFYyM2xIWkMydWRzSkVwN29ZV21pMzRtTDkrdGZj?= =?utf-8?B?V1BhNjNRN2dLWWFENzJ6aGFCMkYyS1RFeTZLUy9sRnUzemhXZ21LeG13SlBw?= =?utf-8?B?THFPZmtKbndDKzlEeXNBejFtSzd2MVptaGZRMklkNkJnbzJVUncxYXdmR29q?= =?utf-8?B?S3pvYXRCUDNVamplUGtUdFV4VmJGNlFEYm54dlJ1aFJjV3Z0QlBpNkRFUlE4?= =?utf-8?B?eUhTUUJ6QlJYNk5SZ1NYeldqemoraTlEdlMxSmtMMUNoaXlhWGZRSUJsVGRx?= =?utf-8?B?amVOS2UyeXNqL1VQdUlnMVA1TmpNV093djU3RFZ4bzV3K2N3NTdFUmhKMDdS?= =?utf-8?B?ZUNEb2E1Q2d0cGd6RnJoL0ZZMmNjZWdVdTlRSS9JaEYzRTRrMUFTYktzc2cv?= =?utf-8?B?WmM0UlFWTVZuQjIwZFJjaGdVeEI3QWRTRFBoOFkyTHFTVDN4UklmakxvVzBr?= =?utf-8?B?SUhtTlhSNy9XOEc1eS9jQkFDY0h6YmR4VEQyYXJ5bHNLUTluQWNNTFVWSUJk?= =?utf-8?B?ZnVNdXJwLzMzM21JS3FOT3Z6WmJ1NmpqVmM1bG5YcStBY2RJTWRhRm5Sa0hw?= =?utf-8?B?bzJnbTU3dUs2cllwc2lFR3RFaFdZSkFqbGdCQUNSMldNTFdUWnZkeTJyNXV1?= =?utf-8?B?cWxPZG5iRWhvazdBdTNSaXFkamFVRlp1K2s4STZiTWhqbHRzOGtJRWpKbUZK?= =?utf-8?B?dngzMkZTeGo1UVBTODhCWmI5blBiNDhWMThPbTZQUUF5ak5CeHVUYzY1SWNp?= =?utf-8?B?YkorYUJlVndGMUhhbXVzamQwc0djQ2doeWdTWlRlS2c5NnEwckhSRm5uVnJl?= =?utf-8?B?Ym4zTkgwNlhUQU52QXZqK0xVRWRKNmRQeTJDYTdxWHlZSUpiVWtGZzFrY2dk?= =?utf-8?B?UkFZYTk4a08vSlFadXQ0eXhNaTNsWmgwdnFvMHdFZ0tBSmtHQ2hRcGlRcGwz?= =?utf-8?Q?N5SJtAvxhdemaTgkenOPR3s=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7777c788-3535-48bb-5d8a-08d9ea538694 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2022 16:04:31.3209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VxxAcnVSwMC71AGqdz0I1tjctCBADln41RHFQeuyk7Yw4eROaUw8ktgVRJiOutlmbKJYGkw/oN5Gb8jHkz7UMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2287 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org On 1/19/2022 12:31 AM, Wang, Haiyue wrote: >> -----Original Message----- >> From: Stephen Douthit <stephend@silicom-usa.com> >> Sent: Wednesday, January 19, 2022 05:06 >> To: Wang, Haiyue <haiyue.wang@intel.com>; Morten Brørup <mb@smartsharesystems.com>; Lu, Wenzhuo >> <wenzhuo.lu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com> >> Cc: dev@dpdk.org; Wang, Wen <wenw@silicom-usa.com>; stable@dpdk.org >> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write >> >> On 12/22/21 19:55, Wang, Haiyue wrote: >>> OK, let's see in 2022, happy holidays. ;-) >> >> A bit of a slower start to 2022 than I had hoped, but I have a v3 of the >> hotplug fix in progress. It's now working for the 82599 and C3000 ixgbe >> devices under Linux, and I'm in the process of getting this built and >> tested under FreeBSD. >> >> Assuming the FreeBSD testing comes together smoothly my plan is to split >> these patches into three series: >> >> 1) The SFP hotplug fix >> 2) Refactor SDP3 TX_DISABLE 82599 link check stuff >> 3) Support of additional SFP types under ixgbe >> >> My focus right now is on the SFP hotplug fix, so please let me know if >> there's any additional feedback on that portion of the original series. >> >> Right now the feedback I have that impacts the hotplug fix is a cleanup >> for patch 1, and the general comment that changes to files under >> ixgbe/base are usually backported from Linux, and so I should refactor >> my changes to live in ixgbe_ethdev.c > > Yeah, just put the change in base code to *separate patch*, so that they are > easily to be reviewed, thanks. > Hi Steve, Wen, Haiyue, Can you please clarify the above change request? I though it is related to splitting base code updates into their own patches, but that already seems the case in set (except from a few minor mix). And what is the status, is there a new version worked on? Or is the set waiting for more review? Thanks, ferruh