From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 468EFA327F for ; Mon, 21 Oct 2019 19:30:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34C5A1BF44; Mon, 21 Oct 2019 19:30:49 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id AE8CF1BF44 for ; Mon, 21 Oct 2019 19:30:47 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id v9so3687608wrq.5 for ; Mon, 21 Oct 2019 10:30:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=OJtOEAZSCQIrLpSVUqSEl5jw7YrWtmqtnLyaM1E7Fis=; b=EoLaX7DJo2TexGSyNACTMEDD+td7Acfr+VxLqOCl6nYNc6qK8jNyK4rEzsNIrKAolJ 0W1dgzXY3Bxoa1dTY1KzT/5ShJj3j/SaYnfgmm92jSLieUi4V2H6ZjVLhffI1IDG4dqc 1zhRKkQJ9e+KRGV5uca2YYzCOe2sg0FjuZFWaw/gh8WyYpg3d4iYwWoTDpa9W2Mvpj7i gDeiaHoQdo3EF7SWsNkqpfJsypQ1SyhXQdC8cYhZdiAE6VZlx0qeYCqVt4deOSVzP7ed hU1nTGcsMzItWgYSoWDktbgasBHS1j8AFIY3yQnpe/MzWUxuaRZi1ixu86yxZGVIDtdi ovTw== X-Gm-Message-State: APjAAAVbB3ZHSLwiwg+J/8lWAg9sKbZzp0FYF/oWE6GE0s/zvEGnOMe0 bewMY+XuVaj8eSNV7P5nTkU36+nO X-Google-Smtp-Source: APXvYqzBhe2g7tLA1EgtDMST5N5Ak48lkOBGgh1lkWNxfyNZhqb3xhbj2gXqe9Av43FpekE83x0wQg== X-Received: by 2002:adf:e2cc:: with SMTP id d12mr21406094wrj.345.1571679047198; Mon, 21 Oct 2019 10:30:47 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id q124sm28483972wma.5.2019.10.21.10.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 10:30:46 -0700 (PDT) Message-ID: From: Luca Boccassi To: Christian Ehrhardt , dpdk stable Cc: Thomas Monjalon Date: Mon, 21 Oct 2019 18:30:45 +0100 In-Reply-To: <20191021111634.15500-1-christian.ehrhardt@canonical.com> References: <20191021111634.15500-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 0/3] kni: fix kernel 5.4 builds X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 2019-10-21 at 13:16 +0200, Christian Ehrhardt wrote: > Hi, > I've got a report [1] from our kernel Team which regularly pre-checks > new kernels ahead of time. All of this is about kni/ethtool failing > to > build with 5.4. >=20 > I know that going forward there is [2] so the master branch doesn't > care > anymore. >=20 > To be clear, Thomas was rather straight on this topic on IRC :-) > [11:18] cpaelzer: Drop KNI ethtool from your package! > [11:20] That's a lot easier than maintaining this... thing > [11:31] tmonjalo: that is true and correct for the future, > which also reflects what happened in master branch > [11:31] tmonjalo: but the past is the past and I guess I > need to fix it there > [11:34] cpaelzer: there is another way: drop it and wait > for requests ;) > [11:35] I'm not bold enough to do that > [11:35] but I already have it in the not officially > supported packages > [11:35] so I can worst case just stop caring, but then I > like to fix things ... >=20 > But I wondered if we should keep it a bit alive at least for a while > for > Distributions that carry it as package. Personally for Ubuntu that > would be > around the time of whatever kernel is recent April next year and > valid > for DPDK 17.11 and 18.11. But needs surely will differ for different > distributions. >=20 > Here is a patch series intended for stable releases only, tested with > kernel 5.3 (old behavior) and 5.4 (new behavior). We might want to > have > someone test other distros and other (older) kernels as well maybe? >=20 > I'm throwing in the patch series as suggestion for a fix, but it > might > as well be just the start for a discussion to document the projects > thoughts about released e.g. 17.11.x/18.11.x versions carrying that > package and how they are suggested to handle kni-ethtool being sort > of > unmaintainable. > I'll surely start that discussion with Luca for the Debian/Ubuntu > scope. >=20 > [1]:=20 > https://bugs.launchpad.net/ubuntu/eoan/+source/dpdk/+bug/1848585 >=20 > [2]:=20 > https://git.dpdk.org/dpdk/commit/?id=3Dea6b39b5 >=20 >=20 > Christian Ehrhardt (3): > kni: fix kernel 5.4 build - merged pci_aspm.h > kni: fix kernel 5.4 build - num_online_cpus > kni: fix kernel 5.4 build - skb_frag_t to bio_vec >=20 > kernel/linux/kni/ethtool/igb/igb_main.c | 12 ++++++++++-- > kernel/linux/kni/ethtool/igb/kcompat.h | 10 ++++++++-- > kernel/linux/kni/ethtool/ixgbe/kcompat.h | 10 ++++++++-- > 3 files changed, 26 insertions(+), 6 deletions(-) Series-acked-by: Luca Boccassi Given we are shipping with it we need to support it for the lifetime of the branches, so thanks for the patches. --=20 Kind regards, Luca Boccassi