From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 476FF41CEC for ; Mon, 20 Feb 2023 16:37:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33D5A43081; Mon, 20 Feb 2023 16:37:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8976C43088 for ; Mon, 20 Feb 2023 16:37:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676907474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bjb4TzJiaquvCz/JD+bXJnB0RSLTzU76E/0Ws4GGIr8=; b=hZYa1GuqsMNZv4FUkH7Zzd7Nk3BNUeseg5RAy9mRzEzW4pcYAazcZ+ycsLfbp6qZ7F9pzx LWazqJXw4u0g25tmtrgzzUsYOXQm+PpkxyM6uPOv2xvtAfjwGCGtIW4qtLmEJBrQQDQWG0 c6AbyrLmiFGHiNqEUJhwHZr3w6dHpcw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-prYA_NeuNIKLSyUIruInPQ-1; Mon, 20 Feb 2023 10:37:48 -0500 X-MC-Unique: prYA_NeuNIKLSyUIruInPQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 469763813F28; Mon, 20 Feb 2023 15:37:48 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A83C91121314; Mon, 20 Feb 2023 15:37:46 +0000 (UTC) Message-ID: Date: Mon, 20 Feb 2023 16:37:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/2] baseband/acc: fix check after deref and dead code To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, stable@dpdk.org References: <20230208020001.181055-1-hernan.vargas@intel.com> <20230208020001.181055-2-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230208020001.181055-2-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/8/23 03:00, Hernan Vargas wrote: > Fix potential issue of dereferencing a pointer before null check. > Remove null check for value that could never be null. > > Coverity issue: 381646, 381631 > Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 36f6fec5ad..baab459436 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > - if (q == NULL) > - return 0; > #ifdef RTE_LIBRTE_BBDEV_DEBUG > if (unlikely(ops == 0)) > return 0; Reviewed-by: Maxime Coquelin Thanks, Maxime