* [PATCH v2 1/2] baseband/acc: fix check after deref and dead code [not found] <20230208020001.181055-1-hernan.vargas@intel.com> @ 2023-02-08 2:00 ` Hernan Vargas 2023-02-20 15:37 ` Maxime Coquelin 0 siblings, 1 reply; 2+ messages in thread From: Hernan Vargas @ 2023-02-08 2:00 UTC (permalink / raw) To: dev, maxime.coquelin, gakhil, trix Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, Hernan Vargas, stable Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> --- drivers/baseband/acc/rte_acc100_pmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 36f6fec5ad..baab459436 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, int ret, cbm; struct rte_bbdev_enc_op *op; - if (q == NULL) - return 0; #ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely(ops == 0)) return 0; -- 2.37.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] baseband/acc: fix check after deref and dead code 2023-02-08 2:00 ` [PATCH v2 1/2] baseband/acc: fix check after deref and dead code Hernan Vargas @ 2023-02-20 15:37 ` Maxime Coquelin 0 siblings, 0 replies; 2+ messages in thread From: Maxime Coquelin @ 2023-02-20 15:37 UTC (permalink / raw) To: Hernan Vargas, dev, gakhil, trix Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, stable On 2/8/23 03:00, Hernan Vargas wrote: > Fix potential issue of dereferencing a pointer before null check. > Remove null check for value that could never be null. > > Coverity issue: 381646, 381631 > Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> > --- > drivers/baseband/acc/rte_acc100_pmd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 36f6fec5ad..baab459436 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > - if (q == NULL) > - return 0; > #ifdef RTE_LIBRTE_BBDEV_DEBUG > if (unlikely(ops == 0)) > return 0; Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 15:37 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230208020001.181055-1-hernan.vargas@intel.com> 2023-02-08 2:00 ` [PATCH v2 1/2] baseband/acc: fix check after deref and dead code Hernan Vargas 2023-02-20 15:37 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).