patches for DPDK stable branches
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Viacheslav Ovsiienko <viacheslavo@mellanox.com>, dev@dpdk.org
Cc: thomas@monjalon.net, declan.doherty@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] ethdev: fix switching domain allocation
Date: Tue, 14 Jan 2020 15:32:24 +0000
Message-ID: <d4bb1064-86e6-b536-3fc2-1901abe3df18@intel.com> (raw)
In-Reply-To: <1576759626-27977-1-git-send-email-viacheslavo@mellanox.com>

On 12/19/2019 12:47 PM, Viacheslav Ovsiienko wrote:
> The maximum amount of unique switching domain is supposed
> to be equal to RTE_MAX_ETHPORTS. The current implementation
> allows to allocate only RTE_MAX_ETHPORTS-1 domains.
> 
> Fixes: ce9250406323 ("ethdev: add switch domain allocator")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  lib/librte_ethdev/rte_ethdev.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 6e9cb24..4c2312c 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -5065,10 +5065,10 @@ enum rte_eth_switch_domain_state {
>  	*domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID;
>  
>  	for (i = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID + 1;
> -		i < RTE_MAX_ETHPORTS; i++) {
> -		if (rte_eth_switch_domains[i].state ==
> +		i <= RTE_MAX_ETHPORTS; i++) {
> +		if (rte_eth_switch_domains[i - 1].state ==
>  			RTE_ETH_SWITCH_DOMAIN_UNUSED) {
> -			rte_eth_switch_domains[i].state =
> +			rte_eth_switch_domains[i - 1].state =
>  				RTE_ETH_SWITCH_DOMAIN_ALLOCATED;
>  			*domain_id = i;

I would keep the indexes same but change how to set the 'domain_id' to
"*domain_id = i + 1;", that makes logic simpler.

Would it be simpler if the invalid domain id value used as UINT16_MAX instead of
'0'? This enables using 'domain_id' as index and prevent this error prone indexing.

And I think it makes sense to start the loop with "i = 0", instead of
'RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID', you are walking through the port list,
why to involve the 'RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID' here.

>  			return 0;
> @@ -5082,14 +5082,15 @@ enum rte_eth_switch_domain_state {
>  rte_eth_switch_domain_free(uint16_t domain_id)
>  {
>  	if (domain_id == RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID ||
> -		domain_id >= RTE_MAX_ETHPORTS)
> +		domain_id > RTE_MAX_ETHPORTS)
>  		return -EINVAL;
>  
> -	if (rte_eth_switch_domains[domain_id].state !=
> +	if (rte_eth_switch_domains[domain_id - 1].state !=
>  		RTE_ETH_SWITCH_DOMAIN_ALLOCATED)
>  		return -EINVAL;
>  
> -	rte_eth_switch_domains[domain_id].state = RTE_ETH_SWITCH_DOMAIN_UNUSED;
> +	rte_eth_switch_domains[domain_id - 1].state =
> +		RTE_ETH_SWITCH_DOMAIN_UNUSED;
>  
>  	return 0;
>  }
> 


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 12:47 Viacheslav Ovsiienko
2020-01-14 15:32 ` Ferruh Yigit [this message]
2020-01-15  8:50   ` Slava Ovsiienko
2020-01-15 12:39     ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2020-01-16 16:19 ` [dpdk-stable] [PATCH v2] " Viacheslav Ovsiienko
2020-01-16 19:38   ` Ferruh Yigit
2020-01-17 13:20     ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4bb1064-86e6-b536-3fc2-1901abe3df18@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox