Re: [dpdk-stable] 18.11.6 (LTS) patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 24/12/2019 10:07, Yu, PingX wrote:
> Kevin,
> Update the regression test result of Intel part. See the details as below.
> 

Hi Yu Ping,

thanks for the report and the log files.

> # Basic Intel(R) NIC testing
> * PF(i40e): Pass
> * PF(ixgbe): Pass
> * VF: Pass 
> * Build or compile: 2 bugs are found.
> 1. [dpdk-stable 18.11.6-rc1] meson build failed on FreeBSD12.1(See freebsd 12.1.log.txt)

I have a fix for this and another FreeBSD+meson issue that was hidden by
this.

> 2. [dpdk-stable 18.11.6-rc1] make build failed on fedora31.(See fedora31.log.txt)

I have fixes for this and some other issues I found with clang 9.0 and
gcc 9 on F31.

> * Intel NIC single core/NIC performance: Pass 
>  
> #Basic cryptodev and virtio testing
> * vhost/virtio basic loopback, PVP and performance test: Pass.
> * cryptodev: 2 bugs are found.
> 1. [dpdk-stable-18.11.6]Crypto: cryptodev_qat_autotest test failed. PS: issue passed on 18.11.3 and 18.11.5.

Looking at commits related to crypto/qat I see:

commit f7a7842ebec33c9cda3f5aac119adea4ce4f6999
Author: Hemant Agrawal <hemant.agrawal@nxp.com>
Date:   Wed Dec 18 10:15:27 2019 +0530

    test/crypto: fix session init failure for wireless case

    [ upstream commit 2967612f44b9726cb14242ae61658f2c944188d2 ]

commit 2674667aac56448c8bd151bc082e64ef4c88b649
Author: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Date:   Tue Oct 22 16:22:25 2019 +0200

    crypto/qat: fix AES CMAC mininum digest size

    [ upstream commit a7f8087bbdbe9a69fdd0bbc77237dd3a2014ce71 ]


commit ac0a49ed92588f961b1f5e659d27c70f078eea13
Author: Damian Nowak <damianx.nowak@intel.com>
Date:   Fri Aug 9 11:29:01 2019 +0200

    crypto/qat: fix null auth when using VFIO

    [ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ]


commit cde0c9ce68d3a5975a57ef09a28252c44cfe4ac6
Author: Fiona Trahe <fiona.trahe@intel.com>
Date:   Tue Sep 10 17:32:10 2019 +0100

    crypto/qat: fix digest length in XCBC capability

    [ upstream commit 0996ed0d5ad65b6419e3ce66a420199c3ed45ca9 ]

commit 8db57afd7ab9a3c12d73f1f5461415690b8c173c
Author: Julien Meunier <julien.meunier@nokia.com>
Date:   Wed Oct 16 13:21:11 2019 +0300

    cryptodev: fix checks related to device id

    [ upstream commit 3dd4435cf473f5d10b99282098821fb40b72380f ]

commit 8dec9eab6ac4eca67cb8df2dcdd5a09eaf86bc8e
Author: Julien Meunier <julien.meunier@nokia.com>
Date:   Wed Aug 7 11:39:23 2019 +0300

    cryptodev: fix initialization on multi-process

    [ upstream commit 1a60db7f354a52add0c1ea66e55ba7beba1a9716 ]

> 2. [dpdk-stable-18.11.6]Crypto: cryptodev_aesni_mb_autotest. Fail on 18.11.2~18.11.6 with latest configuration. 
> 

As you can see from that, I don't think the UT were ever really stable
and a lot of the stabilisation work came after 18.11. If the
maintainers/authors (cc) want to investigate, I can take patches or
revert if required. Otherwise, I won't investigate further or block the
release on UT fails.

thanks,
Kevin.

> Regards,
> Yu Ping
> 
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Wednesday, December 18, 2019 7:42 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
>> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
>> <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh
>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
>> Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: 18.11.6 (LTS) patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 18.11.6.
>>
>> The planned date for the final release is 31st January.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v18.11.6-rc1
>>
>> These patches are located at branch 18.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin.
>>
>> ---
>> Aaron Conole (1):
>>       test/interrupt: account for race with callback
>>
>> Abhishek Sachan (1):
>>       net/af_packet: fix stale sockets
>>
>> Adrian Moreno (4):
>>       vhost: fix vring memory partially mapped
>>       vhost: translate incoming log address to GPA
>>       vhost: prevent zero copy mode if IOMMU is on
>>       vhost: convert buffer addresses to GPA for logging
>>
>> Ajit Khaparde (9):
>>       net/bnxt: fix setting max RSS contexts
>>       net/bnxt: fix writing MTU to FW
>>       net/bnxt: fix crash in xstats get
>>       net/bnxt: fix resource qcaps with older FW
>>       net/bnxt: fix async link handling and update
>>       net/bnxt: fix flow flush handling
>>       net/bnxt: update trusted VF status only when it changes
>>       net/bnxt: fix doorbell register offset for Tx ring
>>       net/bnxt: get default HWRM command timeout from FW
>>
>> Akhil Goyal (1):
>>       crypto/dpaa2_sec: fix length retrieved from hardware
>>
>> Ali Alnubani (2):
>>       mk: fix build on arm64
>>       eal: fix header file install with meson
>>
>> Alvin Zhang (1):
>>       net/i40e: fix exception with multi-driver
>>
>> Amaranath Somalapuram (5):
>>       doc: fix l2fwd-crypto usage in CCP guide
>>       crypto/ccp: fix maximum queues and burst size
>>       crypto/ccp: fix CPU authentication crash
>>       crypto/ccp: fix scheduling of burst
>>       crypto/ccp: fix digest size capabilities
>>
>> Anatoly Burakov (2):
>>       mempool: use actual IOVA addresses when populating
>>       common/octeontx: add missing public symbol
>>
>> Andrew Rybchenko (5):
>>       ethdev: fix doc reference to FDIR disabled mode
>>       ethdev: remove redundant device info cleanup before get
>>       net/sfc: fix missing notification on link status change
>>       net/virtio: reject unsupported Tx multi-queue modes
>>       ethdev: avoid undefined behaviour on configuration copy
>>
>> Andrzej Ostruszka (4):
>>       doc: fix description of versioning macros
>>       eventdev: fix possible use of uninitialized var
>>       doc: fix tap guide
>>       net/dpaa2: fix possible use of uninitialized vars
>>
>> Anoob Joseph (1):
>>       examples/ipsec-secgw: fix access to freed packet
>>
>> Archana Muniganti (1):
>>       app/crypto-perf: fix input of AEAD decrypt
>>
>> Arek Kusztal (1):
>>       crypto/qat: fix AES CMAC mininum digest size
>>
>> Bernard Iremonger (1):
>>       examples/ipsec-secgw: fix unchecked return value
>>
>> Bruce Richardson (4):
>>       examples/vm_power: fix type of cmdline token in cli
>>       port: fix pcap support with meson
>>       examples: hide error for missing pkg-config path flag
>>       usertools: fix typo in SPDX tag of telemetry script
>>
>> Chaitanya Babu Talluri (1):
>>       examples/fips_validation: fix null dereferences
>>
>> Christian Ehrhardt (2):
>>       net/mlx4: fix build on ppc64
>>       build: avoid overlinking
>>
>> Ciara Power (3):
>>       app/testpmd: fix help for loop topology option
>>       ethdev: fix include of ethernet header file
>>       app/procinfo: use strlcpy for copying string
>>
>> Congwen Zhang (2):
>>       net/ixgbe: fix zeroing of RSS config
>>       net/e1000: fix zeroing of RSS config
>>
>> Damian Nowak (1):
>>       crypto/qat: fix null auth when using VFIO
>>
>> David Christensen (3):
>>       eal/ppc: fix 64-bit atomic exchange operation
>>       eal/linux: restore specific hugepage ordering for ppc
>>       vhost: fix build on RHEL 7.6 for Power
>>
>> David Hunt (2):
>>       examples/vm_power: fix build without i40e
>>       examples/vm_power: fix OOB frequency oscillations
>>
>> David Marchand (15):
>>       net/bonding: fix out of bound access in LACP mode
>>       net/bonding: fix LACP fast queue Rx handler
>>       net/bonding: fix unicast packets filtering
>>       ci: add missing dependencies for documentation
>>       net/qede: limit Rx ring index read for debug
>>       devtools: fix cleanup of checkpatch temporary file
>>       eal: remove dead code on NUMA node detection
>>       net/mlx4: remove dependency on libmnl in meson
>>       net/bonding: use non deprecated PCI API
>>       doc: fix internal links for older releases
>>       doc: fix link to AESNI mb external library
>>       doc/guides: clean repeated words
>>       build: remove unneeded meson option
>>       app/testpmd: report invalid command line parameter
>>       buildtools: fix build with coverage
>>
>> Dekel Peled (2):
>>       doc: fix description of links to EAL options pages
>>       net/mlx5: fix check of RSS queue index
>>
>> Dilshod Urazov (3):
>>       net/virtio: reject deferred Rx start
>>       net/virtio: reject deferred Tx start
>>       net/virtio: reject unsupported Rx multi-queue modes
>>
>> Eelco Chaudron (1):
>>       net/i40e: downgrade error log
>>
>> Fan Zhang (2):
>>       doc: fix AESNI-GCM limitations in crypto guide
>>       examples/fips_validation: fix auth verify
>>
>> Ferruh Yigit (7):
>>       bus/fslmc: fix global variable multiple definitions
>>       net/igb: fix global variable multiple definitions
>>       crypto/null: fix global variable multiple definitions
>>       crypto/virtio: fix global variable multiple definitions
>>       compress/octeontx: fix global variable multiple definitions
>>       test: fix global variable multiple definitions
>>       mk: remove library search path from binary
>>
>> Fiona Trahe (1):
>>       crypto/qat: fix digest length in XCBC capability
>>
>> Flavia Musatescu (2):
>>       app/testpmd: remove duplicated Rx offload commands
>>       net/af_packet: improve Tx statistics accuracy
>>
>> Flavio Leitner (1):
>>       vhost: fix IPv4 checksum
>>
>> Gagandeep Singh (1):
>>       net/enetc: fix BD ring alignment
>>
>> Gage Eads (1):
>>       event/sw: fix xstats reset value
>>
>> Gavin Hu (5):
>>       net/i40e: remove memory barrier from NEON Rx
>>       net/i40e: remove compiler barrier from NEON Rx
>>       net/bnxt: remove duplicate barrier
>>       net/bnxt: replace memory barrier for doorbell response
>>       net/bnxt: enforce IO barrier for doorbell command
>>
>> Guinan Sun (1):
>>       net/ixgbe: fix MACsec setting
>>
>> Harry van Haaren (1):
>>       test/service: fix wait for service core
>>
>> Hemant Agrawal (3):
>>       event/dpaa2: fix default queue configuration
>>       bus/dpaa: fix dpaa_sec blacklist
>>       test/crypto: fix session init failure for wireless case
>>
>> Honnappa Nagarahalli (1):
>>       test/lpm: fix measured cycles for delete
>>
>> Hui Zhao (2):
>>       net/bonding: fix slave id types
>>       net/bonding: fix OOB access in other aggregator modes
>>
>> Hyong Youb Kim (3):
>>       net/enic: fix probe for secondary process
>>       net/enic: fix crash in secondary process
>>       net/enic: re-enable link status change interrupt
>>
>> Igor Romanov (1):
>>       net/bonding: fix link speed update in broadcast mode
>>
>> Ivan Ilchenko (1):
>>       net/atlantic: remove double function declaration
>>
>> Ivan Malov (1):
>>       net/sfc: fix adapter lock usage on rule creation
>>
>> Jim Harris (1):
>>       vfio: fix leak with multiprocess
>>
>> Jin Yu (1):
>>       vhost: fix build dependency on hash lib
>>
>> Joyce Kong (3):
>>       net/i40e: fix address of first segment
>>       net/ixgbe: fix address of first segment
>>       doc: update arm64 cross build tool version
>>
>> Julien Meunier (2):
>>       cryptodev: fix initialization on multi-process
>>       cryptodev: fix checks related to device id
>>
>> Junyu Jiang (2):
>>       net/ixgbe: fix queue interrupt for X552/557
>>       net/bonding: fix port ID check
>>
>> Kalesh AP (18):
>>       net/bnxt: fix accessing variable before null check
>>       net/bnxt: fix multicast filter programming
>>       net/bnxt: return error if setting link up fails
>>       net/bnxt: remove unnecessary variable assignment
>>       net/bnxt: fix dereference before null check
>>       net/bnxt: cleanup comments
>>       net/bnxt: fix L4 checksum indication in non-vector Rx
>>       net/bnxt: fix IP checksum error indication
>>       net/bnxt: fix setting default MAC address
>>       net/bnxt: fix error checking of FW commands
>>       net/bnxt: fix check of address mapping
>>       net/bnxt: fix stats errors handling
>>       net/bnxt: move macro definitions to header file
>>       net/bnxt: fix extended port counter statistics
>>       net/bnxt: fix VF probe when MAC address is zero
>>       net/bnxt: fix coding style
>>       net/bnxt: fix deferred start of Tx queues
>>       net/bnxt: fix rx queue start/stop
>>
>> Kevin Traynor (6):
>>       common/cpt: fix possible null dereference
>>       compress/octeontx: remove commented out code
>>       event/opdl: remove commented out code
>>       net/bnxt: remove commented out code
>>       lib: fix log typos
>>       lib: fix doxygen typos
>>
>> Krzysztof Kanas (4):
>>       test/bonding: fix LSC related cases
>>       test/bonding: fix LSC timeout unit
>>       test: optimise fd closing in forks
>>       net/bonding: fix selection logic
>>
>> Lance Richardson (2):
>>       net/bnxt: advertise scatter Rx offload capability
>>       net/bnxt: fix mbuf free when clearing Tx queue
>>
>> Laurent Hardy (1):
>>       net/i40e: set speed to undefined for default case
>>
>> Lukasz Bartosik (1):
>>       examples/ipsec-secgw: fix default configuration
>>
>> Lunyuan Cui (3):
>>       net/e1000: fix link status update
>>       net/ixgbe: fix link status
>>       net/e1000: fix link status
>>
>> Marcin Hajkowski (1):
>>       power: fix socket indicator value
>>
>> Marcin Smoczynski (2):
>>       net/tap: fix blocked Rx packets
>>       examples/ipsec-secgw: fix GCM IV length
>>
>> Marvin Liu (3):
>>       vhost: fix virtqueue not accessible
>>       vhost: do not limit packed ring size
>>       net/virtio-user: fix setting filters
>>
>> Matan Azrad (3):
>>       ethdev: fix item expansion for RSS flow
>>       ethdev: fix last item detection on RSS flow expand
>>       app/testpmd: fix invalid port detaching
>>
>> Mattias Rönnblom (1):
>>       power: handle frequency increase with turbo disabled
>>
>> Maxime Coquelin (6):
>>       vhost: batch used descs chains write-back with packed ring
>>       vhost: un-inline dirty pages logging functions
>>       vhost: do not inline packed and split functions
>>       vhost: do not inline unlikely fragmented buffers code
>>       vhost: simplify descriptor buffer prefetching
>>       eal/x86: force inlining of all memcpy and mov helpers
>>
>> Maxime Leroy (1):
>>       net/vmxnet3: remove IP checksum from capabilities
>>
>> Michal Krawczyk (1):
>>       vfio: fix truncated BAR offset for 32-bit
>>
>> Nipun Gupta (5):
>>       event/dpaa: fix number of supported atomic flows
>>       common/dpaax: fallback to check separate memory node for VM
>>       net/dpaa2: add retry and timeout in packet enqueue API
>>       raw/dpaa2_cmdif: add retry and timeout in packet enqueue API
>>       net/dpaa2: set port in mbuf
>>
>> Nithin Dabilpuram (2):
>>       eal: add ack interrupt API
>>       net/qede: use ack in interrupt handlers
>>
>> Noa Ezra (1):
>>       net/vhost: fix redundant queue state event
>>
>> Pallantla Poornima (1):
>>       net/axgbe: fix double unlock
>>
>> Pavan Nikhilesh (4):
>>       reciprocal: fix off-by-one with 32-bit divisor
>>       app/eventdev: fix divide by zero
>>       app/eventdev: check function errors
>>       event/octeontx: fix partial Rx packet handling
>>
>> Pavel Belous (1):
>>       net/atlantic: add FW mailbox guard mutex
>>
>> Peng Huang (1):
>>       app/testpmd: fix Tx checksum when TSO enabled
>>
>> Phil Yang (1):
>>       net/mlx5: fix Rx CQ doorbell synchronization on aarch64
>>
>> Radu Nicolau (1):
>>       security: fix doxygen fields
>>
>> Rahul Gupta (1):
>>       net/bnxt: fix Rx queue count
>>
>> Rahul Lakkireddy (7):
>>       net/cxgbe: add prefix to global functions
>>       net/cxgbe: fix null access when allocating CLIP entry
>>       net/cxgbe: fix slot allocation for IPv6 flows
>>       net/cxgbe: fix parsing VLAN ID rewrite action
>>       net/cxgbe: fix prefetch for non-coalesced Tx packets
>>       net/cxgbe: avoid polling link status before device start
>>       net/cxgbe: fix races on flow API operations
>>
>> Rasesh Mody (1):
>>       net/qede/base: fix page index for PBL chains
>>
>> Raslan Darawsheh (1):
>>       net/mlx: fix debug build with icc
>>
>> Robin Jarry (2):
>>       usertools: fix pmdinfo with python 3 and pyelftools>=0.24
>>       usertools: fix telemetry client with python 3
>>
>> Ruifeng Wang (4):
>>       net/ixgbe: remove memory barrier from NEON Rx
>>       lib/distributor: fix deadlock on aarch64
>>       test/distributor: fix spurious failure
>>       net/ixgbe: support packet type with NEON
>>
>> Sachin Saxena (1):
>>       net/dpaa2: fix Rx offload flags on jumbo MTU set
>>
>> Santoshkumar Karanappa Rastapur (5):
>>       net/bnxt: fix flow steering
>>       net/bnxt: fix ping with MTU change
>>       net/bnxt: fix MAC/VLAN filter allocation
>>       net/bnxt: fix forwarding with higher mbuf size
>>       net/bnxt: fix crash after removing and adding slaves
>>
>> Seth Howell (1):
>>       bus/pci: remove useless link dependency on ethdev
>>
>> Shahed Shaikh (6):
>>       net/qede: refactor Rx and Tx queue setup
>>       net/qede: fix odd number of queues usage in 100G mode
>>       net/qede: fix RSS configuration as per new allocation method
>>       net/qede: fix stats flow as per new allocation method
>>       net/qede: fix setting MTU
>>       net/qede: fix setting VLAN strip mode
>>
>> Shougang Wang (2):
>>       app/testpmd: fix crash on port reset
>>       net/ixgbe: fix performance drop caused by MACsec
>>
>> Shweta Choudaha (1):
>>       net/igb: fix PHY status if PHY reset is not blocked
>>
>> Somnath Kotur (1):
>>       net/bnxt: expose some missing counters in port stats
>>
>> Stephen Hemminger (7):
>>       bus/pci: fix Intel IOMMU sysfs access check
>>       service: use log for error messages
>>       test/mbuf: fix forged mbuf in clone test
>>       net/bnxt: fix debug log level
>>       app/testpmd: block xstats for hidden ports
>>       examples/multi_process: check server port validity
>>       examples/multi_process: fix client crash with sparse ports
>>
>> Thibaut Collet (2):
>>       net/virtio: fix Rx stats with vectorized functions
>>       net/virtio: get all pending Rx packets in vectorized paths
>>
>> Thierry Herbelot (5):
>>       crypto/dpaa_sec: fix IOVA table
>>       crypto/octeontx: enable unbinding
>>       drivers/crypto: remove some invalid comments
>>       doc: fix a common typo in NIC guides
>>       crypto/openssl: use local copy for session contexts
>>
>> Thomas Monjalon (5):
>>       build: remove redundant libs from pkgconfig
>>       net/mlx: fix meson build with custom dependency path
>>       net/mlx: fix build with make and recent gcc
>>       net/szedata2: fix dependency check
>>       ethdev: limit maximum number of queues
>>
>> Ting Xu (1):
>>       app/testpmd: fix CRC strip command
>>
>> Tiwei Bie (8):
>>       net/virtio: remove remaining simple Tx related stuff
>>       doc: fix typo in virtio in-order Rx function name
>>       doc: fix format in virtio guide
>>       vhost: fix slave request fd leak
>>       vhost: forbid reallocation when running
>>       vhost: fix vring address handling during live migration
>>       vhost: protect vring access done by application
>>       net/virtio-user: drop attribute unused for memory callback
>>
>> Vakul Garg (2):
>>       crypto/dpaa_sec: fix auth-cipher check for AEAD
>>       examples/ipsec-secgw: fix SHA256-HMAC digest length
>>
>> Viacheslav Ovsiienko (1):
>>       net/mlx5: fix BlueField VF type recognition
>>
>> Wangyu (Eric) (1):
>>       bus/pci: align next mapping address on page boundary
>>
>> Wei Zhao (2):
>>       net/ixgbe: enable new PF host mbox version
>>       net/ixgbe: fix VF RSS offloads configuration
>>
>> Xiao Wang (3):
>>       doc: fix typo in l2fwd-crypto guide
>>       net/fm10k: fix mbuf free in vector Rx
>>       net/ifc: check VFIO query error
>>
>> Xiao Zhang (7):
>>       net/i40e: fix VF runtime queues RSS config
>>       net/e1000: fix i219 hang on reset/close
>>       net/e1000: fix memory barrier usage in Tx
>>       net/ixgbe: fix X553 speed capability
>>       net/i40e: fix integer overflow
>>       examples/l3fwd-power: fix Rx interrupt disabling
>>       net/ixgbe: fix link status
>>
>> Xiaolong Ye (1):
>>       ethdev: fix typos for ENOTSUP
>>
>> Xiaoyu Min (5):
>>       net/mlx5: validate flow rule item order
>>       net/mlx5: allow pattern start from IP
>>       ethdev: fix expand RSS flows
>>       net/mlx5: fix crash on hash Rx queue handling for drop
>>       net/mlx5: improve flow item IP validation
>>
>> Xueming Li (3):
>>       malloc: fix realloc copy size
>>       malloc: fix realloc padded element size
>>       malloc: fix memory element size in case of padding
>>
>> Yasufumi Ogawa (1):
>>       net/null: fix multi-process Rx and Tx
>>
>> Yong Wang (1):
>>       net/ixgbe: remove redundant assignment
>