From: "Laatz, Kevin" <kevin.laatz@intel.com>
To: Flavia Musatescu <flavia.musatescu@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>,
ciara.power@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-stable] [PATCH v2] telemetry: fix build warnings seen when using gcc 9
Date: Wed, 3 Jul 2019 17:39:33 +0100 [thread overview]
Message-ID: <d549826f-57f7-bd9d-cd29-c7e01a2fdedd@intel.com> (raw)
In-Reply-To: <1562145823-18398-1-git-send-email-flavia.musatescu@intel.com>
On 03/07/2019 10:23, Flavia Musatescu wrote:
> Suppress the unaligned packed member address warnings by extending
> the telemetry library build flags with -Wno-address-of-packed-member
> option, through the WERROR_FLAGS makefile variable.
>
> With this change additional warnings are turned on to be treated as errors,
> which causes the following build issues to be seen:
> - no previous prototype [-Werror=missing-prototypes]
> - initialization discards ‘const’ qualifier from pointer target type
> [-Werror=discarded-qualifiers]
> - old-style function definition [-Werror=old-style-definition]
> - variable may be used before its value is set (when using icc compiler).
>
> Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets")
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> Fixes: fff6df7bf58e ("telemetry: fix using ports of different types")
> Fixes: 4080e46c8078 ("telemetry: support global metrics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Flavia Musatescu <flavia.musatescu@intel.com>
> ---
> Cc: ciara.power@intel.com
> Cc: bruce.richardson@intel.com
> Cc: reshma.pattan@intel.com
> ---
> lib/librte_telemetry/Makefile | 2 +-
> lib/librte_telemetry/meson.build | 2 +-
> lib/librte_telemetry/rte_telemetry.c | 19 ++++++------
> lib/librte_telemetry/rte_telemetry_internal.h | 4 +++
> lib/librte_telemetry/rte_telemetry_parser.c | 8 ++---
> lib/librte_telemetry/rte_telemetry_parser_test.c | 27 ++++++++--------
> lib/librte_telemetry/rte_telemetry_parser_test.h | 39 ------------------------
> 7 files changed, 33 insertions(+), 68 deletions(-)
> delete mode 100644 lib/librte_telemetry/rte_telemetry_parser_test.h
>
LGTM, thanks!
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
next prev parent reply other threads:[~2019-07-03 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 14:20 [dpdk-stable] [PATCH] " Flavia Musatescu
2019-07-03 9:23 ` [dpdk-stable] [PATCH v2] " Flavia Musatescu
2019-07-03 16:39 ` Laatz, Kevin [this message]
2019-07-04 16:49 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-08-23 10:01 ` [dpdk-stable] [dpdk-dev] [PATCH] " Kevin Traynor
2019-08-23 16:07 ` Musatescu, Flavia
2019-08-28 9:34 ` [dpdk-stable] [PATCH v2] " Flavia Musatescu
2019-08-27 15:52 [dpdk-stable] [PATCH] Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable Flavia Musatescu
2019-08-28 9:46 ` [dpdk-stable] [PATCH v2] telemetry: fix build warnings seen when using gcc 9 Flavia Musatescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d549826f-57f7-bd9d-cd29-c7e01a2fdedd@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=flavia.musatescu@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).