From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C25BA2F6B for ; Tue, 8 Oct 2019 16:18:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1801F1C12C; Tue, 8 Oct 2019 16:18:38 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4ECBF1BF9D; Tue, 8 Oct 2019 16:18:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2019 07:18:33 -0700 X-IronPort-AV: E=Sophos;i="5.67,270,1566889200"; d="scan'208";a="206646437" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/AES256-SHA; 08 Oct 2019 07:18:32 -0700 To: Matan Azrad , Ferruh Yigit , Wenzhuo Lu , Jingjing Wu Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <1564403817-13438-1-git-send-email-matan@mellanox.com> <4d4ec2e2-0fe4-0901-76c6-28d17d80cbc8@intel.com> <93e46254-6d07-83d6-5999-04f9b0309dfd@intel.com> From: "Yigit, Ferruh" Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@linux.intel.com; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 8 Oct 2019 15:18:28 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 7/31/2019 7:11 AM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> On 7/30/2019 7:34 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit >>>> On 7/30/2019 4:56 PM, Matan Azrad wrote: >>>>> Hi Ferruh >>>>> >>>>> From: Ferruh Yigit >>>>>> Sent: Tuesday, July 30, 2019 6:22 PM >>>>>> To: Matan Azrad ; Wenzhuo Lu >>>>>> ; Jingjing Wu >>>>>> Cc: dev@dpdk.org; stable@dpdk.org >>>>>> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter >>>>>> offload configuration >>>>>> >>>>>> On 7/30/2019 2:17 PM, Matan Azrad wrote: >>>>>>> Hi Ferruh >>>>>>> >>>>>>> From: Ferruh Yigit >>>>>>>> Sent: Tuesday, July 30, 2019 4:09 PM >>>>>>>> To: Matan Azrad ; Wenzhuo Lu >>>>>>>> ; Jingjing Wu >>>>>>>> Cc: dev@dpdk.org; stable@dpdk.org >>>>>>>> Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter >>>>>>>> offload configuration >>>>>>>> >>>>>>>> On 7/29/2019 1:36 PM, Matan Azrad wrote: >>>>>>>>> When the mbuf data size cannot contain the maximum Rx packet >>>>>>>>> length with the mbuf headroom, a packet should be scattered in >>>>>>>>> more than one >>>>>>>> mbuf. >>>>>>>>> >>>>>>>>> The application did not configure scatter offload in the above case. >>>>>>>>> >>>>>>>>> Enable the Rx scatter offload in the above case. >>>>>>>>> >>>>>>>>> Fixes: 33f9630fc23d ("app/testpmd: create mbuf based on max >>>>>>>>> supported >>>>>>>>> segments") >>>>>>>>> Cc: stable@dpdk.org >>>>>>>>> >>>>>>>>> Signed-off-by: Matan Azrad >>>>>>>> >>>>>>>> Deferring the patchset to next release, they were late anyway and >>>>>>>> not actually fixing a defect, safer to defer than getting them in rc3. >>>>>>> >>>>>>> Yes this patch came late for RC3 but it is a fix. >>>>>>> >>>>>>> What are you concerns here? >>>>>>> Why don't you think defect found? >>>>>> >>>>>> First patch changes the behavior, when mbuf size is larger than >>>>>> configured size and user didn't provided the scatter offload, >>>>>> should test application automatically enable it? >>>>> >>>>> No, only when the mbuf size is smaller than the max_rx_pkt_len with >>>> headroom. >>>>> If scatter is not enabled in the above case, how can the PMD provide >>>>> a >>>> packet with max_rx_pkt_len size? >>>>> >>> >>> Answer here? >> >> Is it because drivers also "automatically" enable scattered Rx based on other >> values? > > Scatter is a defined RX offload. > Like other offloads I think it always should be explicitly set by the user if he wants it, and vice versa. > If the user doesn't configure it, the PMD should not scatter packets because the user doesn't expect multi-mbuf packets in datapath and maybe even doesn't handle it. +1 So what about having the log message but not implicitly update the offload config? > > So, I think the above case is a user conflict in Rx configuration and like other conflicts it should cause an error. > In MLX5 PMD, an error will be returned from Rx setup. > >