From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5BF022B9D; Wed, 1 Mar 2017 09:16:09 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DC962E6041; Wed, 1 Mar 2017 08:16:09 +0000 (UTC) Received: from [10.36.116.153] (ovpn-116-153.ams2.redhat.com [10.36.116.153]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v218G6du007025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Mar 2017 03:16:08 -0500 To: Yuanhan Liu , dev@dpdk.org References: <1487839550-21800-1-git-send-email-yuanhan.liu@linux.intel.com> Cc: stable@dpdk.org From: Maxime Coquelin Message-ID: Date: Wed, 1 Mar 2017 09:16:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1487839550-21800-1-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 01 Mar 2017 08:16:09 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH] vhost: fix multiple queue not being enabled for older kernels X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 08:16:09 -0000 On 02/23/2017 09:45 AM, Yuanhan Liu wrote: > Some macros (say VIRTIO_NET_F_MQ) are needed for enabling multiple queue, > however they are introduced since kernel v3.8, meaning build error happens > if we build DPDK vhost on those platforms. > > 71dfdbe66a66 ("vhost: fix build with kernel < 3.8") meant to fix it, but > in a wrong way: it completely disables the MQ features for those kernels. > However, the MQ feature doesn't depend on the kernel at all (except the > macros dependency stated above), that we could still enable the MQ feature > even the host kernel has no such support. > > The right fix is to define the macro if it's not defined. > > Fixes: 71dfdbe66a66 ("vhost: fix build with kernel < 3.8") > > Cc: stable@dpdk.org > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/vhost.c | 2 +- > lib/librte_vhost/vhost.h | 11 ++++------- > lib/librte_vhost/vhost_user.c | 2 +- > 3 files changed, 6 insertions(+), 9 deletions(-) > Agree this is the right fix: Reviewed-by: Maxime Coquelin Thanks! Maxime