From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22C7B4337F for ; Mon, 20 Nov 2023 14:58:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F171B42DDE; Mon, 20 Nov 2023 14:58:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AB6B142DD2 for ; Mon, 20 Nov 2023 14:58:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700488729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dGp0jkC3mQQBcRjhTXdNs4Lpu3fv86tQMNG2G5ZiC3Q=; b=BhmYXTKo5NYhpgNWhQZCk8PMzqvO6NbL01m/OLuBiJynr7RY/TprOh8zThFKdqG0tn1O72 zm1olQb7lp7Qf67CHOjlqiadA7w5pEWT58989mff+KAyyh0N/eYGyAmRVwEz4Qa+QGtxvW Os5OSHs7v4jd4xhOSdoaCD4uMcYEQGc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-jFo0IkPQO_uuwGletR8Xhw-1; Mon, 20 Nov 2023 08:58:46 -0500 X-MC-Unique: jFo0IkPQO_uuwGletR8Xhw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33174557ed4so1148731f8f.1 for ; Mon, 20 Nov 2023 05:58:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700488725; x=1701093525; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dGp0jkC3mQQBcRjhTXdNs4Lpu3fv86tQMNG2G5ZiC3Q=; b=JcdKAoQynq4aNuZ03vhJ6cFQdTuAlAhA93c0/IF541eqarM56rveNC2dYwByf15etk BdTA55VGVHsBt4O9spHgPYWRJhLSuzWu86qErj2YAkayHJEpg0RdTS1N/npFrZTHIxet eWgSEyLiYM2bVFEN6d80weR3QK0wYDPL/Q4nhkXvDHLjFug4CPfQEbgGR8USrsWCjVrr 4KZpirYFj9vAoYbZ6EpHuV3pbA6rhoVPQPIJKUQ+X3lp7CFLeydb/2thuEAJC1q7iuHw 9WKectWSnnIdEm9RZh5Ot+T7SnsPPiN/LoObphNfxA8p6+FixHhn8jTHeQGI/l3SdBMB KZtg== X-Gm-Message-State: AOJu0Yznh2ZJo1wamf5m0UHdwbhbkrR75XVYYf78GdL0edfLQeO3jVpT xQRuEyuxggztZV46ThjEqI8/LagYNmQYru/QSmDZrl1JWx0zGa+g4fzxUADLvJ98Lp8WWsCTDvt u3aUhhpc= X-Received: by 2002:a5d:588c:0:b0:332:c723:12aa with SMTP id n12-20020a5d588c000000b00332c72312aamr3036229wrf.9.1700488725443; Mon, 20 Nov 2023 05:58:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEIAzdkfErJT4oTf1+LEvfEmpsqpN50UUxDymUS4csT+ykGjRI3KvxoeaPDw/30Hps6V328g== X-Received: by 2002:a5d:588c:0:b0:332:c723:12aa with SMTP id n12-20020a5d588c000000b00332c72312aamr3036213wrf.9.1700488725127; Mon, 20 Nov 2023 05:58:45 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id p17-20020a5d48d1000000b003316ad360c1sm10587465wrs.24.2023.11.20.05.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 05:58:44 -0800 (PST) Message-ID: Date: Mon, 20 Nov 2023 13:58:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: "Richardson, Bruce" , Srikanth Yalavarthi Cc: dpdk stable , "Xueming(Steven) Li" , Luca Boccassi References: <20231116132348.557257-1-ktraynor@redhat.com> <20231116132348.557257-43-ktraynor@redhat.com> From: Kevin Traynor Subject: Re: patch 'build: add libarchive to optional external dependencies' has been queued to stable release 21.11.6 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 17/11/2023 09:00, Richardson, Bruce wrote: > After applying this patch, the link of DPDK may fail if all dependencies of libarchive are not installed. For some reason the install of the libarchive-dev package on many distros does not install all correct dependencies and the user needs to install a few other dev packages manually. (To me, this looks like something that could do with being fixed in the packages - it's not something we can really control) > > Srikanth, do you think this patch needs to be backported? If there is no compelling need, I'd maybe avoid doing so to avoid possible unexpected build issues for users. > Hi Bruce. Thanks for highlighting this. I just hit this issue myself with 23.11-rc3 and had to install lz4-devel, bzip2-devel and libacl-devel to be able to link. I don't think we should take this patch, so I'm going to drop from 21.11 backports. thanks, Kevin. > /Bruce > >> -----Original Message----- >> From: Kevin Traynor >> Sent: Thursday, November 16, 2023 1:23 PM >> To: Srikanth Yalavarthi >> Cc: Richardson, Bruce ; dpdk stable >> >> Subject: patch 'build: add libarchive to optional external dependencies' >> has been queued to stable release 21.11.6 >> >> Hi, >> >> FYI, your patch has been queued to stable release 21.11.6 >> >> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. >> It will be pushed if I get no objections before 11/21/23. So please >> shout if anyone has objections. >> >> Also note that after the patch there's a diff of the upstream commit vs >> the >> patch applied to the branch. This will indicate if there was any rebasing >> needed to apply to the stable branch. If there were code changes for >> rebasing >> (ie: not only metadata diffs), please double check that the rebase was >> correctly done. >> >> Queued patches are on a temporary branch at: >> https://github.com/kevintraynor/dpdk-stable >> >> This queued commit can be viewed at: >> https://github.com/kevintraynor/dpdk- >> stable/commit/aa40722948ac2dc15f93b8598f560029c757b645 >> >> Thanks. >> >> Kevin >> >> --- >> From aa40722948ac2dc15f93b8598f560029c757b645 Mon Sep 17 00:00:00 2001 >> From: Srikanth Yalavarthi >> Date: Sun, 5 Nov 2023 20:12:43 -0800 >> Subject: [PATCH] build: add libarchive to optional external dependencies >> >> [ upstream commit 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 ] >> >> In order to avoid linking with Libs.private, libarchive >> is not added to ext_deps during the meson setup stage. >> >> Since libarchive is not added to ext_deps, cross-compilation >> or native compilation with libarchive installed in non-standard >> location fails with errors related to "cannot find -larchive" >> or "archive.h: No such file or directory". In order to fix the >> build failures, user is required to define the 'c_args' and >> 'c_link_args' with '-I' and '-L'. >> >> This patch adds libarchive to ext_deps and further would not >> require setting c_args and c_link_args externally. >> >> Fixes: 40edb9c0d36b ("eal: handle compressed firmware") >> >> Signed-off-by: Srikanth Yalavarthi >> Acked-by: Bruce Richardson >> --- >> config/meson.build | 5 ----- >> lib/eal/meson.build | 3 +++ >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/config/meson.build b/config/meson.build >> index a79a3ed39c..b40302da02 100644 >> --- a/config/meson.build >> +++ b/config/meson.build >> @@ -208,9 +208,4 @@ libarchive = dependency('libarchive', required: false, >> method: 'pkg-config') >> if libarchive.found() >> dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1) >> - # Push libarchive link dependency at the project level to support >> - # statically linking dpdk apps. Details at: >> - # https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/ >> - add_project_link_arguments('-larchive', language: 'c') >> - dpdk_extra_ldflags += '-larchive' >> endif >> >> diff --git a/lib/eal/meson.build b/lib/eal/meson.build >> index 1722924f67..f223c6d7a5 100644 >> --- a/lib/eal/meson.build >> +++ b/lib/eal/meson.build >> @@ -23,4 +23,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD') >> ext_deps += libbsd >> endif >> +if dpdk_conf.has('RTE_HAS_LIBARCHIVE') >> + ext_deps += libarchive >> +endif >> if cc.has_function('getentropy', prefix : '#include ') >> cflags += '-DRTE_LIBEAL_USE_GETENTROPY' >> -- >> 2.41.0 >> >> --- >> Diff of the applied patch vs upstream commit (please double-check if >> non-empty: >> --- >> --- - 2023-11-16 13:21:53.587627939 +0000 >> +++ 0043-build-add-libarchive-to-optional-external-dependenci.patch >> 2023-11-16 13:21:52.506946538 +0000 >> @@ -1 +1 @@ >> -From 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 Mon Sep 17 00:00:00 2001 >> +From aa40722948ac2dc15f93b8598f560029c757b645 Mon Sep 17 00:00:00 2001 >> @@ -5,0 +6,2 @@ >> +[ upstream commit 22f7184e8b5f1b546ac26dd0bde8c3c6038a7e03 ] >> + >> @@ -20 +21,0 @@ >> -Cc: stable@dpdk.org >> @@ -30 +31 @@ >> -index 39ed4ba7d3..d732154731 100644 >> +index a79a3ed39c..b40302da02 100644 >> @@ -33 +34 @@ >> -@@ -252,9 +252,4 @@ libarchive = dependency('libarchive', required: >> false, method: 'pkg-config') >> +@@ -208,9 +208,4 @@ libarchive = dependency('libarchive', required: >> false, method: 'pkg-config') >> @@ -44 +45 @@ >> -index 9942104386..e1d6c4cf17 100644 >> +index 1722924f67..f223c6d7a5 100644 >> @@ -47 +48 @@ >> -@@ -22,4 +22,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD') >> +@@ -23,4 +23,7 @@ if dpdk_conf.has('RTE_USE_LIBBSD') >